From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F59842B30; Thu, 18 May 2023 03:37:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD9A742B71; Thu, 18 May 2023 03:37:39 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2120.outbound.protection.outlook.com [40.107.244.120]) by mails.dpdk.org (Postfix) with ESMTP id 69F6E40E25 for ; Thu, 18 May 2023 03:37:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WrIhnCaca3Sovv+D8IspxXfWkI4sM7YsanpoDU1slgH0gNM0TZHuV7PoxVhqUCp22jlqHBfSDXDYfbwS9fkYibU/WzL0azkftilULFH0feXLcfEkoBTPf21rubV8rfs2g4RWskuH5y30vPq/YquaBgVtx+3CLpWzyIYGarfvY1dykkvNuVCfIHClydfoq8blu5JRV5W6AFfmPoPkboR7yAMBfT0f7DXSV5T04lwFwRhCpUgPbE2hFh0Xd0wZTZABtL1auIRj4irSjhxKDgv9TNTrC1EDdu4+uTpjbOUTxCm8Y00YK2r1r05sc0r1LJnUjEebgs9QTjz2nhy0pHk+Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YIUi3kIzaxYGphkbNgvnTolmpHB7p+LRPFyEMX7KTU8=; b=b72FHvH6tksAcfzEzYY9vy0AgJPMgGiuvFl/c7gY8t7AZtxMgvHkYmmJCxJSKG6conwf2olBWGYe32SfkYQCSB+E1aZ8DeAVL5WAyn1rkjRiRkowBqCrbRBJI33y/CZlXc2+GzPCRk2Tku/Sw4M2XCHUSWnmWa7ADXtNKgZISruHyNPnPQcpKAwfq66ehOjc6d72DfnJhgurD9fOlPVOhzyJkQpl2E3x6T//tgnIKJU36J7bFlDJVOYTZN6qUyH/HojQnTmpgj0SZnBYqkzRykCZyOfdEczhrTa2K4b4XaRben/n314IH9T4I3NuZV9XhNQrfzBkvVzpdV1SKIzp/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YIUi3kIzaxYGphkbNgvnTolmpHB7p+LRPFyEMX7KTU8=; b=CJ0SoNjdTq9NR2oWeVIv5mBmlTl3oHzpFnZhFk5rVeOSA8uFbrL4TI1FMKVZ2KXCtD42C6zpNnwPCUeZh62L9rUPcvfEB+uORdTuOSdYjb3pQExYN7bOx1I693NThFotGz3+36atU5jAUaZBjZrVHSKxOAPVAXRx3TUmwR8H8YE= Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by CH0PR13MB5081.namprd13.prod.outlook.com (2603:10b6:610:ec::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.19; Thu, 18 May 2023 01:37:33 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ac2e:52b6:82ec:4994]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ac2e:52b6:82ec:4994%3]) with mapi id 15.20.6411.017; Thu, 18 May 2023 01:37:33 +0000 From: Chaoyong He To: Stephen Hemminger , "dev@dpdk.org" CC: Niklas Soderlund Subject: RE: [PATCH 07/20] net/nfp: remove word sanity Thread-Topic: [PATCH 07/20] net/nfp: remove word sanity Thread-Index: AQHZiNrq3t7AGxuI9UK3IxSouKPfSa9fP7pA Date: Thu, 18 May 2023 01:37:32 +0000 Message-ID: References: <20230517161603.117728-1-stephen@networkplumber.org> <20230517161603.117728-8-stephen@networkplumber.org> In-Reply-To: <20230517161603.117728-8-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR13MB5545:EE_|CH0PR13MB5081:EE_ x-ms-office365-filtering-correlation-id: 1bc3dcac-0745-45b8-25cb-08db57407381 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3f3HovS5+PwMkAWQLDUpkQp/vSHoeYkllUtSqJ5SwDhjuozs+VVnDPsXXJSc78t2tvWWYPyVen54Kq0rBYJbAqZxI+4GLFK+HvMFg0CnuctmWg9RZolVqvIQjuM81xrL42Qsmub6izAd8WimG42eOEnMPWgxdiFyhurt/m0L3XYJ5qnhAovstzIFaBOfH1b8Uww3n+75xHc39A89z6th1ZjfrFd94aZtIl4zmbTxsuTERYMqXa4LlkysdOBbky1HGfAkG1DcYfdHwXw2z2pgtgtxG5L8XTORinrbM+OJ5hfACfQOvhwjfMFJfGRrnLgeJ/4H1PbzBBC2fLeR8xXWaXeGqPWWNSlmm2ArBoTc6iu78J4o5KLOt2phZvUPQzygt4tzvASCc8khFdY7h+4nPzHC+P3FETQk1KRg3pxHfpcJNpS2Om2zEnRJxqJTQ3s5OBsL0+/hCYpFWBfh0OVFoyyqWYhr0/goCs56acMYrty5Q018V0Y3bGddefoQSujaM4f2YOsuc2N/V4KV48LrJVVKpVBRXOVZWmHCABlLlb7z0e7mkGM30OsY1tdDZNP1p0VbsBBNi7S7OCUhqYyExPFhd30VfsyWnl8ZbNgPq1sv4QxBlN2Wq9sKrPGtFVcp x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(136003)(366004)(39840400004)(396003)(451199021)(53546011)(6506007)(26005)(9686003)(186003)(107886003)(66476007)(83380400001)(5660300002)(64756008)(66446008)(66556008)(66946007)(76116006)(52536014)(44832011)(4326008)(316002)(41300700001)(8936002)(8676002)(7696005)(71200400001)(110136005)(478600001)(2906002)(55016003)(33656002)(86362001)(38070700005)(38100700002)(122000001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2gDX6oVIm/0ofwBKEAZFG4hAbopBHF1za//MQJQj0QmpdPxAT6tmJpBszVEv?= =?us-ascii?Q?h6QYMJKWI8oF6Q9OWS1AZb65cKs5rCnXAIa4tEILQe0tR44K9C9W99bpqomz?= =?us-ascii?Q?f5rK46wFUgIN0Dcv14kcmul1XpYLbKHvH9uo5ltiEc+ZbL7mazVTHmrLy3Wa?= =?us-ascii?Q?7WTSPeFovWYXJjeuBbBIE46+XmE1XharGEDJSxHo1E/yeTzUZ+GrfX25e+FY?= =?us-ascii?Q?b0TZB1kzhr+la1HIZ1YTmGFmGbjP67b5+1ViYzursrUrmdZFfs7Gb6NS7eH8?= =?us-ascii?Q?KXwTg573T8q7cS9O+z1dY7fSH2VLFlKINi+lDvbuIUEffmwb8qoLhyLeHvG4?= =?us-ascii?Q?SdbnFXc8+GhqrN2fBVQh9G+zZDJhUq9HzoNLt5MtzSvtbcTcj6MuFqcipEPs?= =?us-ascii?Q?hyfocwacV7TL/wMvT2sK83nvdpSVYsdF4kO5hVLUp38qu8cKaoqFwMuLFTjf?= =?us-ascii?Q?XwyjcodZ3QW8ST5HULo+OJoqcJcFnHdNZPuN8XeftGMX2/ryYBGAr9rKR7+R?= =?us-ascii?Q?I3qN8uuC2mVU+bFdU4/U2Y+qtW/HIopFhqrrJQzwm3LhihBM48peikDcn6yC?= =?us-ascii?Q?jh/BtWwg3V7g3OYgu9YYNu3LjRkKXsPSQkxhVn4Nqi3orQGJqCaEWMCUwfuk?= =?us-ascii?Q?Fp7npU2wFnJR+12IW6Pyv5RbTsuiNT8a0wGFzdsNNu809E73NDzY9ohG9Eor?= =?us-ascii?Q?kp/imUe51YTM2S1cKRP63PTc1BR2wxDypCq5L0vYaAQ8lW3ptWNXrG2snvFq?= =?us-ascii?Q?BKtTSTGuEsV9WR+pzkUfiRXKMSGAMKhN7Cpws/u4u0MUczRb+En+HEww+Il/?= =?us-ascii?Q?Qen0kGoSy2BUeX3ZnYNgNzShAhsJ//yz8YmNDiWpyZRQEboh/9/Yoyvf2ci1?= =?us-ascii?Q?f9cDzlV+Ilp1E28Qs+XjEYPjN1NMplJUzdUOfkj/5ZFYWDeRu8K2qpu0zG6Z?= =?us-ascii?Q?IR74krYXZuAw3NU95MsIllbMFPgnPXVK3WLfTyK/XyVVgsSQulfhI+Y8JIgP?= =?us-ascii?Q?vLs9UPMv1rxJnfbQrxLgA4ArMgdv9tt1ay56DPkL7/Nsdit1tVABWp7a+R9q?= =?us-ascii?Q?uf6SB7phEG/TSQtmxARvhEhhns9dw6HXfh9mHksn3KYycj6JwHuOVxWAm2C2?= =?us-ascii?Q?tdrHArOBb8efFTiYncRHFO1hPmurf9zkeCXzMbQd0Q8yL8LsM45zconeYqjK?= =?us-ascii?Q?jXbIfDD7WsYWSnqzjT7oz1yfarTndFlAMtUwTa8CMLIvCvKLwviwZsKlxQNv?= =?us-ascii?Q?n2wgy4wMmrjd9QiEHo/mMOqVm8QBJ7FWoOph1s0hOkY5sbKJDNbg5sRD5Lh/?= =?us-ascii?Q?9DVR5XeXqcBl96a5xuur6CRlp26747Be8Zu+Gc8SYUXUnZch6hI9cht7z5sS?= =?us-ascii?Q?v98m13I1qgrGguAnls+5QWTz92x8GaKWrz0PbK/f2mBRnXiHCZKWSjOM/UGK?= =?us-ascii?Q?dny7Xjtmy6gm9LN1ajeeuSMBsw8s1LHNk4djkVnlIw0d3fsODOa+kfPbw3Jh?= =?us-ascii?Q?rbont0rzTO/ckEUlTizNnaMoSf9K8CKcCHNTU4hkHYXuf61IKIEP4T0i3VOD?= =?us-ascii?Q?Y5MOPz39AagzE+pyOGK3lp573Vj+7u3Ho3Soewbz?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc3dcac-0745-45b8-25cb-08db57407381 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2023 01:37:32.9896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VCHHA/5/T9EH1p9aiK+SDvCYEr8j31q2tpUQH+aFtkLDJDKBpbUo8jzTWP0+eSexKcq3XOtzj8xVyh1KnmAP88SlN88lilDeztE/b+IBFuM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR13MB5081 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org That looks good, thanks! Actually, we also will delete it in an upcoming patch, so it's okay to remo= ve it here. Reviewed-by: Chaoyong He > -----Original Message----- > From: Stephen Hemminger > Sent: Thursday, May 18, 2023 12:16 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Chaoyong He > ; Niklas Soderlund > > Subject: [PATCH 07/20] net/nfp: remove word sanity >=20 > There are two small uses of the non-inclusive term "sanity". > One in comment is easily removed, other is in a macro that was defined bu= t > never used. >=20 > Signed-off-by: Stephen Hemminger > --- > drivers/net/nfp/nfp_flow.c | 2 +- > drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h | 13 ------------- > 2 files changed, 1 insertion(+), 14 deletions(-) >=20 > diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c inde= x > 41b722f4d898..05507bc3a113 100644 > --- a/drivers/net/nfp/nfp_flow.c > +++ b/drivers/net/nfp/nfp_flow.c > @@ -1944,7 +1944,7 @@ nfp_flow_compile_item_proc(struct > nfp_flower_representor *repr, > break; > } >=20 > - /* Perform basic sanity checks */ > + /* Perform basic checks */ > ret =3D nfp_flow_item_check(item, proc); > if (ret !=3D 0) { > PMD_DRV_LOG(ERR, "nfp flow item %d check failed", > item->type); diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h > b/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h > index 394a7628e08a..b7e77d8fa051 100644 > --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h > +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h > @@ -183,19 +183,6 @@ NFP_CPP_ID_ISLAND_of(uint32_t id) > (int)(((_a) << 4) | ((_b) + 4)) : -1) \ > })) >=20 > -/* > - * Do a general sanity check on the ME ID. > - * The check is on the highest possible island ID for the chip family an= d the > - * microengine number must be a master ID. > - * @param meid ME ID as created by NFP6000_MEID > - */ > -#define NFP6000_MEID_IS_VALID(meid) \ > - (__extension__ ({ \ > - typeof(meid) _a =3D (meid); \ > - ((((_a) >> 4) < 64) && (((_a) >> 4) >=3D 0) && \ > - (((_a) & 0xF) >=3D 4)) \ > - })) > - > /* > * Extract island ID from ME ID. > * @param meid ME ID as created by NFP6000_MEID > -- > 2.39.2