From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 797CBA0032; Wed, 13 Jul 2022 06:06:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0E79B427FF; Wed, 13 Jul 2022 06:06:47 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 7971B427F1 for ; Wed, 13 Jul 2022 06:06:45 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26CI2IED006845; Tue, 12 Jul 2022 21:04:38 -0700 Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3h9d0ma265-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Jul 2022 21:04:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dq5kJLtnLZcKfwRz5nHsQrHVWUfV2Lieg4sAXbz6WtaGJzAI0O50f59Li/gGxZOtgJKTrJOtNu5Da2ek56w5OBaKeQO1TdeCLO5nmOC/3mlzzklDnvFPns1HcLrkKIo5IGm6V+llyRR6MrnB7v0BG/mbjXps7zLupgL7Hey85HEC6Y2iPZ13y8AvyepmsKXXYlr9DSUiZsCOKKmWRpZQ5UNHG2RvyYCDQfWdx6R+DU/q4hD75JhzkXbIjoR6dSBRP9YHf++U/AJTsM4DPFBLJoGd9WPGtMrAlUOD1R+kovV3tHaRxTRa8FDNm6oJ+MYDecwGGMkXvAaC/4zIjLfqpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E13GhDp8iwUxwHbdITOYtC5Nqhrx6rLtc8p9uqvlrzI=; b=MUADp3O1Sn2cFCrejm1tV41fEuZEyTy8vKtILu/jKan+AVoBWukFtgr5ndEbSUSpn38/+id8YfuHP0oXktiyvKFz0QW+OwVuhVBtqpD/pVB7NwhpL0uxozAgKYJNtW5oXkHkZN/4lreysVBu2YGdQU/ZtzFEqlbVi0ng5xgJfV8sU9yOWU08i4lnJYru/gjtcEsWhLr3s858SBxZ1kpSEv1DPHgxMJtKx2gCSF3vh+cfEEZJb9pSK3ZqOAYHSoEVVE0MidoOPpMdjmubAy0aY+yEqDbBihCYeHi9tqJRbPch+2S0YSYqhPzx1gu36tE0dPmc6LZ8cKPvJsXMBWfc2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E13GhDp8iwUxwHbdITOYtC5Nqhrx6rLtc8p9uqvlrzI=; b=orL1E8t6hER9GtQJl49gvHhstsnrWvlJFj/IHZYFwj+SFlj9VHGFh5FxB04XM+SkmQIt7v/KApLG1M7N6vQ3MtA9y9gFP2yujEe1bA0hf65eRgaxpUZA4wSfqpkwvqNH4etwV2aWqKLz7Y8Hbw3tMXqDkbV49h42EZkPIddOONc= Received: from SJ0PR18MB4413.namprd18.prod.outlook.com (2603:10b6:a03:3ad::22) by CO6PR18MB3828.namprd18.prod.outlook.com (2603:10b6:5:346::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 04:04:36 +0000 Received: from SJ0PR18MB4413.namprd18.prod.outlook.com ([fe80::a92e:f97:7427:5332]) by SJ0PR18MB4413.namprd18.prod.outlook.com ([fe80::a92e:f97:7427:5332%9]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 04:04:36 +0000 From: Satha Koteswara Rao Kottidi To: Thomas Monjalon CC: Andrew Rybchenko , Ray Kinsella , "dev@dpdk.org" , "ferruh.yigit@amd.com" , "bruce.richardson@intel.com" , "konstantin.v.ananyev@yandex.ru" , "ajit.khaparde@broadcom.com" , Jerin Jacob Kollanukkaran Subject: RE: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api Thread-Topic: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api Thread-Index: AQHYjV/dbdhwisg3Vk61UAUG+w5rOK1y5h6AgAAKdFCAB+UtAIAA6mQg Date: Wed, 13 Jul 2022 04:04:35 +0000 Message-ID: References: <1656689558-27482-1-git-send-email-skoteshwar@marvell.com> <74f0f801-46a9-c407-e6df-ccd48ac1d817@oktetlabs.ru> <3410736.z0yIoBN5P9@thomas> In-Reply-To: <3410736.z0yIoBN5P9@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a5822d7-03dd-420b-ed22-08da6484ccc6 x-ms-traffictypediagnostic: CO6PR18MB3828:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 62fcgJ5NYnV1m2YqjPIXHourg0wcJD15SjICudoJblOdUNEHOc7fPxjOwkCPywPVlTrZp3+jwWTvgbOcV2fDMgQqqP3CJXu05uX6Vbc4Kv2D+FUAle0+AkWXJ5SH6qQvOObEos3qWgItLnMyLyIVN0DfrbVdFHVZPR/oB7nvm7RhotlCSt271KlDMxYNcI5qwwTPE1ilyfEQl+9b9FApk0iqtPpqHBGUI/qRr3IFgScRxLz0/5LObyqF1SZFeW4kYmJdg2JQFCEcWzGg+ZcYyy5OVvusvkLkAuIghxyrQX+KALmCB04KyOS8jcDQQg3EgoEk7ZNVHHf0AoGyKWRnDWOUTHEzqkhfJWQ//yvdmOlDtLssvCIzBthHP6434YmGsenQbfqBfG6fwoQzGMPlKGXJhgwwaq2L0RS1AWesbfgxnkAzsrMx9xSd+KONuFics3uCeAi+tqt4vwKb1XkP5DyolnTz/unHErNp9Uye+26EFloJiBZ/MphQv7GS1AULCvZ5g/18JmCBcrl7GsTwcFu2OqwyVhS42O52Bzb+oVCLDePaZ9813j190hBWy88zRmreWaz3fn0m+nXwR7i5639jyDayW6H4NJ3PjjxXreJwYdjPhkFcJnqIpnDiV+KyeAFVi4BtuFC6Iw6buXfHpo/llF/wZyYfyXwMoofSxgSCguVnH+0zzAHSrlf3OCVKuK6YHu+BXJWqADGNvx/LiflcAm7Db8aQB4dKWywyn41NjqVKa4fZgQBc35Z+5vgPXWmE+wV4uo1qbzKn5ubu2vba86hrSkry5KAH51QpgTT3vTd+ALTtckKRCXHI1hcfvj4pTg3ZxBdPoy6BW7t5KdGiu0DIQGTEhX8SAoErsSA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR18MB4413.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(39860400002)(346002)(366004)(376002)(136003)(316002)(41300700001)(8936002)(33656002)(26005)(5660300002)(122000001)(6916009)(54906003)(107886003)(55016003)(38070700005)(9686003)(52536014)(38100700002)(83380400001)(66446008)(86362001)(66556008)(76116006)(64756008)(66946007)(53546011)(478600001)(4326008)(66476007)(8676002)(6506007)(186003)(7696005)(71200400001)(2906002)(23180200003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IFfCTasN/IfIecGQ83Bjm8O3wL8a+vic8ZHyIu2KAp3dRx+eSpFN3SiMPp6c?= =?us-ascii?Q?sG87dDb7941g6dqss+h5tdsJikI3If/f2cFeWN7vvZDzpsVo2y8CG0bxnzrS?= =?us-ascii?Q?m1iftjJdbaIaJUz5JHreGQzIHvAu5/lyTpru1ww/FoqbjZxcxqhF4Vx+ewvc?= =?us-ascii?Q?VE+D1Ip0Zwyw7X39lgdH1W9j7Yombmd+vmehbOXF5iAHXEGYKGGyRaWeTEKI?= =?us-ascii?Q?qIAlpnJYYNXgJcaeyOozwMixwGRTBvd5asUywtyNeWM/C3FQQkivLOAoKC7W?= =?us-ascii?Q?Bc+EhJ7sh3keLf1HFtRbsMgrumhcGmt/RXi/u1btW8EGIdiUPp/H/SzcFIF2?= =?us-ascii?Q?AdMYHln3R9yHMQ/dGr87gnqkZdZKTzQ0FR0JzzosaL79PKQz9rGCKHOpMcjJ?= =?us-ascii?Q?5fUjJVCQIb9Se7DUDVN6PXndFAEksZiI26jfk55bFNG0YNTOqLVosh9IeZSu?= =?us-ascii?Q?g0vgk3FmoY3dKq9ZjbjHUplHo0QHv7shimCqfSlDtY3lDlMcZ86tqbzoANas?= =?us-ascii?Q?3XQDrB6w1XWqzcDN91lt/MKU7AECBzh+hYxe1FMIK9OfLV1rzq0lP5oSjGa1?= =?us-ascii?Q?GQd2q7jRfpYjpWQezbBU6Sr4aT3w8qfLJBkWH0xzp3+2cgfROW4kTEl0UuMX?= =?us-ascii?Q?kldubMNrOBM1Z1W3KjSbp5bmzeO44InyJRngZCJlNEQpgtEel1xD4wZbOgzc?= =?us-ascii?Q?f+jEH6MeUbX/GT79Q3nN2VXRRFCNoLx+QD6gUfFPIu35XrETUPYMP2+3x+XI?= =?us-ascii?Q?RuX9hmG0OEB5A+1jmwqLtKTDpx8HnFuWmeUGG7SocEUnKzbSrYVK5EsiMXbE?= =?us-ascii?Q?PDxhea7cwbD2AXvQtOeeLiu8tP+xb66RGdscRNGYoJSncTI6DQiexLZaXRog?= =?us-ascii?Q?7ldNKyyEQPJklcNVwUPR3B5SKUKejWbTWYiSNSU6j85N711CZOks0t7F6x7D?= =?us-ascii?Q?JLNX1sP03M60hLT7HipcvL/MDWxvcvhRJaDz3vNX5l2fkuLBrVitfxoF/5JK?= =?us-ascii?Q?lpmYoqlfgBqvMvWYX3sUZkMhSh7OcZ/sw2KOCDyTojwGMjbe5tC3PaT2cImo?= =?us-ascii?Q?gVyaYxmHkS+5sZDsBSr3/A3TAivxmwczuEpAczkdriWeBJF+Wj4Pm+sQ4R70?= =?us-ascii?Q?dzrQ0VbeEjX+jtJaawtpofcbsSan+5kCHnPTKT+Koxd+Q8XqQV4tzHlf2KXq?= =?us-ascii?Q?P2RXJx522TID+ZhLB7kwndmOs1opSYuf9Rjq91+FAz0LCs/10OqbXdGnrX/4?= =?us-ascii?Q?uUaNbEeLDjc45WfFGqdQal6iXhkgRpl+nz23HgpXkXlHsyAqgD0hTkXhd2P7?= =?us-ascii?Q?i3eetTgtRJy+17KTz28dNgp98/OgL5Awl8ksI6ukB5PZOVBKqbUFWA2cz+Fi?= =?us-ascii?Q?suLeH47pPmfvGPAXRmIpwI/cQ/hlmG3HP9Gji4qpuzsQQExMmYciqpolDgeC?= =?us-ascii?Q?zdu1ynLhtTgIN64DpZ5VNUO0aAMY5nk4hNqw97xpDT2M0xzCRbhcQAVi6dNn?= =?us-ascii?Q?+PPK3kcrDosSfVNcHbxEuqiXAfYZbn+ZZQq0JxxRcP8nuVHXGZGUcWQG8lLM?= =?us-ascii?Q?eAlQ76lMRAls2QE2JwTepPWYK5oeILiOBvwgNe0e?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: marvell.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB4413.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a5822d7-03dd-420b-ed22-08da6484ccc6 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 04:04:36.0240 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LaU6T8JOlf2cYCUMVv5H+0axhydF8MZYZtwWUBnFEE240JImuDQJ4bRLMw/sOlmwH1KRgQRPMHdBbkASDPHVcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR18MB3828 X-Proofpoint-GUID: Y-Divs3mzCYueqKpgkQgXbPn8vj83uSK X-Proofpoint-ORIG-GUID: Y-Divs3mzCYueqKpgkQgXbPn8vj83uSK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-12_14,2022-07-12_01,2022-06-22_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Thanks Thomas. I will send v2 with uint32_t type. Thanks, Satha. -----Original Message----- From: Thomas Monjalon =20 Sent: Tuesday, July 12, 2022 7:34 PM To: Satha Koteswara Rao Kottidi Cc: Andrew Rybchenko ; Ray Kinsella ; dev@dpdk.org; ferruh.yigit@amd.com; bruce.richardson@intel.com; ko= nstantin.v.ananyev@yandex.ru; ajit.khaparde@broadcom.com; Jerin Jacob Kolla= nukkaran Subject: Re: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_r= ate_limit api 07/07/2022 15:38, Satha Koteswara Rao Kottidi: > From: Andrew Rybchenko > > On 7/1/22 18:32, skoteshwar@marvell.com wrote: > > > +* ethdev: The function ``rte_eth_set_queue_rate_limit`` takes=20 > > > +``rate`` > > > in Mbps. + This parameter declared as uint16_t, queue rate=20 > > > limited to 64Gbps. +``rate`` > > > + parameter will be modified to uint64_t in DPDK 22.11 so that it=20 > > > +can work for > > > + more than 64Gbps. > >=20 > > I fully agree that uint16_t is not enough, but I'd like to=20 > > understand the reason behind uint64_t vs uint32_t. It looks like=20 > > uint32_t is more than enough. > yes uint32_t is enough, proposed uint64_t so that the rate in TM=20 > shaper profile is also uint64_t in bps I don't see how both are related. Why not stick to uint32_t for this parameter? Also I'm not sure it is breakage. If it was, it could have been handled with function versioning. But anyway it is a small change, I am OK with uint32_t.