From: Devendra Singh Rawat <dsinghrawat@marvell.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Rasesh Mody <rmody@marvell.com>,
dpdk stable <stable@dpdk.org>
Subject: RE: [EXT] Re: [PATCH v1 1/1] net/qede: fix redundant condition in debug code
Date: Mon, 10 Jan 2022 07:35:09 +0000 [thread overview]
Message-ID: <SJ0PR18MB4461154A664D6B92A9AA7FECB6509@SJ0PR18MB4461.namprd18.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1M=FYM_WL=jY56xKy8kB1xo3dnZOpyvogZy8DkA_dwtkQ@mail.gmail.com>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, January 10, 2022 12:50 PM
> To: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: dpdk-dev <dev@dpdk.org>; Rasesh Mody <rmody@marvell.com>;
> Devendra Singh Rawat <dsinghrawat@marvell.com>; Igor Russkikh
> <irusskikh@marvell.com>; dpdk stable <stable@dpdk.org>
> Subject: [EXT] Re: [PATCH v1 1/1] net/qede: fix redundant condition in debug
> code
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, Nov 30, 2021 at 10:29 PM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
> >
> > Expression "a && 1" is equivalent to just "a", so fix the accidental
> > inclusion of a literal in code.
> >
> > Cc: stable@dpdk.org
> >
> > Fixes: ec55c118792b ("net/qede: add infrastructure for debug data
> collection")
> > Cc: rmody@marvell.com
>
> Hi @Rasesh Mody @Devendra Singh Rawat @Igor Russkikh
>
> Please review this patch to merge.
>
>
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >
> > Notes:
> > This isn't a bug, this is just a syntactic anomaly, likely a remnant of some
> > kind of debugging code.
> >
> > This issue was found with Control Flag [1], which i ran on DPDK codebase
> just
> > out of curiosity. This was the only issue worth addressing that the tool
> > produced output for.
> >
> > [1] https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__github.com_IntelLabs_control-
> 2Dflag&d=DwIBaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=iWi6e5iy4mFBFqTG1Ch
> Syc_IBZ4tMsC6Dc-2s-Bibs0&m=WqaBCeO-fo40cdvFLvtypkt6kdMjkQjWb5ye-
> OKaU6_NyhRAIa826WfjkJPsGWzE&s=HCbK75ncfGCoqDF4S3h8Ik_HVKwTzN8
> bL4DOGgILGeE&e=
> >
> > drivers/net/qede/qede_debug.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/qede/qede_debug.c
> b/drivers/net/qede/qede_debug.c
> > index 2297d245c4..ba807ea680 100644
> > --- a/drivers/net/qede/qede_debug.c
> > +++ b/drivers/net/qede/qede_debug.c
> > @@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct
> ecore_hwfn *p_hwfn,
> >
> > /* Dump MCP HW Dump */
> > if (qed_grc_is_included(p_hwfn,
> DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&
> > - !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1)
> > + !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))
> > offset += qed_grc_dump_mcp_hw_dump(p_hwfn,
> > p_ptt,
> > dump_buf + offset, dump);
> > --
> > 2.25.1
> >
Thanks.
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
next prev parent reply other threads:[~2022-01-10 7:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 16:59 Anatoly Burakov
2022-01-10 7:19 ` Jerin Jacob
2022-01-10 7:35 ` Devendra Singh Rawat [this message]
2022-01-10 8:15 ` [EXT] " Igor Russkikh
2022-01-10 8:43 ` [EXT] " Rasesh Mody
2022-01-11 12:04 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SJ0PR18MB4461154A664D6B92A9AA7FECB6509@SJ0PR18MB4461.namprd18.prod.outlook.com \
--to=dsinghrawat@marvell.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=rmody@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).