DPDK patches and discussions
 help / color / mirror / Atom feed
From: Devendra Singh Rawat <dsinghrawat@marvell.com>
To: Ferruh Yigit <ferruh.yigit@xilinx.com>,
	Rasesh Mody <rmody@marvell.com>,
	Igor Russkikh <irusskikh@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [EXT] [PATCH] net/qede: fix build with GCC 13
Date: Mon, 20 Jun 2022 09:33:37 +0000	[thread overview]
Message-ID: <SJ0PR18MB4461997492FDC2BE730C948EB6B09@SJ0PR18MB4461.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20220616170211.2550199-1-ferruh.yigit@xilinx.com>



> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@xilinx.com>
> Sent: Thursday, June 16, 2022 10:32 PM
> To: Rasesh Mody <rmody@marvell.com>; Devendra Singh Rawat
> <dsinghrawat@marvell.com>; Igor Russkikh <irusskikh@marvell.com>
> Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> stable@dpdk.org
> Subject: [EXT] [PATCH] net/qede: fix build with GCC 13
> 
> External Email
> 
> ----------------------------------------------------------------------
> Reproduced with "gcc (GCC) 13.0.0 20220616 (experimental)"
> 
> Build error:
> In file included from ../drivers/net/qede/qede_debug.c:9:
> ../drivers/net/qede/qede_debug.c: In function ‘qed_grc_dump_addr_range’:
> ../drivers/net/qede/base/ecore.h:95:17:
> 	warning: overflow in conversion from ‘int’ to ‘u8’
> 	{aka ‘unsigned char’} changes value from ‘(int)vf_id << 8 | 128’
> 	to ‘128’ [-Woverflow]
>    95 |                 ((_value & _name##_MASK) << _name##_SHIFT)
>       |                 ^
> ../drivers/net/qede/qede_debug.c:1907:31:
> 	note: in expansion of macro ‘FIELD_VALUE’
>  1907 |         fid = FIELD_VALUE(PXP_PRETEND_CONCRETE_FID_VFVALID, 1)
>       |               ^~~~~~~~~~~
> 
> To prevent overflow converting 'fib' to uint16_t, while updating it also
> updated 'vf_id' to 16 bit too.
> 
> Fixes: ec55c118792b ("net/qede: add infrastructure for debug data collection")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@xilinx.com>
> ---
> Cc: rmody@marvell.com
> ---
>  drivers/net/qede/qede_debug.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c
> index 9383a6d67714..18f2d988fb88 100644
> --- a/drivers/net/qede/qede_debug.c
> +++ b/drivers/net/qede/qede_debug.c
> @@ -1809,7 +1809,8 @@ static u32 qed_grc_dump_addr_range(struct
> ecore_hwfn *p_hwfn,
>  				   u8 split_id)
>  {
>  	struct dbg_tools_data *dev_data = &p_hwfn->dbg_info;
> -	u8 port_id = 0, pf_id = 0, vf_id = 0, fid = 0;
> +	u8 port_id = 0, pf_id = 0;
> +	u16 vf_id = 0, fid = 0;
>  	bool read_using_dmae = false;
>  	u32 thresh;
> 
> --
> 2.27.0

Acked.
Acked-by: Devendra Singh Rawat <dsinghrawat@marvell.com>

Thanks.

  parent reply	other threads:[~2022-06-20  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-16 17:02 Ferruh Yigit
2022-06-17 12:03 ` Jerin Jacob
2022-06-20  9:33 ` Devendra Singh Rawat [this message]
2022-06-20 17:46   ` [EXT] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR18MB4461997492FDC2BE730C948EB6B09@SJ0PR18MB4461.namprd18.prod.outlook.com \
    --to=dsinghrawat@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@xilinx.com \
    --cc=irusskikh@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).