From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93EAC43BB1; Fri, 1 Mar 2024 03:04:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21663402CD; Fri, 1 Mar 2024 03:04:06 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2106.outbound.protection.outlook.com [40.107.101.106]) by mails.dpdk.org (Postfix) with ESMTP id 361364025C for ; Fri, 1 Mar 2024 03:04:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=US6i0L1SV6cAlBKdo8Mc5ZsMZs3ta74xDXSximI0iyiUmu7LgYb4E+8tKU91TF8BAgCUtGktVcWGY8Q9wunQxLdJdRtErhPN2onYpXQxDN1VASkyx9AgGpfxlBKs17zK8jPjRaHR6B1yyeWH50U6GjMwMvH5xUlTuKIGv0KxZTOAa3MN/Xw0+ljY9LDTNw8ttykuTn8JGg3Zx/AJ+QAV08dO+FzBhWtiydz8l7AHeXqTS206EpdvGPjoDIlMQs2WmSkQC3wKzraXZ5EVyQ2QcJ6B4KcL825BzoFAq2r9cG3c2WC30Ra9nzZKS91ycgJvVnDDwNs8acsFF56JU54D9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EYynoRzDOcI+BSsqvyTwbPEgheWeOiGrG7SPyC8X/dY=; b=UNVCJ3rwRCpua+Py9UVdKJV7A2G2DIFgF60sOHwSYBqcQuaGuLIb2DOnxDK/RH6947lHlHLSaNLJcNqFfsi0fPp6eiX5nZETGrHXPbuabI9bMrUF9bA5+2FgvfEBk2RZbaCDrxQsgnYjboVZ6lymqQUxSg5Cnl6wsL8bbsBWy9QYOSuESwIPoLaVItt/zLcqBZw8BhDxgtTrOGHRwstjvqWZ7V9Rzd1tQyeNfG7jrTzsxaW50AU/4Dwa9BQ37OLVvyU2nC/8zi6/hljYmajMtn8G0rtFVlfZ+KbAsLrh86ptxeepQsMLdsiLA2lPAqfNHYG0Fhq1VEeomTtYgXmYfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EYynoRzDOcI+BSsqvyTwbPEgheWeOiGrG7SPyC8X/dY=; b=hu35zJE5D4AErB1ee+0UNe0NJK8P35kVFsRv8r8ud4RrLAAPb6d1k6yiXvU22yic4FmwvknSqGAUItZalWf1Qbh8kz0l/k97jYaN80C2a7Jco1/bI7hkJLfWv2m6jJ1iGt6YzU6gHJLi0SFaQ7Rc7+jRu7fGNyx2qw1eDiC1y6Y= Received: from SJ1PR21MB3457.namprd21.prod.outlook.com (2603:10b6:a03:453::5) by CY5PR21MB3588.namprd21.prod.outlook.com (2603:10b6:930:f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.17; Fri, 1 Mar 2024 02:03:59 +0000 Received: from SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7]) by SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7%4]) with mapi id 15.20.7362.015; Fri, 1 Mar 2024 02:03:59 +0000 From: Long Li To: stephen , Alan Elder CC: Ferruh Yigit , Andrew Rybchenko , "dev@dpdk.org" Subject: RE: [PATCH] net/netvsc: fix number Tx queues > Rx queues Thread-Topic: [PATCH] net/netvsc: fix number Tx queues > Rx queues Thread-Index: AdprRTOynwRWp6iEQ1Sp/Ut/PyIh7gAFIjQAAAi0VlA= Date: Fri, 1 Mar 2024 02:03:58 +0000 Message-ID: References: <20240229135332.17f2fa50@hermes.local> In-Reply-To: <20240229135332.17f2fa50@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=81066abc-d2dc-46ba-b94d-7d7796651ac3; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-03-01T02:02:46Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR21MB3457:EE_|CY5PR21MB3588:EE_ x-ms-office365-filtering-correlation-id: 6dbceec3-0813-49ed-bfe9-08dc3993dbd1 x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kkFRImyDEIXvgl6LS9s0mR8gaEZq6jS5H88zAQIoOQHim+3CbZjOY0dW42a2MHu85wB42ZRgMY8aiTcGFF7wAiWhJBn8eSHV0kDLIsTihz2dzkqjWWj4v3eXUVcWAmunJ7gbYwSHGHRGzU+2XZ5pqO/9J1yRCGPjAKscXVv6w8LhgZzYIRQKec4wD3ztZrLJLYSlV3sQx2Vk5y30aSrR3GlysPS7HrFDDB+S3uH4GAUWIkIAh5rd6htw712LGUHu1Hpgse+WBXw9y9tnRkSn40SO/aSEvwcDWmo17+d4BQWGI7i+/WPTyKh8C/3v77mrOlBVPguuyCnT+67pZ0sTkqwtHqcpHrnDnfbgztNhbZoSIKg9Q/my7h1nenQpkJzq3uPFpENNSp/CXiVGA7VOFPlVc9LvORWpvfTz9tSrLIADU/MOdAbf7Aas4K3JzsgkL/pW0hSOxO+65lpt2pL1x4F/J9e0HzWtJFgSa0Qmxh/L0c/lXMD8YEsmPWsSHr2uC80gFTUMb0ESA8uCkNbxkLm6QLDLfKM9367Z1MD9bn/eok4Abg6PyqluTsW6IwTIUSz8iKrRjgRLcS1SNvmzIHrjCtFBkqmDKKJL8V3KkEEktfQ1OPN7NoAjmKqTeV1dx1jhlZrP0hHNWUi0xXkcNub1Plhy4qa0h05qr7b+/S3AfrmjoXFeTMFNmcAZf2FxQb5KE1lDjkCbssP29RQsB0lxqIcwm3EUoeuaET6e6iQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ1PR21MB3457.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?o5F28C6K4gNo4uGkj5b7o3U5GyWQh/eZdnWEf8QbqmTgb59zCA7Ty/YKfWp/?= =?us-ascii?Q?0ljHL2TqZrgDRRNVXZzZSe10ZLBHaFpYxijJbOqtAIzB6ikE7lprRxgC0Aiv?= =?us-ascii?Q?OCbXxUVzMsVGIP9nBXG2cLxI5gD0f7smhwd2eD0mTvi8nWkLCqD068EgRmlV?= =?us-ascii?Q?8M3i3vEFceWcaaLkRUJVbCHEWBN9s0yt0B1bjP4w2eqeuuo9foWu9DBtPu3D?= =?us-ascii?Q?XwIc/JAeN5FNg+AoWTQ4AFZoBFCYzwTs7uYkDc7esgornNtNX023cOmHzjyC?= =?us-ascii?Q?pc/vDciprnerjKTNeXdmxtrBHOhFObSlp9lIogcxr8i737hSfHetGJA2R8kW?= =?us-ascii?Q?3DHSfTR0lqDgo0g+K3mA7zH3VMl5j3vFU7BTHJs+mY9ptqMWyDq+eNjBRDfV?= =?us-ascii?Q?T3ydOmE/B9M9KmqMpMw2rTJ/GMBmxyn0E2svhoMR77aE66KzTDZFTorGNFFB?= =?us-ascii?Q?kMkSEIbIAngZXcRWd8jz1cB9mCzZuw2nLd/rnoZqxher0rFU0LV9jiXOz7PL?= =?us-ascii?Q?MBVo/cbYprK4zAai2ueBoyefkR6hjQqbVJFLwm1kwy5pRY9u+sLsfTVtkehQ?= =?us-ascii?Q?TBQJW3+IAtJ6VrAfyrQiNK/8QwSUoA+tjj7pz0pmEOBayA7HMjj0dAdnMw4F?= =?us-ascii?Q?62vuid0+pt/6XgJ9GpV5ebHxd6qK+xWsDYeD6lOniGKzkhaMx+vMecvs3lVq?= =?us-ascii?Q?Of0QR7+k1w7ZgpvFQFNpEL5XZhO9YxK1WR6haTtxgS6igQh/L9PoLnoJc68n?= =?us-ascii?Q?2wclNtOKxvfAvM2h8neREHgOUc5MEGL3r4kcUKI5FPgf/MQjqkP9Gld4gL0S?= =?us-ascii?Q?aaR87zuhKK3yfe0l3bPRV/cHf8JVwXI+th63MF7sRAG+Qk+2gGku+AnYbxr3?= =?us-ascii?Q?+38IW3vcH3NiPDVK5OtAX0o+GX5OVy+G2a45tnfZh136JBO6LGKkLVSfRsRR?= =?us-ascii?Q?sE7tUN2DTZvsAnq4sDEOAIhCdBAGd0qdkg1sItZyxJPav4HmlbNCs+BhJGsz?= =?us-ascii?Q?pXsGrI7n9KCWKlMrIzOm8MAm6x/4gJs4FlP6sbWqKge6egA1+plH7ZtPzec8?= =?us-ascii?Q?Xc/LxLhXA5rKurRZ1UVa5OmSpspy0e0TPkJoEXWrsT4v3l8M2n666nB4eCDq?= =?us-ascii?Q?FRG/DtnCz8w7Nv47UopVis77Q28BmV7zatEYGbhaVGt8KFJykDPEwPvXGCtk?= =?us-ascii?Q?ekBmoO6cy1KPZ07VXnYG5AYNb5U0KLKceNyW5EBgWUpB79vDkq9kYjdSMlJ7?= =?us-ascii?Q?gZBT2QS3cKjyFbScB9fYyzKqU2XF+9ZlJmOSQw7cW/2oIZzW7dyIdVXY8xoq?= =?us-ascii?Q?u+bGJBJvI7r3Crm7X1LHLUnmgaGM/c+nLAnVxywO8A1DkcL7zrH8UYgjtGYD?= =?us-ascii?Q?1P/9n3ChO2G+MNhLJ/sxmlGlEHzY5Y3vBNxVElljeDlOMla8C/Fwdp8PmbBm?= =?us-ascii?Q?vggheiniNePEhDq1UF+Ni4IsfZy6yOBMqAp0k7LPyu36v2wFLJ9nhRogxeNf?= =?us-ascii?Q?fjQH4MxTTGLKSwZR31ErFglS1YayqEpdmwc3Z26IgSuRTmaIU2CGwFoVHI/w?= =?us-ascii?Q?F8HA/wyGiGqVLArdiFd9Bh6fGVizZcQnNMlB6OFF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR21MB3457.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dbceec3-0813-49ed-bfe9-08dc3993dbd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2024 02:03:59.0171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H66jS8mvNHK/n3NObhyhz/WYSrLcs9TjdmXuqE0sXoGAwLPUNRo3+riVJJXmKjMPj+Cq0S7R1E81k8DHmb7Qhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR21MB3588 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Subject: Re: [PATCH] net/netvsc: fix number Tx queues > Rx queues >=20 > On Thu, 29 Feb 2024 19:29:11 +0000 > Alan Elder wrote: >=20 > > The previous code allowed the number of Tx queues to be set higher > > than the number of Rx queues. If a packet was sent on a Tx queue with > > index > > >=3D number Rx queues there was a segfault. > > > > This commit fixes the issue by creating an Rx queue for every Tx queue > > meaning that an event buffer is allocated to handle receiving Tx > > completion messages. > > > > mbuf pool and Rx ring are not allocated for these additional Rx queues > > and RSS configuration ensures that no packets are received on them. > > > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > > Cc: sthemmin@microsoft.com > > Cc: stable@dpdk.org > > > > Signed-off-by: Alan Elder >=20 > Don't have Azure account to test, but looks good to me. >=20 > Acked-by: Stephen Hemminger Please hold on while we are discussing this patch internally with its inter= action with MANA. Long