From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C59D43C95; Tue, 12 Mar 2024 20:55:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C32A42D72; Tue, 12 Mar 2024 20:55:17 +0100 (CET) Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11020002.outbound.protection.outlook.com [40.93.193.2]) by mails.dpdk.org (Postfix) with ESMTP id CD30F402CD for ; Tue, 12 Mar 2024 20:55:15 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=odaoB+HtmjDT6ru5syxdP6iOtJHw0pdOXw5r+D/1qixMfPAqtyN/T6PnQOpyNTzYw4ywwrtmSm+ktO8NUt2xwPNHLtn8mircKvsV8lcYasp+1BUbcH0/UgVsr2o50CgwFoITZAXi2ZotSzkm4TIoQs4i0ysZ3GFTzWndo1gwfoO2+0TwZfOZO5DjYmCWx0rKb37lGK9p1EJzQzlhRYZ15qDrknfzIzcgRBj1bQtj4L/N0+F7fo7d+Kgb5hLwN6HZ13Kmm3yGWL/MQNnM7piLLODydmXARmC2uQ1htz5/jWNqKTv07Dr5RJA/I2O+mGhGr9myei3Hvd9/daxO9RI/Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SHYMeswmXxQGS18rQNHqLsbxgm9ea6ODwkwjNr+uvEg=; b=B2xxmuWGFJvDtgzfOBWu0GSeUSo+nFZXM1Ws7CtZIsn9Ja8ns0NsYe3Hc/28OYHEZeOZW4hFRcXXcxq3Nxp0XA3QBVt6K2GmnDGcdGHFxtmMqg9ZtSnwZYCn7VuxuBOm8n7Der2ilNYSpaApUkzZfhdxDUmNSKjD5pcFof4R23Yd7H0E4xc8QD2eP9ja5SxBhuTfdClZa8HYawJYlJI5mG/NKvtwFzhTXyNwUI7bX+gtbq/g6o9PgA498mz4irACiDEk34d+m75KH83P2j5Dwdwdtj4UaNk1J3hhYVH9odgcNxJmkbVviZXKVpghXfLF/YawAVnpOTnSYPlO4mGTsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHYMeswmXxQGS18rQNHqLsbxgm9ea6ODwkwjNr+uvEg=; b=AFc1HCkOxPz1wG7TeHvBlTAjAJbYflcFsYY8N6uI/WzPy9SaTDJA6uEtb18FaKsgrt2kk1k/IEPUxlEA6DAdPKr2/B/e/lGj1+0kDOKsrUC2XNbMggd9mJOP0xIa4m3jeQmrL5zVg1lpD4zuqikVSiN30apitqzXMAzkmtru5lY= Received: from SJ1PR21MB3457.namprd21.prod.outlook.com (2603:10b6:a03:453::5) by DS7PR21MB3342.namprd21.prod.outlook.com (2603:10b6:8:81::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.5; Tue, 12 Mar 2024 19:55:12 +0000 Received: from SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7]) by SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::70f:687e:92e6:45b7%4]) with mapi id 15.20.7409.004; Tue, 12 Mar 2024 19:55:12 +0000 From: Long Li To: Wei Hu , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , "thomas@monjalon.net" CC: "dev@dpdk.org" , Wei Hu Subject: RE: [PATCH v2 1/1] net/mana: add vlan tagging support Thread-Topic: [PATCH v2 1/1] net/mana: add vlan tagging support Thread-Index: AQHadGDHDcdfRcex1UekcekaxFpzBbE0g8Ig Date: Tue, 12 Mar 2024 19:55:12 +0000 Message-ID: References: <20240312093611.359025-1-weh@linux.microsoft.com> In-Reply-To: <20240312093611.359025-1-weh@linux.microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR21MB3457:EE_|DS7PR21MB3342:EE_ x-ms-office365-filtering-correlation-id: 3dd344ca-972c-4076-b00f-08dc42ce5465 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DJM32iSym2DjcGqRxtjbbEowAMws1HPi/ZSCpf30fu1X24mcNTs2morHcE7LKbXivQfbey9WVaPYn+vCJWpwHayC2DTlk4KnFZ1zRNAS3E3HA+Fw0/pKvolm7PH8jOnqUThAB4GqnlHn+ZyikYhB3xY3vd8XbadVBg/retdHjjXaOR/8vDthUWfxJZp4A/iqDsRlZuykGfV1TU4VAL+9sxHweMGGqoodWWgLoJPgCAUc7xoiBS0AVw9ySHnZSURRmbsTRJVRMaiLMOuHWbaDkFZ7tcp6PY1XnVC1hRNo57SXiwcxKc0GpytCYDno2dGAyFCW4ztj5QNgeZOQ2Lksd2rY6TpxeLC6nYpO2nDgqO7NTZtk60xzg0WuOhaD4YHOb5DcxSu04kGvwGWwCTbZDMP765yzDxUN/6OFvNSjuAWHJdEriq8ESfuSyndpF92QuQ7nOdn+S2wYc1/jygpP2cdOBnTfYhVraTYPwvVIQQD8ja1MwqjwUkQ5TjAiT/fzISZMCFpawgtn8kUWrjxhtWafYUZxxue7po6lsHbhyYZkIHapLwUgU9aIU9TVixBJVdcFPAY8AsU1cYpcfOy1d27bFOzgd7iN1+gXm255XLWO9p3OfiFd7PzlYJ4y8seD/pxlBNShIdeG34tLyfJ3bsFBDL0iF0bj3Wd+AFOz/+uCseziHpCU2iNXZtmifmfa4oYuQo9PjBKd4QIuU+oXqg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ1PR21MB3457.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?veV62aWA3ZLnv9OMnZeBZcmqz6NevFyiaiGbWQiA3ifViFGgc06TtOw8MxUZ?= =?us-ascii?Q?mu9W228KeVORQ9AWPAzu3tmnxMWk+rfnzUS6muAT8BgyFIpF6bdHgBpqoE8m?= =?us-ascii?Q?La9tj49S1vjP6GoNEjVk6jmb3l7HGHywlRvTB0GT/tTt/kYwgVQpSvTExoGx?= =?us-ascii?Q?y/ASqufhWlvJi6SPsicPE4fh39/BCnHoRXW+UDBZJT501svRX1yd5gH8sxhn?= =?us-ascii?Q?6Tfl6l+Xm3IXByh/UImgN2rR4a5QZMN32heQ8a7cLzjaYshFVQUsC/qgqOlF?= =?us-ascii?Q?OrUhXUwJf6IMbcDLboDUzuHbvmKfK2n92conBEl2OjkmSi43Vg0B8uxGqMc6?= =?us-ascii?Q?WtGoytHDkV4V7NezfBLgfyMnXB16cLTBmwcoHHwS8M7FJMsqJdw4uxyevw+9?= =?us-ascii?Q?ZoWZG4hgooHCFvZp53b2If8OtonPQDl3aO/7ke37kM/hV73JISoTAOzWU6og?= =?us-ascii?Q?+fADMgKu50yZedWqMz8Hzk8e6DaS7rLe/R2T2iPpi7jkznuqNOu+d8UNjANO?= =?us-ascii?Q?TQmsPxDLfUThzfBuAtWSKZ/qyu+pDB3boWW8STvRc1R9OYOpg1JL8aZ07k9d?= =?us-ascii?Q?UWSw3qi+1szppUxA/nZpEU4wFQMl/dLSlJ5tj8AYHvcwlA63j5YY/nJYsHWw?= =?us-ascii?Q?hySQtdRoLFesp7QtYs9N8UOqggkaXZ/9GsRycTgC1eHW5k8DaCWN0wNeS/ZS?= =?us-ascii?Q?AXqu4xArKYywUqkr8TOxFAoIBKTp3ZcPrwYcdF+4fqgxKmBFxi4/NYJH8i5l?= =?us-ascii?Q?orIqHFiIV2cDyRu5F6FfktIGsIj/UQVlkUcxaAtqUUE9awk7f58vmYg3YRgS?= =?us-ascii?Q?dFR2doVPfgDnUv8y/DZ+Q+mQla8KegoPVppiPIQ5hcK5EVHhlpPYZDxVJSJK?= =?us-ascii?Q?R4mCn8zTQhUf0RswkSpZrdnJ1ijkhe+OOXCi1PVI3G948FgMCSyM7h9bEkNL?= =?us-ascii?Q?b6R+fqSMi10HF0c2jw9m/noYU6FEI/e8duEKOJIztGuTYFf2XYDOFuAINZrF?= =?us-ascii?Q?umXwO/R7g7H8XFCdg4FAR3eEHOK6G9M1eb4nZDZEwNZyTAQM3CcBtKEzwJV9?= =?us-ascii?Q?ZBbNsNTzjPj/iEPM+iMxVXYpgR90N16UPcDRIck21tYHHJz/mzXW7E/2TLP6?= =?us-ascii?Q?4Auz3gc/j1uuaJQA94mv6zPG3Bp1Jo3/RMawxNSAQBAvra3lzKVePqNVeSjp?= =?us-ascii?Q?DSMgyRHJ4XAt+5qtHEYWMQ2mBRdoBFqQVpncpJsWwF5ebe4GqzDO+6oA5lzM?= =?us-ascii?Q?ez3hlbXrSE493bZ23vCLIY6IFDHZsTJDYPF8s4TK3GifWeEvFjdaNg5kdGFO?= =?us-ascii?Q?l+RxF4Udl/KcJNQ/004FTShpBmKDBD+Up7DSbBodydTujUOQexUxppUPoSrH?= =?us-ascii?Q?hmcA/+w5ghFzQ3hL/5lKufl/ZWMMkbP5inDLLLje/Y4Syll7zK2DcyOV3UPq?= =?us-ascii?Q?Q5E2YYi1gJ6zRo4grWj/mrfK0pYHUWIF1G6CLupk3TH04DKZO2i+TB7ics9v?= =?us-ascii?Q?itlKJiwAY8UqqMEuHjA0QAIsE5GDDDGOrbICNzXn5p/P6BKt7AH6O3VQBnsm?= =?us-ascii?Q?KSyNNwM7rnb/TD7GQPmIy2I5NXnAMi2NjhGwFqV+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR21MB3457.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dd344ca-972c-4076-b00f-08dc42ce5465 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2024 19:55:12.6322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p+rHe/13YLNmK1CMvCSXU7DJlpOr7wEE64RpbRs00XNexsK/71e0e2wzBgf+ui/yrzmM8VWidwMOyfmEGhz/hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR21MB3342 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > --- a/drivers/net/mana/rx.c > +++ b/drivers/net/mana/rx.c > @@ -532,6 +532,21 @@ mana_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts= , > uint16_t pkts_n) > mbuf->hash.rss =3D oob- > >packet_info[pkt_idx].packet_hash; > } >=20 > + if (oob->rx_vlan_tag_present) { > + mbuf->ol_flags |=3D > + RTE_MBUF_F_RX_VLAN | > RTE_MBUF_F_RX_VLAN_STRIPPED; > + mbuf->vlan_tci =3D oob->rx_vlan_id; > + > + if (!priv->vlan_strip && rte_vlan_insert(&mbuf)) { > + DRV_LOG(ERR, "vlan insert failed"); > + rxq->stats.errors++; > + rte_pktmbuf_free(mbuf); > + > + i++; > + goto drop; This is not correct. On CQE_RX_COALESCED_4, there may be up to 4 packets in= a CQE. Need to update pkt_idx on vlan error. Thanks, Long