From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F06CC43B57; Tue, 20 Feb 2024 19:59:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0591402EF; Tue, 20 Feb 2024 19:59:45 +0100 (CET) Received: from CY4PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11020003.outbound.protection.outlook.com [40.93.198.3]) by mails.dpdk.org (Postfix) with ESMTP id EB27740289 for ; Tue, 20 Feb 2024 19:59:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZyotRx6NWAOeAYsckhr7myTj3LG8U+XBGagr+PdDm0HctIxtEmyyWepaWwTx4+19JRGugg5IBShWstge3DO49qaedeIv3iVXVa56Jhyga3gFbRh8AJB2zQD5cmQB+6tM+8tgaHwreDFYIGrNPSrMe9LyMBuh9GYS7A0iCSfMh2X8eartL5jvBbEUV3ZD2H9LX4ACiH+ILv1i0bxCxMHVe83Vt08eWNxbYJrE7IP2oCFJ8j8IV2T/dU+l8YGcTIAomC80eZF7VDF+KgHBIVhbKhGgWhif9K8X5CzkoSYv5oBmd88lHPCeI7LpQWLAPdWdYZwlNbSWhip3W5HNV2YVbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pVFnJrIUhVgmU4Ljwl5zkAH73X+W400UzZkKzA1Ks2s=; b=awVhj/bCGjekNJmaXNKMCkKFltga9guoTBKA8xMdD8UUKHLqv1Z6G9wdAs7s7IvmGpHrzZexpkiT/6/9WRO07d5yPkVoOPi5yyA6YqmvTAmYAgHwcX1/VJlg3mYqTUaNFsfwOv6SVm/7zTecUAVLaDW88FH4rp8SETz1cPPqVg7cRv1R/xwjB0BsDl3VKfmFGHjoIqFxL/Q7yAfnMun7c8q4eGd9gkkjpGEDjdx7I1IwC/IGbKI6Yal5L1BSI6KBCVKd2x1Qc46wQcXaaa0uxLXI0FgJx5n+zTQO8s+sO7/gcOi1BXc2xcK10eSVVmwZsQWZBRo+bPPqnHOMPqj31g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pVFnJrIUhVgmU4Ljwl5zkAH73X+W400UzZkKzA1Ks2s=; b=Mw8S+agcJqOlTr3l7icsduSZCWLox0M/TPDCN2/YfLZnLsE5AIa/zIbpNLFZcXyfzT3IKZLLbTqS3AoJWstnr1pw4tP9fKWwlGkw1PTQ9TkbqXTHWehJQ22T6CydFcP+OfQZFWpBzXWNSsae/meCN6lQPPzEHMMUTL7ccxnyZMo= Received: from SJ1PR21MB3457.namprd21.prod.outlook.com (2603:10b6:a03:453::5) by SN7PR21MB3886.namprd21.prod.outlook.com (2603:10b6:806:2e5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.6; Tue, 20 Feb 2024 18:59:41 +0000 Received: from SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::22a6:cfc8:e631:2dae]) by SJ1PR21MB3457.namprd21.prod.outlook.com ([fe80::22a6:cfc8:e631:2dae%7]) with mapi id 15.20.7339.001; Tue, 20 Feb 2024 18:59:41 +0000 From: Long Li To: Wei Hu , "ferruh.yigit@amd.com" , "andrew.rybchenko@oktetlabs.ru" , Thomas Monjalon , Alan Elder CC: "dev@dpdk.org" Subject: RE: [PATCH 1/1] net/mana: add vlan tagging support Thread-Topic: [PATCH 1/1] net/mana: add vlan tagging support Thread-Index: AQHaWzVsRdX2QKTKSUeXYcBkUz9Hk7ECWF0QgBBx8oCAANwvMA== Date: Tue, 20 Feb 2024 18:59:41 +0000 Message-ID: References: <20240209085211.2643148-1-weh@microsoft.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-Mentions: alan.elder@microsoft.com X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=2acdfd2d-4532-4882-b975-76beea55277b; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-09T18:40:02Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ1PR21MB3457:EE_|SN7PR21MB3886:EE_ x-ms-office365-filtering-correlation-id: 9958d3df-c3ef-4bf0-d32e-08dc32461811 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eLzwyEfw49wCSVnHLW/fUdJNfEddfh/FLsxtfNuXbH07O0GxczTtoIk6yvU99Bn+JtsVG8x6hcY5MdsycmGXPpF7utthv9lzLILe+Csa2IYPipt/vRifNcBylE73Kpz7xbWvNIFeOA5H415vaU7S/GoBzPttE+j2z8Nl/hv4xgVY8YfeHcqERgSIFJOegs336JjbTpI4TUC+Hy3/pnhGUY5AqtX7jOw6FTFswr65MJG7Wb75cWOWA/qSwADwufE4Cao/slbcUf+zZL5pMc6Gv5cR36VWyL4T+Jr5iuIkVsiuv/smRglughdh72TY5Rjc9clAII/01vBP1TJj/xz7y1uy6hlTS8LPr+pT6wIZbtqO6JJUo0KRJAXRiAMRHZ148WwuoSTLfzumMlmfn3+/VaI17zSlNao3YriStnqPRRSxg6cyCEbWLTD7Q3KQjFlTmTzTcOp4tj7eHo25rtKvZRYr5OHfSP84Oi/jSakJWC7+dds0eEWAjA19muOT02WklZ2pIYQjfABLvXSiUL7y5IZvp+wqRuipHSCXS3lfZj0MGuuTaGXLWPb+UYg+54/X9WU3x8PD1q9SRUGJAAfn33KcFy00+tIT/c4Tj1GiEes= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ1PR21MB3457.namprd21.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yiXPgX2cXkJ0No4CEfg52xdp0JdkeKs4r9d1dh/zA2KEMYpzewGtp42glFl5?= =?us-ascii?Q?KSXEcPaC0tOF6fHmYMwZLXjLzdsJqFoa9EKPW0NkY13NejURW/FOXSmZOt4d?= =?us-ascii?Q?LCeai8SjPOzYYoOQC9syaTgPqsjN4gv5dLGfyajJQq0XLQwFQiSJ3h+E1FNw?= =?us-ascii?Q?NRuwfKOuPhjl9vF2frYyBB1q9mRKob82kl3k1iHLBePh7DR7yJ65j337uKOY?= =?us-ascii?Q?eOHHjM15Qd1fR0GsSZ+HvxtydY5pWRhgkL4iGqSeTVpyFcRaFhjfaqLunoKp?= =?us-ascii?Q?sBv3YWOVtYmG66YiSIbvg+qOq+7lF8vFkS/UTTPap1hp29ZHePCQ5Sa7HCRw?= =?us-ascii?Q?vGTM7tY6/FsrPgNBSLSRoXb27PcTCpc14xEpIBvBAcTM30kmXyXSgAZ7SDNl?= =?us-ascii?Q?NKG9ReYQBGZIeeMEmeeWl3vmn03NGic77+T9tg9JdlZ6WfgagTL0hWBHbHx7?= =?us-ascii?Q?lr0VDcxssdeYf2PROPzqGKKP3N7/UU0GHCzjFPoIrZIehRGQAyJ7zSVotzfu?= =?us-ascii?Q?DWP+BlT+Q/veAJTamF4Qdt2qkQIhNsHOemfh41heM9xGxeW/UuegSfATuPij?= =?us-ascii?Q?9JZ/k5PbZg1Ky1h42GSYisfinCkJEWCbdVCygfHgfjyXnuuL7hi2rMbPB3LF?= =?us-ascii?Q?aFK2NpwOwnnM8DWXN0zmQNdrsfUWEcTz+d6h4Zo19EOiLbY1+KPspAKiEmuc?= =?us-ascii?Q?4+ylV6YYh2IFh7e4+nweqdwdQA690Ud2G/o/V2vtiBM3DS/2WhGmuXE/WOwh?= =?us-ascii?Q?nCczx4KBWUCKzYF4F/tINWfdzRgG4wulzlDkXcFtMInNrDU9W+LFNOqUQfqk?= =?us-ascii?Q?NpanFO0+1LwRoLtFd+dOk9E4KsGX4YroFpX+0cq5KlWV2BvA9mpavkD7QtG8?= =?us-ascii?Q?TOXXc2fFHu4ZuJc60VIxYXY5LzGR+C6hAemVdpALyTeOsxT8oLtBBYQ2ZTkO?= =?us-ascii?Q?Z/UaJYKCy+nU+8JRjfzcJsgHkhVOfRjM83H/0OacxGVMDIArNtwZX7bSZX9G?= =?us-ascii?Q?2bp+zJJaFTj1f0mWtiuVp87I1+PwlSy7vKi32rIAIG1REgowXXMWXqVvqkQG?= =?us-ascii?Q?8jH+XROowgfLPhN4PYoKtreyUwzSmL8DhskUVnOAdwscHLSErSbjPZCQYvrq?= =?us-ascii?Q?x16iLBUsj5o/PrUFhCCHJySHTD5QsqffMeZKHm7Psk+nigzFwUEzmNLshkwW?= =?us-ascii?Q?1ttJQe5S+ThgXzYh1PfUCHrnsgfI4W4gmKshL7ZvWtlKXuEpJTD2qT0wIfch?= =?us-ascii?Q?+hGYv1lMpBzifJK2h2O/wcyX1rsOGcPCi+ZhZgPaACMC7Oy3X1xded5mQzLq?= =?us-ascii?Q?pazmgPmSnlVtOrErl4OS2y/ZSvbvkw+rxPnYc/kzdIX7fIVbDfMYwiFAa25o?= =?us-ascii?Q?hcBbXwJyHQBEYjMll3jke146yANrltSJUb1HJy+TLOxQj6ADYl8a4IOxsc/j?= =?us-ascii?Q?kxlRXT7pMfs9yvkvK0+kSdYRlHeoQnztGTD1yIYCAgfAuEMuO0UEROMamr17?= =?us-ascii?Q?FiFVmPov1n49EY41n4j2tV79UgTOAszfi0bCLWaSMig/RdQFQDngdX9qIBU0?= =?us-ascii?Q?jt92FQ2iRXM9YkyMZAlMyoIbU+eqNTT0143gcZlm?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ1PR21MB3457.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9958d3df-c3ef-4bf0-d32e-08dc32461811 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 18:59:41.2554 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6ic5VPmGukVReXoyxghcPgwrpgk7GCMD73djOqM4r480BerNP9Sns7FjZPXC3P6/aJr3MTNBDEonfF6WQE5WRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR21MB3886 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > Not sure if we want to do the same. Two reasons. >=20 > 1. Searching the netvsc source, I don't see a place that it set hv->vlan_= strip to > false. It means !hv->vlan_string is always false, and rte_vlan_insert(&m)= never > run. It's set here: drivers/net/netvsc/hn_ethdev.c: hv->vlan_strip =3D !!(rxmode->offloads & RT= E_ETH_RX_OFFLOAD_VLAN_STRIP); >=20 > 2. Usually vlan_strip can be set to true or false if the hardware support= s this > feature. In the mana case, the hardware strips off the vlan tag anyway. T= here is > no way to tell the mana hardware to keep the tag. Adding the tag back by > software not only slows things down, but it also complicates the code and= test. > Not sure if there is any real application needs it. If MANA always strips the tag, you need to add the tag back if needed. >=20 > I am open to add it. But in my opinion, we don't need it. Let me know wh= at you > think. > > > > > pkts[pkt_received++] =3D mbuf; > > > rxq->stats.packets++; > > > rxq->stats.bytes +=3D mbuf->data_len; diff --git > > > a/drivers/net/mana/tx.c b/drivers/net/mana/tx.c index > > > 58c4a1d976..f075fcb0f5 100644 > > > --- a/drivers/net/mana/tx.c > > > +++ b/drivers/net/mana/tx.c > > > @@ -180,6 +180,15 @@ get_vsq_frame_num(uint32_t vsq) > > > return v.vsq_frame; > > > } > > > > > > +#define VLAN_PRIO_MASK 0xe000 /* Priority Code Point */ > > > +#define VLAN_PRIO_SHIFT 13 > > > +#define VLAN_CFI_MASK 0x1000 /* Canonical Format Indicator > > > / Drop Eligible Indicator */ > > > +#define VLAN_VID_MASK 0x0fff /* VLAN Identifier */ > > > + > > > +#define mana_mbuf_vlan_tag_get_id(m) ((m)->vlan_tci & > > > VLAN_VID_MASK) > > > +#define mana_mbuf_vlan_tag_get_cfi(m) (!!((m)->vlan_tci & > > > VLAN_CFI_MASK)) > > > +#define mana_mbuf_vlan_tag_get_prio(m) (((m)->vlan_tci & > > > VLAN_PRIO_MASK) >> VLAN_PRIO_SHIFT) > > > + > > > > Those definitions look like those in @Alan Elder's patch for netvsc. > > Can we consolidate some of those definitions into a common place? > > > > Maybe in "lib/net/rte_ether.h"? > > >=20 > Ok. Will add it to rte_ether.h. @Alan has sent a patch for some helper marcos for parsing vlan_tci, please = use those helper marcos in https://git.dpdk.org/next/dpdk-next-net/commit/?id=3Df9c66ea9b5bfd15f314f6d= 101f156a312121e7e1 Thanks, Long