Re: [dpdk-dev] [PATCH 0/9] qede: update qede PMD to 1.1.0.1

[Rasesh Mody <rasesh.mody@qlogic.com>]

> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Tuesday, June 07, 2016 5:47 AM
> To: Rasesh Mody <rasesh.mody@qlogic.com>
> Cc: dev@dpdk.org; Dept-Eng DPDK Dev <Dept-EngDPDKDev@qlogic.com>
> Subject: Re: [PATCH 0/9] qede: update qede PMD to 1.1.0.1
> 
> On Mon, May 23, 2016 at 12:56:50AM +0000, Rasesh Mody wrote:
> > Hi Bruce,
> >
> > > From: Rasesh Mody [mailto:rasesh.mody@qlogic.com]
> > > Sent: Friday, May 06, 2016 9:30 PM
> > >
> > > This patch set adds support for enabling 100G mode for QEDE PMD.
> > > It also adds support for APIs like
> > >  - mtu_set
> > >  - reta_update
> > >  - reta_query
> > >  - rss_hash_update
> > >  - rss_hash_conf_get
> > >  - xstats_get
> > > The changes include enablement of vf-vf traffic and updated the
> > > driver version to 8.7.9.0_1.1.0.1
> > >
> > > The patches have been generated and tested against dpdk-next-net
> > > rel_16_07 branch.
> > >
> > > Please apply!
> > >
> > > Harish Patil (2):
> > >   qede: add 100g mode support
> > >   qede: update version to 8.7.9.0_1.1.0.1
> > >
> > > Rasesh Mody (1):
> > >   qede: add support for xstats
> > >
> > > Sony Chacko (6):
> > >   qede: update hash config
> > >   qede: get hash configuration
> > >   qede: rss redirection table update
> > >   qede: rss redirection table query
> > >   qede: set mtu
> > >   qede: enable vf-vf traffic with unmatched dest addr
> > >
> > >  config/common_base               |    2 +-
> > >  doc/guides/nics/overview.rst     |    6 +-
> > >  doc/guides/nics/qede.rst         |   11 +-
> > >  drivers/net/qede/base/ecore_l2.c |   19 +-
> > >  drivers/net/qede/qede_eth_if.c   |   45 +++--
> > >  drivers/net/qede/qede_eth_if.h   |    1 +
> > >  drivers/net/qede/qede_ethdev.c   |  390
> > > +++++++++++++++++++++++++++++++++++++-
> > >  drivers/net/qede/qede_ethdev.h   |   10 +-
> > >  drivers/net/qede/qede_rxtx.c     |   42 ++--
> > >  9 files changed, 466 insertions(+), 60 deletions(-)
> > >
> > > --
> > > 1.7.10.3
> >
> > Did you get a chance to review these patches for QEDE PMD?
> >
> > Thanks!
> > Rasesh
> 
> Hi,
> 
> a couple of comments I've put in reply to individual patches, and please also
> take into account Harry's comments on the stats patch. Otherwise things look
> pretty ok.
> 
> A general comment that applied to a number of patches is to ensure that the
> titles start with the appropriate verb to describe what the patch is doing.
> For example, the patch:
> 
> qede: set mtu
> 
> is not actually setting the MTU on the nic, but is adding support for setting
> the mtu on the NIC, so should be:
> 
> qede: add support for setting the MTU.
> 
> Please take this into account when doing a V2.

We'll take care of the above.

Thanks!
Rasesh