From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [216.205.24.181]) by dpdk.org (Postfix) with ESMTP id 6CC194CA1 for ; Tue, 16 Oct 2018 17:11:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1539702714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fKQ9BLYrtxbwQMcjcZkU+Dp//SBQp1Ep2NEAGxu9088=; b=PV2me/uFr21j6SPLABFXI7VygEKlDhukz0lAA9Ct5hvwHGSBQP4PAM7d5VPt9ZmPzl602Td8MN4pvadf8LW9ngzvPQtKtb239vK3NONkmxwXtxL3FqkTeV0nnSXU1xNon2bDnqw/1eUhk2VRsEVM67LbgPkTELV1kllngn8tm4k= Received: from NAM05-DM3-obe.outbound.protection.outlook.com (mail-dm3nam05lp0112.outbound.protection.outlook.com [216.32.181.112]) (Using TLS) by us-smtp-1.mimecast.com with ESMTP id us-mta-67-iaQyNHNoM72vMkpYk6Zy6g-1; Tue, 16 Oct 2018 11:11:50 -0400 Received: from SN2PR03MB2143.namprd03.prod.outlook.com (10.166.209.134) by SN2PR03MB2221.namprd03.prod.outlook.com (10.166.209.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Tue, 16 Oct 2018 15:11:47 +0000 Received: from SN2PR03MB2143.namprd03.prod.outlook.com ([fe80::dc74:4f16:90ba:7ed3]) by SN2PR03MB2143.namprd03.prod.outlook.com ([fe80::dc74:4f16:90ba:7ed3%3]) with mapi id 15.20.1228.027; Tue, 16 Oct 2018 15:11:47 +0000 From: "Dey, Souvik" To: "beilei.xing@intel.com" , "jingjing.wu@intel.com" CC: "dev@dpdk.org" , "users@dpdk.org" , Ruinan Hu , Ruinan Thread-Topic: [dpdk-users] i40e VF PMD not getting multicast packets Thread-Index: AdRktGv+672TkLzTSKi5u8xknwrnMQAAQsSAAACPqIAAAUhPwAAAM3AgACjb77AAAEagEA== Date: Tue, 16 Oct 2018 15:11:47 +0000 Message-ID: References: <17849E86-931B-494B-90D7-74E2016C0D3C@gmail.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [208.45.178.4] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN2PR03MB2221; 20:68LW62CjVrVXHxooYiVAPbJ8Q9kbwjlP/Y67TYL4krTYNXm7s6bfVkbH6FI9/bv9ACx7fUdb8hmw8hTVLUcWaMkxIFRbaKfHpBiFsWKFeFdHU/DCnGtnraIo0LxQTo7NKiKZO+N245S82RYAMOXFxuvB6PnCJdHF267KsftIJng= x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 809ba3ab-bde5-4a47-626a-08d63379b12e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:SN2PR03MB2221; x-ms-traffictypediagnostic: SN2PR03MB2221: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(85827821059158)(21748063052155)(28532068793085)(190501279198761)(227612066756510); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(201708071742011)(7699051); SRVR:SN2PR03MB2221; BCL:0; PCL:0; RULEID:; SRVR:SN2PR03MB2221; x-forefront-prvs: 0827D7ACB9 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(136003)(39860400002)(346002)(396003)(53754006)(189003)(199004)(50944005)(66066001)(2501003)(316002)(8676002)(81156014)(81166006)(8936002)(86362001)(5250100002)(93886005)(14454004)(25786009)(39060400002)(106356001)(478600001)(105586002)(2940100002)(4326008)(6246003)(33656002)(2906002)(97736004)(93156006)(7736002)(74316002)(71200400001)(71190400001)(99286004)(2900100001)(3846002)(6116002)(790700001)(229853002)(256004)(14444005)(19609705001)(6506007)(76176011)(53546011)(5660300001)(53936002)(446003)(55016002)(6306002)(54896002)(9686003)(236005)(26005)(102836004)(68736007)(186003)(7696005)(54906003)(110136005)(486006)(6436002)(11346002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2221; H:SN2PR03MB2143.namprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-microsoft-antispam-message-info: sg5KKIxFpDVqixDe+XCIwKF/3X/wUEkfEymHTjRXgtmiMQHMcNxg6T/SMh8P4lCs8r/Oe12eNqAUoHU2dNzBWJMXVha9n6zHBg4OCSp8H+sZzsrAbiQD1HktGo8iIRO/d5QacqePLWsLd0XF5VnGyQzHBD2dm1I4jdPWfmmg1yHj4NSj95U9K/ort29dpJh6LgVGcyWgw7Nopom7wlHSkMNNylnpKev5/5QOg7v3R+ZeB22Wbj6Z/ozw+aHYOJdtNo8WILxfgeijDtlRIdEXXu55ZX6LEaN7GXALm/hqKHFRnv+MxHeLY0i841vaBjLeCOzLZ7zT02BdACnCFuGiNu7WixeV/SN6IOijV1W3BUg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-Network-Message-Id: 809ba3ab-bde5-4a47-626a-08d63379b12e X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Oct 2018 15:11:47.5199 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2221 X-MC-Unique: iaQyNHNoM72vMkpYk6Zy6g-1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-users] i40e VF PMD not getting multicast packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 15:11:55 -0000 SGkgWGluZy9XdSwNCiAgICAgICAgICAgICAgICBJIGFtIHVzaW5nIGRwZGsgMTcuMTEuMiBhbmQg aTQwZSBrZXJuZWwgZHJpdmVyIDIuNC42LCBhbmQgSSBzZWUgYWxsIG11bHRvY2FzdCBwYWNrZXRz IGFyZSBub3QgcmVhY2hpbmcgdGhlIFZGLiBEbyB3ZSBzdXBwb3J0L3Rlc3RlZCBpNDBldmYgcG1k IGZvciB2NiBzdXBwb3J0ID8gQ2FuIHlvdSBwbGVhc2UgbGV0IG1lIGtub3cgd2hhdCB3ZSBuZWVk IHRvIGRvIGV4dHJhIHRvIG1ha2UgdjYgd29yayB3aXRoIGk0MGV2ZiBwbWQuIFY0IHdvcmtzIGZp bmUuIEkgYWxzbyBoYXZlIHJ0ZV9ldGhfYWxsbXVsdGljYXN0X2VuYWJsZSgpIGVuYWJsZWQgYnV0 IHdpdGhvdXQgYW55IHN1Y2Nlc3MuDQoNCi0tDQpSZWdhcmRzLA0KU291dmlrDQoNCkZyb206IERl eSwgU291dmlrDQpTZW50OiBUdWVzZGF5LCBPY3RvYmVyIDE2LCAyMDE4IDExOjA2IEFNDQpUbzog UnVpbmFuIEh1IDxydWluYW4uaHVAY2FzYS1zeXN0ZW1zLmNvbT47IFJ1aW5hbiA8aHVydWluYW5A Z21haWwuY29tPg0KQ2M6IGRldkBkcGRrLm9yZzsgdXNlcnNAZHBkay5vcmcNClN1YmplY3Q6IFJF OiBbZHBkay11c2Vyc10gaTQwZSBWRiBQTUQgbm90IGdldHRpbmcgbXVsdGljYXN0IHBhY2tldHMN Cg0KSGkgUnVpbmFuLA0KICAgICAgICAgICAgICAgIEluIHRoYXQgY2FzZSwgZG8gd2Ugc2F5IHRo YXQgdjYgd2lsbCBub3Qgd29yayBhdCBhbGwgaTQwZXZmIHBtZCB0aWxsIHRydXN0IG1vZGUgaXMg b24gPyBZZXMgSSBkbyBhZ3JlZSB0aGF0IEkgYW0gYWJsZSB0byBzZWUgdGhlIGVycm9yIGluIHRo ZSBkbWVzZyBvbiB0aGUgaG9zdA0K4oCca2VybmVsOiBpNDBlIDAwMDA6ODM6MDAuMzogVW5wcml2 aWxlZ2VkIFZGIDEgaXMgYXR0ZW1wdGluZyB0byBjb25maWd1cmUgcHJvbWlzY3VvdXMgbW9kZeKA nSAsIHdoZW4gdHJ1c3QgbW9kZSBpcyBvZmYsIGJ1dCB3aXRoIHRydXN0IG1vZGUgb24gYWxzbyB3 ZSBhcmUgbm90IGFibGUgdG8gZ2V0IG11bHRpY2FzdCBwYWNrZXRzIHVwIHRvIHRoZSBWTS4gVGhl IHNhbWUgd29ya3MgZmluZSB3aXRoIGxpbnV4IGk0MGV2Ziwgd2hlcmUgdGhlIFZGIGlzIHJlY2Vp dmluZyBhbGwgdGhlIG11bHRpY2FzdCBwYWNrZXRzIGZvciBWNiBJQ01QdjYgTlMgLg0KDQpBbnkg c3VnZ2VzdGlvbiBvbiB3aGF0IGNhbiBiZSByZXF1aXJlZCB0byBtYWtlIHY2IG11bHRpY2FzdCB3 b3JrIHdpdGggaTQwZXZmID8NCg0KTm90ZTogSSBkb27igJl0IHRoaW5rIHZhbmlsbGEgbGludXgg ZHJpdmVyIChpNDBldmYpIGlzIHVzaW5nIHByb21pc2N1b3VzIG1vZGUgdG8gcmVjZWl2ZSBtdWx0 aWNhc3QgcGFja2V0cy4NCg0KLS0NClJlZ2FyZHMsDQpTb3V2aWsNCg0KRnJvbTogUnVpbmFuIEh1 IDxydWluYW4uaHVAY2FzYS1zeXN0ZW1zLmNvbTxtYWlsdG86cnVpbmFuLmh1QGNhc2Etc3lzdGVt cy5jb20+Pg0KU2VudDogTW9uZGF5LCBPY3RvYmVyIDE1LCAyMDE4IDM6MzYgUE0NClRvOiBEZXks IFNvdXZpayA8c29kZXlAcmJibi5jb208bWFpbHRvOnNvZGV5QHJiYm4uY29tPj47IFJ1aW5hbiA8 aHVydWluYW5AZ21haWwuY29tPG1haWx0bzpodXJ1aW5hbkBnbWFpbC5jb20+Pg0KQ2M6IGRldkBk cGRrLm9yZzxtYWlsdG86ZGV2QGRwZGsub3JnPjsgdXNlcnNAZHBkay5vcmc8bWFpbHRvOnVzZXJz QGRwZGsub3JnPg0KU3ViamVjdDogUkU6IFtkcGRrLXVzZXJzXSBpNDBlIFZGIFBNRCBub3QgZ2V0 dGluZyBtdWx0aWNhc3QgcGFja2V0cw0KDQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xw0KTk9USUNFOiBUaGlzIGVtYWlsIHdhcyByZWNlaXZlZCBmcm9tIGFuIEVYVEVSTkFMIHNlbmRl cg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCg0KV2hlbiB5b3Ugc2V0IHRoZSBh bGxtdWx0aWNhc3Qgb3IgcHJvbWlzY3VvdXMgZnJvbSBkcGRrLCBob3N0IHJlamVjdHMgdGhlIHJl cXVlc3QgaWYgdHJ1c3QgYml0IGl0IG9mZi4gWW91IGNhbiBzZWUgdGhlIGVycm9yIG1lc3NhZ2Ug ZnJvbSBkbWVzZy4gSSBkb27igJl0IGtub3cgd2h5IHlvdXIga2VybmVsIGk0MGV2ZiB3b3Jrcy4N Cg0KLVJ1aW5hbiBIdQ0KDQpGcm9tOiBEZXksIFNvdXZpayA8c29kZXlAcmJibi5jb208bWFpbHRv OnNvZGV5QHJiYm4uY29tPj4NClNlbnQ6IE1vbmRheSwgT2N0b2JlciAxNSwgMjAxOCAzOjI3IFBN DQpUbzogUnVpbmFuIDxodXJ1aW5hbkBnbWFpbC5jb208bWFpbHRvOmh1cnVpbmFuQGdtYWlsLmNv bT4+OyBSdWluYW4gSHUgPHJ1aW5hbi5odUBjYXNhLXN5c3RlbXMuY29tPG1haWx0bzpydWluYW4u aHVAY2FzYS1zeXN0ZW1zLmNvbT4+DQpDYzogZGV2QGRwZGsub3JnPG1haWx0bzpkZXZAZHBkay5v cmc+OyB1c2Vyc0BkcGRrLm9yZzxtYWlsdG86dXNlcnNAZHBkay5vcmc+DQpTdWJqZWN0OiBSRTog W2RwZGstdXNlcnNdIGk0MGUgVkYgUE1EIG5vdCBnZXR0aW5nIG11bHRpY2FzdCBwYWNrZXRzDQoN Ck1vcmVvdmVyIEkgd2FudGVkIHRvIG1lbnRpb24gb25lIG1vcmUgdGhpbmcsIHRoYXQgdGhlIGlz c3VlIG9mIG11bHRpY2FzdCBwYWNrZXRzIG5vdCB3b3JraW5nIGlzIG9ubHkgd2l0aCBEUERLIDE0 MGVWRiBQTUQuIEluIGNhc2UgSSB1c2UgdGhlIGk0MGV2ZiBvZiB0aGUga2VybmVsIHRoZW4gaXQg aXMgd29ya2luZyBmaW5lIGFuZCBJIGRvbuKAmXQgc2VlIGFueSBpc3N1ZXMgd2l0aCB2Ni4gU28g d2h5IGlzIHRoZSB0cnVzdCBtb2RlIGEgcmVxdWlyZW1lbnQgZm9yIERQREsgcG1kID8NCg0KRnJv bTogRGV5LCBTb3V2aWsNClNlbnQ6IE1vbmRheSwgT2N0b2JlciAxNSwgMjAxOCAyOjUyIFBNDQpU bzogUnVpbmFuIDxodXJ1aW5hbkBnbWFpbC5jb208bWFpbHRvOmh1cnVpbmFuQGdtYWlsLmNvbT4+ DQpDYzogZGV2QGRwZGsub3JnPG1haWx0bzpkZXZAZHBkay5vcmc+OyB1c2Vyc0BkcGRrLm9yZzxt YWlsdG86dXNlcnNAZHBkay5vcmc+DQpTdWJqZWN0OiBSRTogW2RwZGstdXNlcnNdIGk0MGUgVkYg UE1EIG5vdCBnZXR0aW5nIG11bHRpY2FzdCBwYWNrZXRzDQoNCk5vIHRoZSB0cnVzdCBtb2RlIGlz IG9mZiBjdXJyZW50bHkgb24gdGhlIGhvc3QuIEkgY2FuIHRyeSB3aXRoIHRydXN0IG1vZGUgb24g dG9vLiBCdXQgSSBoYXZlIGEgZG91YnQsIGlzIHRydXN0IG1vZGUgbWFuZGF0b3J5IHRvIGJlIHR1 cm5lZCBvbiB0byBtYWtlIHRoZSBWRiByZWNlaXZlIHY2IG11bHRpY2FzdCBwYWNrZXRzID8gaWYg eWVzIHRoZW4gaG93IHdpbGwgdGhpcyB3b3JrIGluIG9wZW5zdGFjayAoaTQwZSBWRiBkcGRrKSB3 aXRoIHY2ID8NCg0KLS0NClJlZ2FyZHMsDQpTb3V2aWsNCg0KRnJvbTogUnVpbmFuIDxodXJ1aW5h bkBnbWFpbC5jb208bWFpbHRvOmh1cnVpbmFuQGdtYWlsLmNvbT4+DQpTZW50OiBNb25kYXksIE9j dG9iZXIgMTUsIDIwMTggMjozMyBQTQ0KVG86IERleSwgU291dmlrIDxzb2RleUByYmJuLmNvbTxt YWlsdG86c29kZXlAcmJibi5jb20+Pg0KQ2M6IGRldkBkcGRrLm9yZzxtYWlsdG86ZGV2QGRwZGsu b3JnPjsgdXNlcnNAZHBkay5vcmc8bWFpbHRvOnVzZXJzQGRwZGsub3JnPg0KU3ViamVjdDogUmU6 IFtkcGRrLXVzZXJzXSBpNDBlIFZGIFBNRCBub3QgZ2V0dGluZyBtdWx0aWNhc3QgcGFja2V0cw0K DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KTk9USUNFOiBUaGlzIGVtYWlsIHdh cyByZWNlaXZlZCBmcm9tIGFuIEVYVEVSTkFMIHNlbmRlcg0KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18NCg0KSGksDQoNCkRpZCB5b3UgZW5hYmxlIHRydXN0IG1vZGUgb24gdmY/IElm IHRydXN0IGlzIG9mZiBvbiBob3N0LCBwcm9taXNjdW91cyBjYW7igJl0IGVuYWJsZWQgZnJvbSB2 bS4NCg0KUnVpbmFuIEh1DQpydWluYW4uaHVAY2FzYS1zeXN0ZW1zLmNvbTxtYWlsdG86cnVpbmFu Lmh1QGNhc2Etc3lzdGVtcy5jb20+DQooODU3KSAyMDktMTk1NQ0KDQo+IE9uIE9jdCAxNSwgMjAx OCwgYXQgMTQ6MjYsIERleSwgU291dmlrIDxzb2RleUByYmJuLmNvbTxtYWlsdG86c29kZXlAcmJi bi5jb20+PiB3cm90ZToNCj4NCj4gSGkgQWxsLA0KPiBJIGFtIGN1cnJlbnRseSBmYWNpbmcgaXNz dWVzIHdpdGggZ2V0dGluZyB0aGUgbXVsdGljYXN0IElQdjYgcGFja2V0cyB3aGVuIHVzaW5nIHRo ZSBpNDBldmYgcG1kLg0KPg0KPiBJIGRvIHNlZSB0aGVyZSBpcyBhIGxpbWl0YXRpb24gbWVudGlv bmVkIGluIHRoZSByZWxlYXNlIG5vdGVzIG9mIERQREsgdGhhdA0KPg0KPiAxNi4yNy4gSTQwZSBW RiBtYXkgbm90IHJlY2VpdmUgcGFja2V0cyBpbiB0aGUgcHJvbWlzY3VvdXMgbW9kZQ0KPiBEZXNj cmlwdGlvbjoNCj4gUHJvbWlzY3VvdXMgbW9kZSBpcyBub3Qgc3VwcG9ydGVkIGJ5IHRoZSBEUERL IGk0MGUgVkYgZHJpdmVyIHdoZW4gdXNpbmcgdGhlIGk0MGUgTGludXgga2VybmVsIGRyaXZlciBh cyBob3N0IGRyaXZlci4NCj4gSW1wbGljYXRpb246DQo+IFRoZSBpNDBlIFZGIGRvZXMgbm90IHJl Y2VpdmUgcGFja2V0cyB3aGVuIHRoZSBkZXN0aW5hdGlvbiBNQUMgYWRkcmVzcyBpcyB1bmtub3du Lg0KPiBSZXNvbHV0aW9uL1dvcmthcm91bmQ6DQo+IFVzZSBhIGV4cGxpY2l0IGRlc3RpbmF0aW9u IE1BQyBhZGRyZXNzIHRoYXQgbWF0Y2hlcyB0aGUgVkYuDQo+IEFmZmVjdGVkIEVudmlyb25tZW50 L1BsYXRmb3JtOg0KPiBBbGwuDQo+IERyaXZlci9Nb2R1bGU6DQo+IFBvbGwgTW9kZSBEcml2ZXIg KFBNRCkuDQo+DQo+DQo+IERvIHRoaXMgbWVhbiB0aGF0IG11bHRpY2FzdCBwcm9taXNjdW91cyBt b2RlIGlzIGFsc28gbm90IHN1cHBvcnRlZCA/IEkgYW0gY3VycmVudGx5IGZhY2luZyBpc3N1ZXMg d2l0aCByZWNlaXZpbmcgcGFja2V0cyBtdWx0aWNhc3QgcGFja2V0cyBmb3IgSVB2NiB3aGljaCBp cyBtYWtpbmcgSVB2NiB0byBmYWlsIHdpdGggaTQwZXZmIHBtZC4NCj4gSSBhbSBjdXJyZW50bHkg dXNpbmcgMTcuMTEuMiBEUERLIHdpdGggdGhlIENlbnRvcyA3LjUgYW5kIGk0MGUgMi40LjYgdmVy c2lvbiBvbiB0aGUgaG9zdC4gSSBoYXZlIHRoZSBydGVfZXRoX2FsbG11bHRpY2FzdF9lbmFibGUo KSBhbHNvIHNldCBmb3IgdGhlIHBvcnQgYnV0IHN0aWxsIEkgc2VlIGFsbCBtdWx0aWNhc3QgcGFj a2V0cyBhcmUgbm90IHJlYWNoaW5nIHRoZSBwbWQuDQo+IEFsc28gaWYgcHJvbWlzY3VvdXMgbW9k ZSBoYXMgdG8gYmUgdHVybmVkIG9mZiB0aGVuIGhvdyBzaG91bGQgd2UgYWRkIG11bHRpY2FzdCBh ZGRyZXNzIHRvIHRoZSBQRiBmcm9tIHRoZSBWRiA/DQo+IC0tDQo+IFJlZ2FyZHMsDQo+IFNvdXZp aw0K >From thomas@monjalon.net Tue Oct 16 17:13:48 2018 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E7F5B378B for ; Tue, 16 Oct 2018 17:13:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8E0A1222AF; Tue, 16 Oct 2018 11:13:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 16 Oct 2018 11:13:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=SSIDBq3HR7IlMHCzVJ0xlQPfDfcmhZbvo64yuvCPP4E=; b=VZLw/qD2+WZd CenZG4E5brAaKgC3ImbXGk/hgIX0Bf8xXqzxfV1BewUde+TH455GFoekaNeXyIxm YdMswa9tx/Qu/3RjCKHzIlGv9i/J6wxZN+nCyGRPUz2lYukJ2EmBqVuqnt7fQW1Q j2NkLLLuVpYgm46ym160dJ5uOlzc6gc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=SSIDBq3HR7IlMHCzVJ0xlQPfDfcmhZbvo64yuvCPP 4E=; b=s8XgV0wl5350a7n8g7af2FYZ8xZZwvP04c0POtvdw2AZ3TWnsu1MKP4F5 qyKd3hwMHYfuzAvn1rte2gzdY0cA3VBUZCoDTrGv1juy8AOKhPQpLL6fJwDuyFXb pQFdNGJDvidY6pAfYaim8St1vtRNrDi91j+WNzZ3YE7cTy5ZGYbN//OAhSXQ6tHZ IlsFqghmZhDzpRT7bz6gvb3QXavXF7HnvWedsOe0C0bXJKCDo1kSwbQcgfHFF0ZM 8DY0ZRTwXUVL0ZfQTjksKNbNzJP31dnsg1LxsgrgisJR89xzrZdtumHV8eic0BPd lASgH2MgPmtB5LmvWmAuTOtQGG9kw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1E7C6102E9; Tue, 16 Oct 2018 11:13:45 -0400 (EDT) From: Thomas Monjalon To: "Laatz, Kevin" Cc: dev@dpdk.org, harry.van.haaren@intel.com, stephen@networkplumber.org, gaetan.rivet@6wind.com, shreyansh.jain@nxp.com, mattias.ronnblom@ericsson.com, bruce.richardson@intel.com Date: Tue, 16 Oct 2018 17:13:47 +0200 Message-ID: <5304309.9DeCJLfZHl@xps> In-Reply-To: <4335c586-cbe6-9564-d6cf-f1ac125b27ab@intel.com> References: <20181010105134.48079-1-kevin.laatz@intel.com> <3367694.NQyIiAbOc1@xps> <4335c586-cbe6-9564-d6cf-f1ac125b27ab@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 01/13] eal: add param register infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 15:13:48 -0000 16/10/2018 16:20, Laatz, Kevin: > Hi Thomas, > > Thanks for reviewing, see replies below. > > > On 16/10/2018 14:42, Thomas Monjalon wrote: > > Hi, > > > > 11/10/2018 18:58, Kevin Laatz: > >> This commit adds infrastructure to EAL that allows an application to > >> register it's init function with EAL. This allows libraries to be > >> initialized at the end of EAL init. > >> > >> This infrastructure allows libraries that depend on EAL to be initialized > >> as part of EAL init, removing circular dependency issues. > > Let's try to have a clear documentation for this new infra. > Are you looking for a doc file here? Or just better Doxygen comments? Just better doxygen comments. > >> +/** > >> + * @file > >> + * > >> + * This API introduces the ability to register callbacks with EAL. When > > You should explain when the callback is called, and what is the role of > > the callback. > I explained this below with telemetry as an example, maybe it needs to > be extended a little. > > > >> + * registering a callback, the application also provides a flag as part of the > >> + * struct used to register. If the flag is passed to EAL when ruuning a DPDK > > What do you call a flag? Are you talking about an option to be parsed? > Agreed. The wording was unfortunate here. Will change to 'option' to > make it clear it is related to getopt OK, so you may need to change the file name, and struct/variable names. > >> + * application, the relevant callback will be called at the end of EAL init. > >> + * For example, passing --telemetry will make the telemetry init be called at > >> + * the end of EAl init. > >> + * > >> + * The register API can be used to resolve circular dependency issue between > >> + * EAL and the library. > > You need to explain what is the circular dependency issue. > I wrote the Doxygen trying to keep it generic. I can make it telemetry > specific if it will be clearer? No need to be specific. You can explain the library uses EAL and is initialized by EAL too. > > [...] > >> +struct rte_param { > > Please add a global comment for this struct, explain what it represents. > Good spot, thanks. > >> + TAILQ_ENTRY(rte_param) next; /** The next entry in the TAILQ*/ > >> + char *eal_flag; /** The EAL flag */ > > eal_flag, The EAL flag > > Hum... > > Please use different words to explain what is a flag. > > If it is something to be parsed by getopt, it should be called > > an option, not a flag. > > > >> + char *help_text; /** Help text for the callback */ > > What the help text is used for? When is it printed? > The help text is currently not being used. It was added speculatively. Please do not add things speculatively. > >> + rte_param_cb cb; /** Function pointer of the callback */ > >> + int enabled; /** Enabled flag, should be 0 by default */ > > What means enabled in this context? > Enabled means that the option, for example --telemetry, was passed and > that we need to call the > callback at the end of EAL init. If the option was not passed for a > given callback, then the callback > will not be called. OK, you need to explain it in the comment. > >> +}; > >> + > >> +/** > >> + * @internal Check if the passed flag is valid > >> + * > >> + * @param flag > >> + * The flag to be parsed > > Here too, you need to be more explicit about flag meaning. > > > >> + * > >> + * @return > >> + * 0 on success > >> + * @return > >> + * -1 on fail > >> + */ > >> +int > >> +rte_param_parse(char *flag); > >> + > >> +/** > >> + * @warning > >> + * @b EXPERIMENTAL: this API may change without prior notice > >> + * > >> + * Register a function with EAL. Registering the function will enable the > >> + * function to be called at the end of EAL init. > >> + * > >> + * @param reg_param > >> + * rte_param structure > > No, this is not a helpful comment. > > > >> + */ > >> +void __rte_experimental > >> +rte_param_register(struct rte_param *reg_param);