From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0067.outbound.protection.outlook.com [104.47.41.67]) by dpdk.org (Postfix) with ESMTP id B971D293C for ; Tue, 30 Aug 2016 00:31:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SonusNetworks.onmicrosoft.com; s=selector1-sonusnet-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=+adZLlLEodeArXlUS625FGVsxeO27EMP3xkUpLc8+UI=; b=Opzqg+PnYBxbOUErtHSK957v5bfabo/SnIP8M0u/j5VSQvbTXhekHL6tkJMbFjGrsDCASRYqGseWEItrsAx+TnAobamAborjBBpIH9bfpjGkpp74KTjt7H+eYt+4J//OCT58CgizCkpeaczxXmtoNu9WbzwdZhMuQb/pKefRsBo= Received: from SN2PR03MB2271.namprd03.prod.outlook.com (10.166.210.16) by SN2PR03MB2272.namprd03.prod.outlook.com (10.166.210.17) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Mon, 29 Aug 2016 22:28:10 +0000 Received: from SN2PR03MB2271.namprd03.prod.outlook.com ([10.166.210.16]) by SN2PR03MB2271.namprd03.prod.outlook.com ([10.166.210.16]) with mapi id 15.01.0599.010; Mon, 29 Aug 2016 22:28:10 +0000 From: Karmarkar Suyash To: "dev@dpdk.org" Thread-Topic: [PATCH v1]:rte_timer:timer lag issue correction Thread-Index: AQHR/52bfWjFfLhSjESL+N9O2PTYl6BgiYkA Date: Mon, 29 Aug 2016 22:28:10 +0000 Message-ID: References: <20160826132701.18428-1-skarmarkar@sonusnet.com> In-Reply-To: <20160826132701.18428-1-skarmarkar@sonusnet.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=skarmarkar@sonusnet.com; x-originating-ip: [71.235.67.200] x-ms-office365-filtering-correlation-id: 094873f7-a8df-4cdc-5b50-08d3d05bc21e x-microsoft-exchange-diagnostics: 1; SN2PR03MB2272; 6:3xRf+RbfLDc/MhRREmwx127Phxm/dASpkcDxapCnHNvy7sxADk0p/0ego3sum13B4bWqaOplIEs9bMTVTktTVuTKQ7yrBZYs+coTFXbZLF+P7B9nZ4clm6Ik5ePuBb8FffKa9vF7CL/vLK1CLZ5uybZnFRKJ9jevm5m56RmG2gfuBW5EiIZ3fiTkGpZuJ9bfUxMmfhPmPsMLVEDctHjiivl7Z4aowcbh/yiqJZahyC/xX/orv/9nuGxgms6Kz8WIl/fK7qRyVPzK/ctuhbiKOKSrZeYiN2AcNe0Rm9d2a4o=; 5:R6pYEFu7gaplhkKYM77L3T9YBkl4uv6BLHsttP9agaD62AJxlgtr+7VXUtpDdBTGShMgebn/v6OSVEhwyQVvHCz4s3Q4UyaPY9GerSRA6PxNUm//QeqWzw4JJ3ZyJSHE7jgNGef5GefFesMraMICdg==; 24:Ffb0fcL9LqzJD1psiAj0M4re2ABDaGMfCdSx1fv+sRWc4vlKOCOYghonuJUGRZzkvd7spADv/ImXRkTTbCIheOtTl3B/+Ce1suIIsIz+t0A=; 7:m0uK5XDO/vhDr/LJK9HLn4wxHDhJ9yrSRpK1bJXASbbZIeymDVBlSJc+uCXDvuZW3I3sLRkZqAkLJ/O8N5+aQB19UdMeaXbwK6e5+4TSOZETOyMuk0NsCokXWAU+En0NtJar+7eiPhFL7/UgqFMC/8dlRw18kJWfypUKTID9s/z3DrZLwXAhg9Dp1yw6Sdf0nz5B2+JFTe7blFyPGUdvxvyOUxk8yWgaVVhuP4V5a+leZVgvMoWJeJwFVZpul2Cv x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR03MB2272; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(21748063052155); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001); SRVR:SN2PR03MB2272; BCL:0; PCL:0; RULEID:; SRVR:SN2PR03MB2272; x-forefront-prvs: 0049B3F387 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(7916002)(199003)(53754006)(377454003)(189002)(13464003)(11100500001)(107886002)(5002640100001)(3280700002)(105586002)(3660700001)(2906002)(450100001)(189998001)(76576001)(586003)(575784001)(99286002)(8936002)(50986999)(110136002)(7846002)(87936001)(7696003)(3900700001)(106116001)(7736002)(101416001)(54356999)(305945005)(74316002)(10400500002)(6116002)(66066001)(102836003)(3846002)(81166006)(2501003)(33656002)(8676002)(76176999)(1730700003)(81156014)(122556002)(97736004)(5640700001)(86362001)(15975445007)(2950100001)(92566002)(5660300001)(77096005)(9686002)(106356001)(2351001)(68736007)(19580395003)(2900100001)(19580405001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR03MB2272; H:SN2PR03MB2271.namprd03.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: sonusnet.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: sonusnet.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2016 22:28:10.4760 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2272 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1]:rte_timer:timer lag issue correction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 22:31:07 -0000 Hello All, Can you please review the change and let me know if any comments. I would l= ike to push this patch to 16.07 release. Thanks Regards Suyash Karmarkar -----Original Message----- From: Karmarkar Suyash Sent: Friday, August 26, 2016 9:27 AM To: rsanford@akamai.com Cc: dev@dpdk.org; Karmarkar Suyash Subject: [PATCH v1]:rte_timer:timer lag issue correction For Periodic timers ,if the lag gets introduced, the current code added additional delay when the next peridoc timer was initialized by not taking into account the delay added, with this fix the code would start the next occurrence of timer keeping in account the lag added.Corrected the behavior. Fixes:rte_timer: timer lag issue Karmarkar Suyash (1): Signed-off-by: Karmarkar Suyash > lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) From ba885531ac26af1aabc6bd0f58d7ce744b04acf7 Mon Sep 17 00:00:00 2001 From: Karmarkar Suyash > Date: Fri, 26 Aug 2016 09:20:37 -0400 Subject: [PATCH v1] Signed-off-by: Karmarkar Suyash > --- lib/librte_timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 43da836..18782fa 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -613,7 +613,7 @@ void rte_timer_manage(void) status.owner =3D (int16_t)lcore_id; rte_wmb(); tim->status.u32 =3D status.u32; - __rte_timer_reset(tim, cur_time + tim->period, + __rte_timer_reset(tim, tim->expire + tim->period, tim->period, lcore_id, tim->f, tim->arg, 1)= ; rte_spinlock_unlock(&priv_timer[lcore_id].list_lock= ); } -- 2.9.3.windows.1