Re: [dpdk-dev] I40evf VLAN stripping disable

["Dey, Souvik" <sodey@rbbn.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 3106 bytes --]

Hi Xing,
                Do we need to do i40evf_add_vlan() to get the vlan packets up to the VM like we had in ixgbe_vf?  I see that if I have the vlan added through i40evf_add_vlan(), then the packet is received with the vlan stripped even if the vlan_strip is disabled in the PF. If I just do vlan_strip disabled and then send vlan packets it is all coming up to the VM. But is that not security issue as all VLANs even if not configured will be coming up to the VM, which never happened in the ixgbe case. I only have rte_eth_allmulticast_enable in my app , so expect that unicast/broadcast promisc mode is disabled by default.

--
Regard,
Souvik

From: Xing, Beilei [mailto:beilei.xing@intel.com]
Sent: Monday, June 11, 2018 3:58 AM
To: Dey, Souvik <sodey@rbbn.com>; Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org
Cc: users@dpdk.org
Subject: RE: I40evf VLAN stripping disable

________________________________
NOTICE: This email was received from an EXTERNAL sender
________________________________

Hi Souvik,

Could you try with kernel driver (version 2.4.3) first? In my environment, disable vlan strip in DPDK works with kernel driver version 2.4.3.

My test steps with testpmd:
>set fwd rxonly
>set verbose 1
>set promisc 0 off
>vlan set strip off 0
Then send a vlan packet with VF mac address.

Best Regards,
Beilei Xing

From: Dey, Souvik [mailto:sodey@rbbn.com]
Sent: Friday, June 8, 2018 11:22 PM
To: Xing, Beilei <beilei.xing@intel.com<mailto:beilei.xing@intel.com>>; Wu, Jingjing <jingjing.wu@intel.com<mailto:jingjing.wu@intel.com>>; dev@dpdk.org<mailto:dev@dpdk.org>
Cc: users@dpdk.org<mailto:users@dpdk.org>
Subject: I40evf VLAN stripping disable

Hi i40e/i40evf maintainers,

I was testing VLANs with i40evf pmd and is hitting the below issue.

I have the following configuration:
- host runs with Linux pf i40e driver(version 2.4.6)
- guest runs with DPDK 17.11.2 vf i40e driver

When I am sending a vlan packet from the outside to the guest, on the guest, I receive the packet which has the PKT_RX_VLAN_STRIPPED flag set although I'm not asking for it.
Even though my DPDK app has the rte_eth_conf.rxmode.hw_vlan_strip set to 0 and also verified that the i40evf_disable_vlan_strip(VIRTCHNL_OP_DISABLE_VLAN_STRIPPING) function is getting called and not returning any error from the linux pf driver.
Is this the default behavior that the VLAN will be always stripped by the PF irrespective of the setting ? Should the DPDK version take care of the re-adding the tag back to the packet in case hw_vlan_strip is disabled ? What should be best way of handling it ? Is it a bug in DPDK or I am missing something here.

I do see in the linux i40evf driver we are insert vlan header in the received packets in some cases.

--
Regards,
Souvik
\x16º&‘è­‡\b¥zȧµé\¢c(œ›§×]|ßžtÛM|Eën®sÚ¶\x19\x1eŠØpŠW¬Š{^•Ê&Eç\x1eŠ÷~º&š\x06´ö)ízW(šh\x1aÓاµé\¢mwã]ø×~¶á¼¥Ù(®\x03è²×âÇ\b­„DŒLøÔ^×Q7Ógè­×¯v—d¢¸\f¢}u&éöÓ_5ó~x÷í6Ó@„I5Àš”^²émH¢\x0f<@ç¡«miÈfz{bžg¬±¨\x1e\	©\x16)^R™hiם\x15©ly\x17œz+Þuúè™ù¬š\x06´Ó§æŠ{^•Ê&×M¹ßn6Ѽ¨®É k]6ø§µé\¢l"¶\x11\x1213ÿL´¿\fq\x11H\0\x04Knz\x18#\x12\x1c\rüã]Iº}´×Í=ßž<Ó½4\Lm.Š)×UÈ®‰Ï¢»@T