From: "Verma, Shally" <Shally.Verma@cavium.com>
To: Fiona Trahe <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"tomaszx.jozwiak@intel.com" <tomaszx.jozwiak@intel.com>,
"sabyasg@hpe.com" <sabyasg@hpe.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] lib/compressdev: Fix logic error on op allocation
Date: Tue, 30 Oct 2018 14:00:13 +0000 [thread overview]
Message-ID: <SN6PR07MB51520906B27C9C0FE04DDCB3F0CC0@SN6PR07MB5152.namprd07.prod.outlook.com> (raw)
In-Reply-To: <1540600987-8101-1-git-send-email-fiona.trahe@intel.com>
>-----Original Message-----
>From: Fiona Trahe <fiona.trahe@intel.com>
>Sent: 27 October 2018 06:13
>To: dev@dpdk.org
>Cc: thomas@monjalon.net; akhil.goyal@nxp.com; tomaszx.jozwiak@intel.com; sabyasg@hpe.com; Verma, Shally
><Shally.Verma@cavium.com>; Fiona Trahe <fiona.trahe@intel.com>; stable@dpdk.org
>Subject: [PATCH v2] lib/compressdev: Fix logic error on op allocation
>
>External Email
>
>Fixed bad logic in rte_comp_op_alloc() checking return
>value from rte_comp_op_raw_bulk_alloc(). This
>could have resulted in a seg-fault in error case.
>Made rte_comp_ob_bulk_alloc() code consistent
>with rte_comp_op_alloc().
>
>
>Fixes: 96086db5a369 ("compressdev: add operation management")
>Cc: stable@dpdk.org
>
>Reported-by: Sabyasachi Sengupta <sabyasg@hpe.com>
>Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>---
>v2 change:
> - added Reported-by tag
>
> lib/librte_compressdev/rte_comp.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c
>index c663be5..4634c12 100644
>--- a/lib/librte_compressdev/rte_comp.c
>+++ b/lib/librte_compressdev/rte_comp.c
>@@ -174,7 +174,7 @@ rte_comp_op_alloc(struct rte_mempool *mempool)
> int retval;
>
> retval = rte_comp_op_raw_bulk_alloc(mempool, &op, 1);
>- if (unlikely(retval < 0))
>+ if (unlikely(retval != 1))
> return NULL;
>
> rte_comp_op_reset(op);
>@@ -186,12 +186,12 @@ int __rte_experimental
> rte_comp_op_bulk_alloc(struct rte_mempool *mempool,
> struct rte_comp_op **ops, uint16_t nb_ops)
> {
>- int ret;
>+ int retval;
> uint16_t i;
>
>- ret = rte_comp_op_raw_bulk_alloc(mempool, ops, nb_ops);
>- if (unlikely(ret < nb_ops))
>- return ret;
>+ retval = rte_comp_op_raw_bulk_alloc(mempool, ops, nb_ops);
>+ if (unlikely(retval != nb_ops))
>+ return 0;
>
> for (i = 0; i < nb_ops; i++)
> rte_comp_op_reset(ops[i]);
>--
>2.7.4
Acked-by: Shally Verma <Shally.Verma@caviumnetworks.com>
next prev parent reply other threads:[~2018-10-30 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 0:17 [dpdk-dev] [PATCH] " Fiona Trahe
2018-10-27 0:31 ` Thomas Monjalon
2018-10-27 0:43 ` [dpdk-dev] [PATCH v2] " Fiona Trahe
2018-10-30 14:00 ` Verma, Shally [this message]
2018-11-02 11:42 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR07MB51520906B27C9C0FE04DDCB3F0CC0@SN6PR07MB5152.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=sabyasg@hpe.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tomaszx.jozwiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).