From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-SN1-obe.outbound.protection.outlook.com (mail-eopbgr700062.outbound.protection.outlook.com [40.107.70.62]) by dpdk.org (Postfix) with ESMTP id A7A1A1B490 for ; Sat, 12 Jan 2019 07:47:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XWws6+kRUUzU3Pa1tkAn6GNm0qHv53pXJIYUVzwP+IE=; b=AD4aEAelWEOb4GAP0QU0ubx8nrNz/8Z2arDeF9K4LkgW+Ea6bUcmDrAb7MKNCQ+boQVB5poyxDJCOpAQJNPpiY/5IArH2oE1CVc3DydPzrV5e+mbjXi4cUyJEbn94DbEQIHZKE1BGcfPq2K78kJUBrpw8S5qDB93+me40ZieVEo= Received: from SN6PR07MB5152.namprd07.prod.outlook.com (52.135.101.33) by SN6PR07MB4717.namprd07.prod.outlook.com (52.135.77.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.9; Sat, 12 Jan 2019 06:47:29 +0000 Received: from SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::693e:bbbb:370a:2ce0]) by SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::693e:bbbb:370a:2ce0%2]) with mapi id 15.20.1516.016; Sat, 12 Jan 2019 06:47:29 +0000 From: "Verma, Shally" To: "De Lara Guarch, Pablo" , "Trahe, Fiona" , Stephen Hemminger CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Jozwiak, TomaszX" , "Gupta, Ashish" , "Daly, Lee" , "Luse, Paul E" , "Trahe, Fiona" Thread-Topic: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done Thread-Index: AQHUgHHzFvAwN1WsuUCvEJs8a5amE6VX5t6AgADzhoCAABxlgIAryE4AgAD8WHCAAL7xgIAirluAgAJakxA= Date: Sat, 12 Jan 2019 06:47:29 +0000 Message-ID: References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> <20181119175349.2bd2fdd1@xeon-e3> <348A99DA5F5B7549AA880327E580B4358967C84F@IRSMSX101.ger.corp.intel.com> <20181120100703.34c462e9@xeon-e3> <348A99DA5F5B7549AA880327E580B435896A4B55@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B435896A5DB3@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [171.49.235.13] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4717; 6:AEd6efxbzYeCvAtSHvxCr6gZVW4+QejxlV1BuaLC3msvU0+KUwFxlFJC7oVnT0E6RnYtJNOtCmz22oNUkgcwigOZUkwmAElMxeGc5sgC0S1yrzFhWx9fmIovXLqgqYqkGI3xU+ibzaY8U9vGkQn1Xqiqf1xwpsBEC3ITaNlDmShG/QeOVWsuvz0F1MiUFZyZrcZlohvymK7ZGKoeqAzIXqi87aPyfxgcZtSxUHsWiZyZppnSUFhNXOMDNhEDZsHGSgGnTcQRj8d+QLncH0ES3IxL3wQPCcGaTz7AbN1QKay7l1ZbMkkDl5jb1cxKnvOL+h42Zt1jbPRCMru5jdiAgqNzXuFTi6kvEwOxKKYOrPPeteRuJA8x2E4nJdWF3lcFPgRWDryuq0yREbWcq+T9F4/zBEefPbIYYqy4IL3T+GtuZNnk3grRaA/DtDCRf9LAhuStxanTi93oJquRPFE1AQ==; 5:T/XqPGRgYrKSEo/TN6hO4dwc/4bEomCeoiev2lOnaKmTZz+62h+vZ2VVRz/f1M8C6D+6iTNeUYk1S1pAol7bRcu5lkCCAiP8HxVQDM8udNbxcTHRFFT+cojAjwEG82UwrnsxRhgCdFlUMykcphO/2LVAcrnScPgEoJ+MZwPVKvutFQjJnRQuxDDxPeTzngdsmPhnJurcBTLDRQDSzpTtiQ==; 7:H0PyZTSKz9CtdQevMpGrQy1b15VmKRyCwcBLwBBYKbGApHFYT/zXBFd5o0ML1QbI66egPke9WlvAZ9wzVYgLsT18d5Nzw65O3BQuJEWGP+c6kujIz0ANosObbfsObhjbjVQp9g4e7ZzX83BubwvELA== x-ms-office365-filtering-correlation-id: 5d752de1-c967-4870-05a1-08d67859d24f x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4717; x-ms-traffictypediagnostic: SN6PR07MB4717: x-microsoft-antispam-prvs: x-forefront-prvs: 0915875B28 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(136003)(396003)(346002)(13464003)(189003)(199004)(486006)(99286004)(7736002)(446003)(25786009)(81166006)(68736007)(105586002)(106356001)(9686003)(478600001)(14444005)(55016002)(97736004)(74316002)(256004)(66066001)(6246003)(3846002)(186003)(8676002)(4326008)(81156014)(6116002)(229853002)(6436002)(476003)(316002)(11346002)(54906003)(71200400001)(71190400001)(76176011)(8936002)(86362001)(33656002)(7696005)(102836004)(55236004)(14454004)(2906002)(110136005)(26005)(72206003)(5660300001)(93886005)(305945005)(6506007)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4717; H:SN6PR07MB5152.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: wAVb+0PUM3/uuzr7vg6+Ft5XsDx0NxQvXpOWtwEGPWcyN/ciTUWR5mU6Nrcm3MeP2GKyw4bU7YMEZBmzRbXBzpHB0QWMmzq4PT5bEKwWH5ia4UOm9AvNy2ijzQDxw5UrST5y6l94aHwvhWaCmg8REEuIL4hyWkeGLRqeP3d+zDe6O3+rKwmC8jLSuzWaDpk90VXdcgdPjY5b5gRNLxoDNQsBDjg3Z9bf9yVDukQKs+HgLjkBan+7Y8Iq5YtfNJMMBSd3kgkRfTFjnA3ZCP58PgBQSnwYbU6F+fTcvJsWvoJV35IHrnTYCBTIiEZH3NX47bgYyO7xGu9z5UsViPpDWaws2MhtwTARfeiIK5BL2mHJZuE65nFo079t+Wogwws0BrYhIMEYyOluvOEPy2moHeTObuRLCan+AHWKtMNmzwM= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d752de1-c967-4870-05a1-08d67859d24f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2019 06:47:29.3289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4717 Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jan 2019 06:47:32 -0000 HI Pablo Sorry for delay in response. >-----Original Message----- >From: De Lara Guarch, Pablo >Sent: 11 January 2019 00:17 >To: Trahe, Fiona ; Verma, Shally ; Stephen Hemminger > >Cc: dev@dpdk.org; akhil.goyal@nxp.com; Jozwiak, TomaszX ; Gupta, Ashish >; Daly, Lee ; Luse, Paul E ; Trahe, Fiona > >Subject: RE: [dpdk-dev] [PATCH] compressdev: add feature flag to specify w= here processing is done > .... >> > >> I just did a survey of DPDK an 1/3 of it is never used by any open >> > >> source project. Hate to see more dead code and special cases creat= ed. >> > >> >> > >> At least, some example code in examples would help. Something like >> > >> a simple in memory compressed storage server using a network API >> > >> (SMB?/SSH?/FTP?) >> > >[Fiona] There is no compressdev sample app yet. >> > >However I've double-checked with the SPDK team, they're currently >> > >integrating compressdev and intend to push a patch to SPDK - a storag= e >> open-source project - using this flag. >> > [Shally] Am seeing some of our HW based PMD also leveraging this >> > choice. So I would say to make it generic feature flag instead of SW s= pecific. >> [Fiona] I can do but would like to understand this better first. >> My understanding of HW offload is that the enqueue is just packaging up >> the op and sending to the HW. >> And the dequeue is just collecting the result from the HW and passing ba= ck >> to the op. >> The work is done by the HW accelerator, in between those 2 API calls, no= t >> using any CPU cycles. >> So what would it mean for HW to set OP_DONE_IN_DEQUEUE? > >Any comments on this? I agree with Fiona that this flag makes sense on SW = only, >but it seems that you have another use case. I am waiting for feedback on this internally. Will revert on this as I get = more information. Thanks Shally > >Thanks, >Pablo > >> >> > Thanks >> > Shally