From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0088.outbound.protection.outlook.com [104.47.32.88]) by dpdk.org (Postfix) with ESMTP id 437847D4E for ; Wed, 17 Oct 2018 18:47:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nRGk5GPbJg78kyULpDsHNryIx+Q7gOdbsyzUfl9+4rQ=; b=dCqcLb+ddQwIx9LPxncI5959OT9HNvMMfzcn5ZEL91Pmry5mw5Rldd5Q7UxUwUEiHutKtpsaD8ck/UXX/CbjV14wJkIPR+9KuvnAbwo/c9h/9VoIKeX1Dtihz86kPO1WPhFQfPfaBx0R2UVjhRnHkXTCdYIaqkhTGEQlA1LCzx8= Received: from SN6PR07MB5152.namprd07.prod.outlook.com (52.135.101.33) by SN6PR07MB5151.namprd07.prod.outlook.com (52.135.101.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1228.24; Wed, 17 Oct 2018 16:47:33 +0000 Received: from SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::308f:470:554e:a3a4]) by SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::308f:470:554e:a3a4%5]) with mapi id 15.20.1228.032; Wed, 17 Oct 2018 16:47:32 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "Daly, Lee" CC: "Jozwiak, TomaszX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUZJk28lZzGIoUx06rWRnV5/lDBqUjg5QAgAASrmCAABIcgIAAAIuA Date: Wed, 17 Oct 2018 16:47:32 +0000 Message-ID: References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> <348A99DA5F5B7549AA880327E580B4358964F1CB@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358964F45C@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B4358964F45C@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [223.230.98.87] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB5151; 6:q6SbztCRhT7jD+wevZmy05g9OCL2QnIMaSlNc6cJWC/Vj8DXTPCT/xc1ZI8ve47be4/8nEiY9tyrXQomxeJjvAOzjycj9uq4xBKGtOgmhf6YToRDuh0ZSWfWp1zZwgwswKXK3mH3KJUHs+S6Xb/2k22zaR5PAAx4MGZevkJvDzN+qziJ0zJeMBAJyKYpsY3Bq1lMVOnUShuhhBp+ggGce+srcEzOkkIZhcn/PFuKvZbUuGrYNRoUOWkMyQ86x7/IC3xAiZWHjseeD+rcC1iopA3bFyY3+KQksWLzGa8nPmcQuhdQlzJOdbGoKTw+tcHLJbOUk+BT7h7qN1pYXq8jw3QMD5j7bVOaQBsnHL7JRsL6boVve35Mfqrc1VY7DIYXlg4CwK2HcxLCoAJGr9QRBkZTaVGI5j2180Q8E/354sQ6WVGdt8mkxVg66qtSfg+2r2RnVGnp3ffxNV5eGGMyXQ==; 5:8+SDrgYg/w+i+XyoW3bVLz1G0pgtnrRhIO6jaykvYwdpLmqfCGxQ0EwYvVZJClOBhrB8Z9JuSleddjtiOwG75UDUUm4uoyYZ1t4akFWO07v7xMad1xGTjPFgGKjc+TmO3aNfOmC43a1x27UFqikE5GoWPMNtwe9MYb6FmypQE7A=; 7:ItJ3ULtgIRv88iRC3jzTcVVydIvhdD0regv9BRDd1myNtNZphfFoA+BIMFLdqyjB7EUe14zxq512qW3kXV8zyaQrIMo91RkBxRReX15GJr/J9Slqqx0oTNg9jYo2Tz93BZuDEbWNRabzNeJ9oBxzRN2dZmCpt1jBBAaMyr4ajfp7OEXTpztv4Fu8IM1lzSHgLVgb0Q46HT+ehEsHvo7f6Due0F5PkRXibRpAs1BUnfhI2iwAOacGbyIROcAqRzOs x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 1ae6d9cf-39de-4a68-08be-08d634503c18 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5151; x-ms-traffictypediagnostic: SN6PR07MB5151: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231355)(944501410)(52105095)(3002001)(149066)(150057)(6041310)(20161123558120)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB5151; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5151; x-forefront-prvs: 08286A0BE2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(396003)(346002)(136003)(55674003)(189003)(199004)(57704003)(13464003)(68736007)(229853002)(86362001)(99286004)(81166006)(81156014)(8936002)(93886005)(71200400001)(5250100002)(71190400001)(6116002)(3846002)(2900100001)(76176011)(55016002)(2906002)(9686003)(7696005)(74316002)(7736002)(33656002)(105586002)(106356001)(316002)(305945005)(53546011)(6506007)(6436002)(54906003)(110136005)(14454004)(446003)(478600001)(476003)(72206003)(486006)(6246003)(5660300001)(102836004)(14444005)(256004)(97736004)(25786009)(53936002)(4326008)(11346002)(26005)(66066001)(186003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5151; H:SN6PR07MB5152.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: +bpX+Mn16zqhUsGSsg+fbMJhLW1tRwxd7wy+SSG0jNsP0FoV9UgZvIgcn0+0alu5RPHnN7cXIFnAzy4GLua7yCiObT13Qgm0UWZHrbeItwZz52xhgCz+OqUbAzwjTBn8HwzIiEkEcZ/QbOyY5JF4ZKNU2RiWJWxBpqaa+vP3vW2+nUfcaqEXm0PVVHKL7ij959keMeBjPgT5ys4aOONurC1WWIVE1I+SuCq3Klf9PnLn05WqbVhuVYAL/EjCJK7v98yz6cVkRFL4MKE1D3Qqo3qOV00Ebh2Buv8Rm9pZPhK580nN2KM/WFXTiF39pv10AsvZg8oUxu+W8oiRVhd/QrcqUgGlN5QbsK/GhODipFg= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ae6d9cf-39de-4a68-08be-08d634503c18 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Oct 2018 16:47:32.7798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5151 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 16:47:35 -0000 >-----Original Message----- >From: Trahe, Fiona >Sent: 17 October 2018 22:15 >To: Verma, Shally ; Daly, Lee >Cc: Jozwiak, TomaszX ; dev@dpdk.org; akhil.goya= l@nxp.com; Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance mea= surement > >External Email > >> -----Original Message----- >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> Sent: Wednesday, October 17, 2018 8:43 AM >> To: Trahe, Fiona ; Daly, Lee >> Cc: Jozwiak, TomaszX ; dev@dpdk.org; akhil.go= yal@nxp.com >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance m= easurement >> >> >> >> >-----Original Message----- >> >From: Trahe, Fiona >> >Sent: 17 October 2018 20:04 >> >To: Daly, Lee ; Verma, Shally >> >Cc: Jozwiak, TomaszX ; dev@dpdk.org; akhil.g= oyal@nxp.com; Trahe, Fiona >> >> >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance = measurement >> > >> >External Email >> > >> >Hi Shally, Lee, >> > >> >> -----Original Message----- >> >> From: Daly, Lee >> >> Sent: Monday, October 15, 2018 8:10 AM >> >> To: Verma, Shally >> >> Cc: Jozwiak, TomaszX ; dev@dpdk.org; Trahe= , Fiona >> >> ; akhil.goyal@nxp.com >> >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performanc= e measurement >> >> >> >> Thanks for your input Shally see comments below. >> >> >> >> >> >> I will be reviewing these changes while Tomasz is out this week. >> >> >> >> > -----Original Message----- >> >> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, Shally >> >> > Sent: Friday, October 12, 2018 11:16 AM >> >> > To: Jozwiak, TomaszX ; dev@dpdk.org; Tra= he, >> >> > Fiona ; akhil.goyal@nxp.com; De Lara Guarch,= Pablo >> >> > >> >> > Cc: De@dpdk.org; Lara@dpdk.org; Guarch@dpdk.org >> >> > Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performa= nce >> >> > measurement >> >> > >> >/// >> > >> >> >Also, why do we need --max-num- >> >> > sgl-segs as an input option from user? Shouldn't input_sz and seg_s= z >> >> > internally decide on num-segs? >> >> > Or is it added to serve some other different purpose? >> >> Will have to get back to you on this one, seems illogical to get this= input from user, >> >> But I will have to do further investigation to find if there was a di= fferent purpose. >> > >> >[Fiona] Some PMDs have a limit on how many links can be in an sgl chain= , e.g. in QAT case the >> >PMD allocates a pool of internal structures of a suitable size during d= evice initialisation, this is not >> >a hard limit but can be configured in .config to give the user control = over the memory resources allocated. >> >This perf-tool max-num-sgl-segs is so the user can pick a value <=3D wh= atever the PMD's max is. >> >> Then also, I believe this could be taken care internally by an app. >> App can choose convenient number of sgl segs as per PMD capability and i= nput sz and chunk sz selected by >> user. >> Just my thoughts. >[Fiona] Then we'd need to add this capability to the API, e.g. add uint16_= t max_nb_segments_per_sgl >into the rte_compressdev_info struct. >Special case 0 means no limit. >We did consider this before, I can't remember why we didn't do it, I think= it's needed. >I'll push an API patch for this in 19.02 and we can remove the --max-num-s= gl-segs param from >the performance tool and hardcode it in the tool in the meantime. >Ok? Yea. Sounds better.