From: "Verma, Shally" <Shally.Verma@cavium.com>
To: Fiona Trahe <fiona.trahe@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"tomaszx.jozwiak@intel.com" <tomaszx.jozwiak@intel.com>,
"lee.daly@intel.com" <lee.daly@intel.com>,
"sabyasg@hpe.com" <sabyasg@hpe.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] lib/compressdev: clarify usage of op structure
Date: Tue, 30 Oct 2018 13:59:34 +0000 [thread overview]
Message-ID: <SN6PR07MB51525556E338D5071E7C1233F0CC0@SN6PR07MB5152.namprd07.prod.outlook.com> (raw)
In-Reply-To: <1540599234-17310-1-git-send-email-fiona.trahe@intel.com>
>-----Original Message-----
>From: Fiona Trahe <fiona.trahe@intel.com>
>Sent: 27 October 2018 05:44
>To: dev@dpdk.org
>Cc: thomas@monjalon.net; akhil.goyal@nxp.com; tomaszx.jozwiak@intel.com; lee.daly@intel.com; sabyasg@hpe.com; Verma, Shally
><Shally.Verma@cavium.com>; Fiona Trahe <fiona.trahe@intel.com>; stable@dpdk.org
>Subject: [PATCH] lib/compressdev: clarify usage of op structure
>
>External Email
>
>Add note on usage of op structure and when it can be
>accessed and freed.
>
>Fixes: 63f4bfd5328b ("compressdev: add enqueue/dequeue functions")
>Cc: stable@dpdk.org
>
>Signed-off-by: Fiona Trahe <fiona.trahe@intel.com>
>---
> lib/librte_compressdev/rte_compressdev.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>diff --git a/lib/librte_compressdev/rte_compressdev.h b/lib/librte_compressdev/rte_compressdev.h
>index 5b4fca4..7b68170 100644
>--- a/lib/librte_compressdev/rte_compressdev.h
>+++ b/lib/librte_compressdev/rte_compressdev.h
>@@ -408,6 +408,13 @@ rte_compressdev_dequeue_burst(uint8_t dev_id, uint16_t qp_id,
> * @note All compression operations are Out-of-place (OOP) operations,
> * as the size of the output data is different to the size of the input data.
> *
>+ * @note The rte_comp_op contains both input and output parameters and is the
>+ * vehicle for the application to pass data into and out of the PMD. While an
>+ * op is inflight, i.e. once it has been enqueued, the private_xform or stream
>+ * attached to it and any mbufs or memory referenced by it should not be altered
>+ * or freed by the application. The PMD may use or change some of this data at
>+ * any time until it has been returned in a dequeue operation.
>+ *
> * @note The flush flag only applies to operations which return SUCCESS.
> * In OUT_OF_SPACE cases whether STATEFUL or STATELESS, data in dest buffer
> * is as if flush flag was FLUSH_NONE.
>--
>2.7.4
Acked-by: Shally Verma <Shally.Verma@caviumnetworks.com>
next prev parent reply other threads:[~2018-10-30 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-27 0:13 Fiona Trahe
2018-10-30 13:59 ` Verma, Shally [this message]
2018-11-02 11:43 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR07MB51525556E338D5071E7C1233F0CC0@SN6PR07MB5152.namprd07.prod.outlook.com \
--to=shally.verma@cavium.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=lee.daly@intel.com \
--cc=sabyasg@hpe.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tomaszx.jozwiak@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).