From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690070.outbound.protection.outlook.com [40.107.69.70]) by dpdk.org (Postfix) with ESMTP id EAD462BD5 for ; Tue, 20 Nov 2018 06:17:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MZ3+JoJFm0C16SXpkFYDKGjZkWpRadwqapQXfPvtBNU=; b=RTpa35DwnAt1tJu7bh9ILQLxkyd3jv3uZtRD0EnN4eA9kSFb02NX6mRGJlXmFlautwxD5BO4f59R8iIIt8QS65DHvZu80qqwuqZQfSy5MXx7ap4IhtP5wuUmxRn/jwEAOHKDg1LZFtpfrmJoTb4U/d3YhdGk17Wo9A3pH+oF0AU= Received: from SN6PR07MB5152.namprd07.prod.outlook.com (52.135.101.33) by SN6PR07MB4208.namprd07.prod.outlook.com (52.135.96.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.25; Tue, 20 Nov 2018 05:17:22 +0000 Received: from SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::49cb:b2a:974:2211]) by SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::49cb:b2a:974:2211%4]) with mapi id 15.20.1294.045; Tue, 20 Nov 2018 05:17:20 +0000 From: "Verma, Shally" To: Fiona Trahe , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "tomaszx.jozwiak@intel.com" , "Gupta, Ashish" , "lee.daly@intel.com" Thread-Topic: [PATCH] compressdev: add feature flag to specify where processing is done Thread-Index: AQHUgHHzFvAwN1WsuUCvEJs8a5amE6VYG3rg Date: Tue, 20 Nov 2018 05:17:19 +0000 Message-ID: References: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> In-Reply-To: <1542677988-3876-1-git-send-email-fiona.trahe@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4208; 6:V42dqabtonHTrAfhMqOkf48O03cInwdtDJGzxcxM8viYBNn8x1KN+LHlCXoT97doLNh5QBNMZQxt/B10/svJqYthIPQguRs0uqFiYxGFiHLm5FdVGtJ+dm1Uq6y9QNG9TboApxGCuJo07QDbcAP/kTHThhg1bZKyuHgkauOC6YyttfvjMABrBEt2br7DSqQrcQ4dFQGllClM0BVkLSufpxBxgRGb1kfQWSW/Q1ZvcK8wa3fmDN4E8zWQ6KnZ5OVa6lUB7t4WX46wv3bgGe+25qOLUgN/dvc7oNctHVD6Z+JVNX2UPAcJ5pfK0MhwhUprmOb7lXhPAnuyZ5lYZ46WypVCnR9En7rAmNo0e/XCDr+X1ObD8XHNqcoSUiDMP86lLbQsfQLvRiez41/h6FosByoMOXfkWu5paIlHjnfHUeDJfoQAJXGC/6lsXJS8uMv3Qn+9k1ybmOc3BC2jjhEcng==; 5:mEAxMmNmzkgi+r0AAJDsca6qTbF1VyQ8S19sPINNpMyVYqWTjjh2YkA1J2bhX9e9rB1QaJQCBoGz2AljEubXDvY4tmcPKxNYa88FTk+X+kVsnPa/a4AqXPRKb/6wwufPmDbDaswSaEmaCRL6GH4y7liJ8FD/ig9GUm+8y5x/1bU=; 7:jyRu7QG1rhqMjDew+g6e7sOZEvANmaCQnPe8FoZoBvRPBHYxWhuvq2hFkkA1qGuGrxv1CuQC+wNzcc5t7M94cU8crD9TG4lo+RYMSubmuce0c5ciMZS2Cs4fA2JAX+p3fnRTZ1USotDFKda2wlY6Kg== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(366004)(346002)(376002)(13464003)(189003)(199004)(51234002)(102836004)(229853002)(446003)(305945005)(186003)(476003)(68736007)(97736004)(26005)(7736002)(5660300001)(99286004)(8936002)(3846002)(9686003)(110136005)(76176011)(54906003)(55236004)(11346002)(14454004)(86362001)(2900100001)(55016002)(72206003)(6116002)(81156014)(81166006)(8676002)(486006)(2906002)(478600001)(53936002)(33656002)(256004)(316002)(105586002)(7696005)(2501003)(71190400001)(71200400001)(4326008)(6246003)(6506007)(66066001)(106356001)(25786009)(74316002)(6436002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4208; H:SN6PR07MB5152.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-office365-filtering-correlation-id: 7ec86988-e7d0-4bab-ef74-08d64ea77228 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4208; x-ms-traffictypediagnostic: SN6PR07MB4208: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3231442)(944501410)(52105112)(3002001)(93006095)(93001095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB4208; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4208; x-forefront-prvs: 08626BE3A5 received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: fsWKKzTQzDRNk8ikcKJmbbKolmEDUATWyTvcF5P0f914mbbnYO3TKwsLZdNtAs6UsTLvnLZX+LwaxBZYFkALxt01ysKJAHN19Bcfv9RguMSJHUtgah/2S+MGqzijOsqgNgWChJ2dNNVUuTX5aOOQrYPYVlLni8Sa8ROSicejpaJfbKf6JIqlXDqjcTqeKLlXlSbr4657ktODmLuQ1tx56kHy5pQxl45YycOrSqscBQwEsu6ejiXS0yjf8eRxxJwV8srLOFTpoHqO6ta/0AXS3WIDpQCvv78BjMuWP768YebW3BKw1OM0Wdb46JMUBtqe/E3jt/NfgJF5WiP4Qy3CaVFrhEdgiJ005KOKmx4yI/s= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ec86988-e7d0-4bab-ef74-08d64ea77228 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2018 05:17:20.0353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4208 Subject: Re: [dpdk-dev] [PATCH] compressdev: add feature flag to specify where processing is done X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 05:17:25 -0000 HI Fiona >-----Original Message----- >From: Fiona Trahe >Sent: 20 November 2018 07:10 >To: dev@dpdk.org >Cc: akhil.goyal@nxp.com; tomaszx.jozwiak@intel.com; Verma, Shally ; Gupta, Ashish >; lee.daly@intel.com; fiona.trahe@intel.com >Subject: [PATCH] compressdev: add feature flag to specify where processing= is done > >External Email > >A new device feature flag, RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE >is added. A PMD which processes operations using a software >acceleration engine should set this if the bulk of the >processing is done during the dequeue. It should leave it >cleared if the bulk of the processing is done during the >enqueue (default). >An application may find this useful for tuning. Help me understand a bit , so how does it work when: 1. PMD do ops processing only at enqueue , will not set this flag? 2. PMD do ops processing only at dequeue, then? 3. PMD can do op processing both at enqueue and dequeue and in such case, = can set this flag to indicate this support? So that app can choose? if supported then app set this feature flag on PMD and PMD take it as a hin= t to know application preference of processing point or PMD always do bulk = processing at chosen point? And why specific to SW PMD, I see HW PMD can do use this feature flag?! Thanks Shally > >Signed-off-by: Fiona Trahe >--- > lib/librte_compressdev/rte_compressdev.c | 2 ++ > lib/librte_compressdev/rte_compressdev.h | 8 ++++++++ > 2 files changed, 10 insertions(+) > >diff --git a/lib/librte_compressdev/rte_compressdev.c b/lib/librte_compres= sdev/rte_compressdev.c >index 10101eb..90d6862 100644 >--- a/lib/librte_compressdev/rte_compressdev.c >+++ b/lib/librte_compressdev/rte_compressdev.c >@@ -66,6 +66,8 @@ rte_compressdev_get_feature_name(uint64_t flag) > return "CPU_AVX512"; > case RTE_COMPDEV_FF_CPU_NEON: > return "CPU_NEON"; >+ case RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE: >+ return "OP_DONE_IN_DEQ"; > default: > return NULL; > } >diff --git a/lib/librte_compressdev/rte_compressdev.h b/lib/librte_compres= sdev/rte_compressdev.h >index 7b68170..0fc8ed1 100644 >--- a/lib/librte_compressdev/rte_compressdev.h >+++ b/lib/librte_compressdev/rte_compressdev.h >@@ -73,6 +73,14 @@ rte_compressdev_capability_get(uint8_t dev_id, > /**< Utilises CPU SIMD AVX512 instructions */ > #define RTE_COMPDEV_FF_CPU_NEON (1ULL << 5) > /**< Utilises CPU NEON instructions */ >+#define RTE_COMPDEV_FF_SW_OP_DONE_IN_DEQUEUE (1ULL << 6) >+/**< Only applicable when RTE_COMPDEV_FF_HW_ACCELERATED flag >+ * is not set. A PMD which processes operations using a software >+ * acceleration engine should set this if the bulk of the >+ * processing is done during the dequeue. It should leave it >+ * cleared if the processing is done during the enqueue (default). >+ * An application may find this useful for tuning. >+ */ > > /** > * Get the name of a compress device feature flag. >-- >2.7.4