From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-eopbgr760058.outbound.protection.outlook.com [40.107.76.58]) by dpdk.org (Postfix) with ESMTP id 6DD381B4FE for ; Sun, 2 Dec 2018 07:39:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rfkWXZLy9vSDbprF37uSQeORs9JYODNX3Kpe6HBzOWw=; b=f87Qy2s0feQkdH1uXEEUzWf+0j8fdveUi3G2aswenpZoIDCXi7pscfnWH+jFYSdVqWcVGViEhALc0u5Up5vjzdpLJIL1wzRkON7qLV4eu3Kszgo3CtHuD0EWJ8tSr/p3BEMiHRxNSS5CHqIYUXj0SECQA3lurnjqhyjOvn+R9Ow= Received: from SN6PR07MB5152.namprd07.prod.outlook.com (52.135.101.33) by SN6PR07MB4527.namprd07.prod.outlook.com (52.135.94.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1382.22; Sun, 2 Dec 2018 06:39:33 +0000 Received: from SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::14c5:1013:408f:49c1]) by SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::14c5:1013:408f:49c1%4]) with mapi id 15.20.1382.020; Sun, 2 Dec 2018 06:39:32 +0000 From: "Verma, Shally" To: "Jozwiak, TomaszX" , "Trahe, Fiona" , "Daly, Lee" CC: "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUZJk28lZzGIoUx06rWRnV5/lDBqUjg5QAgAASrmCAABIcgIAAAIuAgEUD+4CAApxyMA== Date: Sun, 2 Dec 2018 06:39:32 +0000 Message-ID: References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> <348A99DA5F5B7549AA880327E580B4358964F1CB@IRSMSX101.ger.corp.intel.com> <348A99DA5F5B7549AA880327E580B4358964F45C@IRSMSX101.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [223.230.117.124] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB4527; 6:VqyflJwu5daxQXUHvxJgwhHZTs4R9w7GEkwDJvHrZrgaC7pyYTxT5qFQRXZyzXZFTNmu+KgChzAwiOiKsS4js+PZ8W7ZYGWKNHCrtA3EpV7ARY5K6okNqtAf/BYCytJDb18vQ5eI6KyGq+ZWFiiHiMx7bzeoAmzTirpjID8PZtGR2aP3oeaYPfjVv/jTzXti0Qev6J0bTYQW44QZH1No/tdJjHPIVFRGF6KE2QNjXWPHePzxZmwcBLrAPe1gz2x5Wefl0I/Tb4JjT1kGxiHWs1oTzi/Iw6M5BD7vL+tn4RDj3HXkrACn2/htV4W+DdtUB4oy9uiX9zj1q+bKpQS0kZ6+PcqHCliAEDGEzrHSvbDxIrwiHZyQZEuxiEOWscHxtQiivD+slmDV7EdSREDGyZnQSvLUbZnAnW0Pnzpvv6kPuXL0E6ctYF3HX0Fi4u+ZxeF/LYpTqV19aaamd19YcA==; 5:yd6RGp9s7QmkOi5dD4RK8B0Xjj8yzkZwtuJTR2GY7hEVJp6OjWvgSEnbQ8Gsff+dN8M1PjXpchanP9KLrmRR9PU9ZbAYa94kecd/NvtC1FFB3aAna/ROj3Rp9pg/okpbdTMMY052KMGR0F1k7yVBZvV7i+fWWxe+IRIXHujZZdo=; 7:w5SrS4cP3mpwFfPnx8kCnDIhcL8v7batMXkoR6yW6zv/KW30MJ1bT7pgpWWuqxnhF5vhHcqZVUrFDq2oMs8Jc3UbNbRFjBdTcJZuRGL/pNuNKFLzK9/g9aPuKuj82lchXDpfVPzYviqtL5syFHoQCg== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: f361f938-b107-4164-e048-08d65820eb4d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB4527; x-ms-traffictypediagnostic: SN6PR07MB4527: x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(3002001)(3231455)(999002)(944501485)(52105112)(93006095)(93001095)(148016)(149066)(150057)(6041310)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB4527; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB4527; x-forefront-prvs: 087474FBFA x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(366004)(39860400002)(346002)(376002)(136003)(13464003)(199004)(189003)(55674003)(5660300001)(11346002)(66066001)(478600001)(54906003)(76176011)(110136005)(7696005)(446003)(6506007)(99286004)(53546011)(486006)(2906002)(316002)(476003)(14454004)(7736002)(6116002)(8936002)(3846002)(305945005)(74316002)(6436002)(25786009)(105586002)(72206003)(93886005)(81156014)(102836004)(81166006)(106356001)(53936002)(86362001)(6246003)(26005)(186003)(256004)(14444005)(71200400001)(68736007)(97736004)(9686003)(55016002)(229853002)(4326008)(71190400001)(33656002); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB4527; H:SN6PR07MB5152.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8L2YmkFfY/HQMSEgYqweXZdVMTWT7Eeg17IjlUtjESsxojOpLwtTAu8CKCS5F5aY6uVBd49aByeHuK4sLqgJDz38dPsTwxukaGJXa4GygCGFVt6D4e1QGkXeassHdukrRoOnWINsw0W76KBcZpGeoH96l8pmP0COn/GWP3mmdOy5d34jENQfQR1QYRZwkMkVTZRqOOq7+pyK4jnk+PXNwa4XGqc07kDVYLgIa6QqkPEkZ5vKOV09flz0kyECYwApB0+hVPx/Pnt4u9kXoA9zsZiqDN2CUcn1J2cumBMG07+TPveTd78Z+klUVQ0UQwO89A6Z1DanI8W2sTKAdOEJ/XZdcmhAAPHczEQQOorgaYs= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: f361f938-b107-4164-e048-08d65820eb4d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2018 06:39:32.8201 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB4527 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Dec 2018 06:39:36 -0000 Ok. Then to keep it simple can we keep input sz and max-num-segs-sgl at cmd= line input. I don't think segsz is required to input then? Thanks Shally=20 >-----Original Message----- >From: Jozwiak, TomaszX >Sent: 30 November 2018 20:13 >To: Verma, Shally ; Trahe, Fiona ; Daly, Lee >Cc: dev@dpdk.org; akhil.goyal@nxp.com >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance mea= surement > >External Email > >Hi Shally, > >I'm about of sending V5 of compression-perf tool. > >Our performance testing shows that the number of sgls in a chain can be a = factor in the performance. >So we want to keep this on the cmd line for the performance tool. >There are alternatives, like setting the input size and segment size to ge= t the num segments desired, but I prefer >to have the option to specify the num segments explicitly. >We'll document that if the max-num-sgl-segs x seg_sz > input size then seg= ments number in the chain will be lower ( to store all the >data) >As regards adding the max_nb_segments_per_sgl into the rte_compressdev_inf= o struct we're investigating >another workaround to this limitation in QAT, so will leave this off the A= PI unless some other PMD needs it. >In the meantime we'll document the limitation in QAT. > >Please let me know your thoughts. > >-- >Tomek > >> -----Original Message----- >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> Sent: Wednesday, October 17, 2018 6:48 PM >> To: Trahe, Fiona ; Daly, Lee >> Cc: Jozwiak, TomaszX ; dev@dpdk.org; >> akhil.goyal@nxp.com >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >> measurement >> >> >> >> >-----Original Message----- >> >From: Trahe, Fiona >> >Sent: 17 October 2018 22:15 >> >To: Verma, Shally ; Daly, Lee >> > >> >Cc: Jozwiak, TomaszX ; dev@dpdk.org; >> >akhil.goyal@nxp.com; Trahe, Fiona >> >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance >> >measurement >> > >> >External Email >> > >> >> -----Original Message----- >> >> From: Verma, Shally [mailto:Shally.Verma@cavium.com] >> >> Sent: Wednesday, October 17, 2018 8:43 AM >> >> To: Trahe, Fiona ; Daly, Lee >> >> >> >> Cc: Jozwiak, TomaszX ; dev@dpdk.org; >> >> akhil.goyal@nxp.com >> >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add >> >> performance measurement >> >> >> >> >> >> >> >> >-----Original Message----- >> >> >From: Trahe, Fiona >> >> >Sent: 17 October 2018 20:04 >> >> >To: Daly, Lee ; Verma, Shally >> >> > >> >> >Cc: Jozwiak, TomaszX ; dev@dpdk.org; >> >> >akhil.goyal@nxp.com; Trahe, Fiona >> >> >> >> >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add >> >> >performance measurement >> >> > >> >> >External Email >> >> > >> >> >Hi Shally, Lee, >> >> > >> >> >> -----Original Message----- >> >> >> From: Daly, Lee >> >> >> Sent: Monday, October 15, 2018 8:10 AM >> >> >> To: Verma, Shally >> >> >> Cc: Jozwiak, TomaszX ; dev@dpdk.org; >> >> >> Trahe, Fiona ; akhil.goyal@nxp.com >> >> >> Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add >> >> >> performance measurement >> >> >> >> >> >> Thanks for your input Shally see comments below. >> >> >> >> >> >> >> >> >> I will be reviewing these changes while Tomasz is out this week. >> >> >> >> >> >> > -----Original Message----- >> >> >> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Verma, >> >> >> > Shally >> >> >> > Sent: Friday, October 12, 2018 11:16 AM >> >> >> > To: Jozwiak, TomaszX ; >> dev@dpdk.org; >> >> >> > Trahe, Fiona ; akhil.goyal@nxp.com; De >> >> >> > Lara Guarch, Pablo >> >> >> > Cc: De@dpdk.org; Lara@dpdk.org; Guarch@dpdk.org >> >> >> > Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add >> >> >> > performance measurement >> >> >> > >> >> >/// >> >> > >> >> >> >Also, why do we need --max-num- >> >> >> > sgl-segs as an input option from user? Shouldn't input_sz and >> >> >> >seg_sz internally decide on num-segs? >> >> >> > Or is it added to serve some other different purpose? >> >> >> Will have to get back to you on this one, seems illogical to get >> >> >> this input from user, But I will have to do further investigation = to find if >> there was a different purpose. >> >> > >> >> >[Fiona] Some PMDs have a limit on how many links can be in an sgl >> >> >chain, e.g. in QAT case the PMD allocates a pool of internal >> >> >structures of a suitable size during device initialisation, this is = not a hard >> limit but can be configured in .config to give the user control over the >> memory resources allocated. >> >> >This perf-tool max-num-sgl-segs is so the user can pick a value <=3D >> whatever the PMD's max is. >> >> >> >> Then also, I believe this could be taken care internally by an app. >> >> App can choose convenient number of sgl segs as per PMD capability >> >> and input sz and chunk sz selected by user. >> >> Just my thoughts. >> >[Fiona] Then we'd need to add this capability to the API, e.g. add >> >uint16_t max_nb_segments_per_sgl into the rte_compressdev_info struct. >> >Special case 0 means no limit. >> >We did consider this before, I can't remember why we didn't do it, I th= ink >> it's needed. >> >I'll push an API patch for this in 19.02 and we can remove the >> >--max-num-sgl-segs param from the performance tool and hardcode it in >> the tool in the meantime. >> >Ok? >> Yea. Sounds better.