From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-eopbgr810057.outbound.protection.outlook.com [40.107.81.57]) by dpdk.org (Postfix) with ESMTP id 1FD522BA1 for ; Thu, 15 Nov 2018 09:34:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+6VnDHpU5Civdn5feorsFCqq6ltAcjeGo501KvxAFTI=; b=K/ISIE8/fCgJRW/M8H6wn/xCVltB4N9M4BXUz+Eexe50Ke9rv1e7ZPFGYX+LfAOCuApkDTlvM88W0vM0U01u1pT6LSJjf1WSfDiUy4MvgOyUkloNf4uQyDkQ9n7iNQen1B15qiey5nmNFVrxPmlE8by5w0MYcrIu7CgvDlNCuD0= Received: from SN6PR07MB5152.namprd07.prod.outlook.com (52.135.101.33) by SN6PR07MB5101.namprd07.prod.outlook.com (52.135.101.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.30; Thu, 15 Nov 2018 08:33:59 +0000 Received: from SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::49cb:b2a:974:2211]) by SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::49cb:b2a:974:2211%4]) with mapi id 15.20.1294.045; Thu, 15 Nov 2018 08:33:58 +0000 From: "Verma, Shally" To: "Mcnamara, John" , "Sahu, Sunila" CC: "dev@dpdk.org" , "Athreya, Narayana Prasad" , "Murthy, Nidadavolu" , "Gupta, Ashish" , "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op Thread-Index: AQHUfCtZEHbsNWqzIUiN5Oima3rfbaVQgxtA Date: Thu, 15 Nov 2018 08:33:58 +0000 Message-ID: References: <1532357165-8575-1-git-send-email-shally.verma@caviumnetworks.com> <1532357165-8575-2-git-send-email-shally.verma@caviumnetworks.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB5101; 6:2hUWGTmQgEKUXoS2W3IQWBWzT77lcxA3MjoKDpeUQnAqSgaWHKZGL96mSPt6ADex9wOdQgffNpyu2MAB9nqKAS0F4yp2QlOc/50Ip82gVW45/UwawTsI+OjSwPeOYA4hm1u3hNL7vaw5gy44Eu3D5bygbDFygz0h1nvaL31jKnlxGqF5eMqKDywvWdz1iOWaib7hPu4PipE5C0qGS4fggpe588GpU6fwIEapiKBJXyhidhycuJsPLinmeB/oRSBAck7JzOMAN3aS8p+GXRcdozUCAVDFh2yoEq9gKUF62B9OreeQjs9SWKEtgx8DgWatBfrf/F3Ls+K61vZ8QfbaVKWYem4MX/qdj0JuBmafn3T+E5WwloazSRx/NB2cQ085xBb21Ox4QU75YkpF+AotV7g9GJTauls4JeEgH1Z3XAzDkzUOnzB2UU5G20Pu3xtBIuFlFEYCpESgNjk0GL6wzQ==; 5:BRpsykgNNOEivlLdcQM1LqJ9j9Uf6lmDeay1iSsAvMU1YNjqrReP3DjMT7CMvgztBGqhDSWCGY4gzY9xRnVDaLnkFBtUdBFBi0n8qzA4xiQg7+/oSUh5C3Yjt3Y35rpVUGorcoNJ/P865v/ciIl1RG9KVxVhHfeuOROWglOc43Q=; 7:1XnwRyuB9ur+emHnuN6MwXQkVpcNG6XiezhFP/aN0ZQkGnYym/79TJk9Gdd0KyMy1WA6ZjohUhd5Lb5m51S5i4SjVyY8jhthC42z99DrMVyZ7BUKNsI7G/upEW1DyfTCR+cjBFapK7iwQkNaycEj3w== x-ms-exchange-antispam-srfa-diagnostics: SOS;SOR; x-forefront-antispam-report: SFV:SKI; SCL:-1; SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(136003)(39860400002)(366004)(199004)(189003)(13464003)(186003)(26005)(4326008)(8936002)(6436002)(86362001)(71200400001)(229853002)(74316002)(71190400001)(305945005)(256004)(2900100001)(5660300001)(7736002)(486006)(446003)(11346002)(97736004)(68736007)(476003)(6636002)(33656002)(72206003)(478600001)(966005)(102836004)(66066001)(55236004)(6116002)(3846002)(7696005)(76176011)(6506007)(25786009)(14454004)(6306002)(316002)(9686003)(105586002)(8676002)(55016002)(53936002)(54906003)(81156014)(81166006)(6246003)(2906002)(110136005)(106356001)(99286004); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5101; H:SN6PR07MB5152.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-office365-filtering-correlation-id: 34e61ec1-b3bf-4361-f365-08d64ad5166d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5101; x-ms-traffictypediagnostic: SN6PR07MB5101: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(36789356921836)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231415)(944501410)(52105112)(148016)(149066)(150057)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB5101; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5101; x-forefront-prvs: 08572BD77F received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: ha/89p0u2dmZNS1UnD1k+fLh4p+I7VLzh3bGXLsYeDEt6KKOidg36velfigttyXUjMPlj7hhZPgyabVUqElhBnc0IO/LpHxvwO6clAWAJkf4y0MztAifMI8URZD3pbKg0G0eMdaX0vGlgv78eeNAdng4S6FlAFSwMLX58+fTvrI5FagGkSGBmMQlrOziDkB0IgFqMEzqSiSGbhOaqD9XdfHWUVM5JACVEzDX8hRfg9I5Hl8B0k8LXeZHv6/MvcCE1ZRkx3drYQLasugPdTljTMREVcJY6JaahlWZXj/oyMWPsgzoCbBCy8GavIOUNJsCSG+WBaj3ZZBMuCwbRVpT/NODo8M6VbYyNrFa8gd70wo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e61ec1-b3bf-4361-f365-08d64ad5166d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2018 08:33:58.3116 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5101 Subject: Re: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asym op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Nov 2018 08:34:01 -0000 >-----Original Message----- >From: Mcnamara, John >Sent: 14 November 2018 20:35 >To: Sahu, Sunila >Cc: dev@dpdk.org; Athreya, Narayana Prasad ; Murthy, Nidadavolu >; Gupta, Ashish ; D= e Lara Guarch, Pablo >; Verma, Shally >Subject: RE: [dpdk-dev] [PATCH v5 1/3] crypto/openssl: add rsa and mod asy= m op > >External Email > >> +err_rsa: >> + if (n) >> + BN_free(n); >> + if (e) >> + BN_free(e); >> + if (d) >> + BN_free(d); >> + if (p) >> + BN_free(p); >> + if (q) >> + BN_free(q); >> + if (dmp1) >> + BN_free(dmp1); >> + if (dmq1) >> + BN_free(dmq1); >> + if (iqmp) >> + BN_free(iqmp); >> + > >Hi, > >I don't think the if() test is required prior to calling BN_free(). > >The docs say: "If a is NULL, nothing is done.": > > https://www.openssl.org/docs/manmaster/man3/BN_free.html Ok. will see and get back to you. Would like to test with different openssl= versions, if all follow same rule no issues. Thanks Shally > >I mention this because the code above is also in Coverity defect 305854. > >Could you look at that and provide a fix. > >Thanks. > >John > >