From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-eopbgr790079.outbound.protection.outlook.com [40.107.79.79]) by dpdk.org (Postfix) with ESMTP id F333D201 for ; Mon, 12 Nov 2018 05:45:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hzB+6EoYLQcO5fWGNG0Y9mJqW+Ec/ndzAx/SNuzcX+Y=; b=nswFiV1L2J0WNNvcjg/vnPWEue7KcRG8Xd8IGZlXiegfETfS8OIq4PfhzgvSArkh9uyn1hB34L3rJmo4DHkS+KoGtLSF/0bR63QtekOS43THAGN384Fn1Kii8Hqf9Kj0LAB5uyj1MjGRbbe7CK72HjniGcXRj1uv+9bVk+yBW5c= Received: from SN6PR07MB5152.namprd07.prod.outlook.com (52.135.101.33) by SN6PR07MB5726.namprd07.prod.outlook.com (20.177.251.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.30; Mon, 12 Nov 2018 04:45:26 +0000 Received: from SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::49cb:b2a:974:2211]) by SN6PR07MB5152.namprd07.prod.outlook.com ([fe80::49cb:b2a:974:2211%4]) with mapi id 15.20.1294.044; Mon, 12 Nov 2018 04:45:26 +0000 From: "Verma, Shally" To: "Trahe, Fiona" , "Jozwiak, TomaszX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement Thread-Index: AQHUWYqjhLJt3XAtpkeXnW8WfRqeNaUVmp7AgCbXsACABJ3+AIABizAAgAACQCCAAA8JAIAAbY0ggAE5IwCABBlQAIADYlIA Date: Mon, 12 Nov 2018 04:45:26 +0000 Message-ID: References: <1538400427-20164-1-git-send-email-tomaszx.jozwiak@intel.com> <1538400427-20164-3-git-send-email-tomaszx.jozwiak@intel.com> <348A99DA5F5B7549AA880327E580B435896741A1@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B435896741A1@IRSMSX101.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Shally.Verma@cavium.com; x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; SN6PR07MB5726; 6:CekB5V86URRHyXCNVn7IRRf51XaSkYVd3/Mo0POH7F3Tnjw/SELphfYk0JirnzvYnoegyyIGRsuUOT7uDFLuUEflc/DCP2RNH2UHQ/OqsidMJxZ3ws1urlGON9VdpEMZbWm5OH8S8taIKKfp8DN6am8p1uesuzuZpTWv0agHymELwd5GDZGvBfZeW5RT/Hg2N8UENzQvqtusrwxXjq9NTmX+pcX1S5fa1FV+1A1OVi3x67TKtGdqiuIMrCfEiylRCQfkgVP4Upj15e1LwaQyV18fP3D+EcuzpnY9F83uZ4hWjv0bz1q1KYKXxsJtYp4NuAnw6VddaVZvyK3STk9UvvsBQ+RDpxDnmbAn/GfCypKokjsNxFn5TosUfZCP4Le9XV4S0RFOOK/Eaq9/xCMm59h258wkW1CXF/gLaXlVNq/qLMQmym282upoCjzTkqGVDH8cWR5yhxk7DCPB4DR5ZA==; 5:aVElHZmzrJ5ZUHjzjfzADzIFo2cjfInYpm6NPKOcEWDe8WIbACpDa+WQJjT699LqzrfVnaEkMW3iywulzDWbxSjmWccO4iIOpVuvhDb0yybU2zJg4jKqMIK76aSxXUkm7rbJSdAj2o9WTg5rMTl26+UJgG730pGNh1zX3bQhYO4=; 7:VSinJ9PcDWmHuRn2bBBGEScm/JSwUqaPAJRHHnabfrOb+0f50O+hJLSrM/IsqtjKZ4zimC21482K7J7kVr1tAm3b+Rg1DCEJY/3MhmotoQGNRMlVHcvJq/kGTekmv652zOOKg0k0F9eJZzbu2jZmQQ== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 9ba56618-91ba-4d2a-5b0a-08d64859aa5a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390040)(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020); SRVR:SN6PR07MB5726; x-ms-traffictypediagnostic: SN6PR07MB5726: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(228905959029699); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(3231402)(944501410)(52105112)(93006095)(93001095)(10201501046)(148016)(149066)(150057)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:SN6PR07MB5726; BCL:0; PCL:0; RULEID:; SRVR:SN6PR07MB5726; x-forefront-prvs: 0854128AF0 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(136003)(396003)(346002)(366004)(376002)(199004)(189003)(13464003)(68736007)(6116002)(55236004)(66066001)(2501003)(86362001)(229853002)(2900100001)(105586002)(186003)(102836004)(106356001)(6506007)(256004)(71190400001)(14454004)(14444005)(446003)(486006)(3846002)(76176011)(97736004)(11346002)(5660300001)(2906002)(26005)(71200400001)(476003)(2201001)(305945005)(25786009)(316002)(93886005)(8936002)(55016002)(33656002)(110136005)(81156014)(478600001)(81166006)(99286004)(6246003)(7696005)(74316002)(53936002)(561944003)(6436002)(7736002)(9686003)(72206003); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR07MB5726; H:SN6PR07MB5152.namprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: MMLLDgHLRNADAhJ0w//dBAA1T+5zrirTa+lPujXEMbI5px0ixHJ44BjVOGjG+6i40J5uZ2W7mC78AWiKqfqsbyTob5bnjqPetrSLnK/Trf3z+EcrMtajomtqlg674dPZH33r3EhRWc9EUE092TBMUxEtEkIZlwAsMk9QRYyoYClYmXo/8Wy0SG08kMw3ls0NDDF4HPohM+VnR2w/whk7tux+yMadmsjMTwkQOBCdnkn/qeIMcX+fju09dg+RoHLn8HLf6M2sHlBZTFer5QO7Xk2H2B8P/JcSmKot+PG80NMBTdBSuBu03cFEeGlHzqHKsm5dK88mZc0CajYaevJCoNvxYoNvGzXLZAhIXP62cC4= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba56618-91ba-4d2a-5b0a-08d64859aa5a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2018 04:45:26.5450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR07MB5726 Subject: Re: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance measurement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 04:45:29 -0000 >-----Original Message----- >From: Trahe, Fiona >Sent: 10 November 2018 06:24 >To: Jozwiak, TomaszX ; Verma, Shally ; dev@dpdk.org; >akhil.goyal@nxp.com >Cc: Trahe, Fiona >Subject: RE: [dpdk-dev] [PATCH 2/3] app/compress-perf: add performance mea= surement > >External Email > >Hi Shally, Tomasz, > >> > >> >> >> >+ /* Window size */ >> > >> >> >> >+ if (test_data->window_sz !=3D -1) { >> > >> >> >> >+ if (param_range_check(test_data->window_sz, >> > >> >> >> >+ &cap->window_size) >> > >> >> >> What if cap->window_size is 0 i.e. implementation default? >> > >> >> > >> > >> >> >TJ: You probably mean cap->window_size.increment =3D 0 (because >> > >> >> >cap->window_size is a structure). In that case we check if >> > >> >> >test_data->window_sz >=3Dmin and test_data->window_sz <=3D max >> > only, >> > >> >> because increment =3D 0 means (base on compression API) we have = only >> > >> >> one value of windows_size (no range is supported). >> > >> >> But PMD can set min and max too 0 for such case. >> > >> > >> > >> >TJ: I can't see any issue in that case too. Maybe I don't understa= nd >> > >> >what you >> > >> mean but the logic is as follow: >> > >> >1) if you pass '--window-sz ...' param. into command line your >> > >> >intention is to force that value of window size during test. We >> > >> >check is this >> > >> value is allow (by param_range_check() function). >> > >> >2) if you plan to use default value - just don't pass '--window-sz= ' >> > >> >param. in command line at all. In that case we get windows size fr= om >> > >> >window_size.max field, so if window_size.min=3D window_size.max=3D= 0 >> > >> test_data->window_sz will be zero, as well. >> > >> >If you mean that behavior is not good - I will be grateful for oth= er >> > >> suggestions. >> > >> >> > >> This is fine. but I am thinking of 3rd case here: >> > >> c) user pass window sz but PMD window_sz.min =3D max =3D 0, then us= er >> > >> requested windowsz is not applicable right?! >> > > >> > >In that case - true. There'll be fail : >> > >"Compress device does not support this window size\n"); So what is yo= ur >> > >proposal for that case? >> > > >> > We can set to window size to implementation default and add in diagnos= tic >> > of used window sz for test run. >> > No need to fail here I believe. > >[Fiona] For Window size capability reported by the PMD in the info struct >it is not valid to report min=3D0, max=3D0. The PMD must report the range = it can >handle - the API doesn't suggest otherwise. >On the xform a specific window size is requested of the PMD, if it doesn't= support >this it's allowed to fall back to a lower size according to the API. >However that doesn't mean the PMD can pick any size if it doesn't support = the >requested size, i.e. it can't pick a bigger size, just a smaller one. >If an application requests a smaller window size >than a PMD supports, it can be that the decompression engine >will be unable to decompress if a larger window is used, so the PMD >should only fall back to a smaller size. >Based on above, I think the perf tool behaviour is ok. >It should pass the user requested value to the PMD if the PMD capabilities= support it. Agree to this. However my point is what if PMD just leave these window sz v= alues as 0, meaning implementation default i.e. internally used fixed value used by PMD to lookup for both compression/deco= mpression. But if we are not supporting window sz =3D 0 on an API then its= fine , no need to handle this special case. However given that, we need to= add comment in capability field, PMD must set it to some non-zero value an= d 0 is not valid case to handle. >If not it should fail. If the user wants to measure with a different windo= w size they can >pass in that parameter. >The functional test suite can be used to validate the case where the PMD >falls back - this is not what the perf tool is for. >Does this make sense? > >@Shally, do you think we need an API change to support an unlimited set of= window sizes? >If so can you explain why? No.I don't intend to add support something like unlimited window sz as that= isn't a known use-case. Also, I didn't mean window sz =3D 0 to be interpr= eted as unlimited window sz. I just meant 0 =3D implementation default wind= ow sz , if that's supported on compression spec.=20 Thanks Shally >