From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 82ECAA0597; Thu, 9 Apr 2020 15:00:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DD2F81C20D; Thu, 9 Apr 2020 15:00:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id D80701C204 for ; Thu, 9 Apr 2020 15:00:49 +0200 (CEST) IronPort-SDR: CCTiSRYQYA5NWwBjo5IeRzLcTRSlsjhpgTGldDTY2H7UZ78Hkui3ieL9j5/SfIoeWFQer2XW4c jU9iMKHse6XA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2020 06:00:47 -0700 IronPort-SDR: VeHzLD9SlQDk6wL6NxG+nQrOetsboa6zn4dGgR6fjMWg3JDW1yZ16Y+0Bu8lBXEES6APD6QaWB K030tQs0T0eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,362,1580803200"; d="scan'208";a="240615508" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 09 Apr 2020 06:00:47 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 06:00:47 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 9 Apr 2020 06:00:46 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 9 Apr 2020 06:00:46 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.52) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Apr 2020 06:00:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DkEGaUAxtY1+ntRDH5xVkwNIQp84+fDGvVheTsjtN0Zvvr+CvSfNj48NHksi0lNJh4e0OvFcpSYWRO9X3WF6KRDNcRekk9mhu6vAWDFDHODraCWUqluFKWLaTyy7aUY8lMKwK/LveGBPEpoA25aAbdT+DxZBxeaXo8Gy1kRw278cnU44LqChhxPVdlu3BPgk4JwTWz0AQQE0EnJ5SXoizHsietRA5e/pIojLIEe/veW/zWVLWlNLJxNWzQCXf9VcAI+T00IvsOOtCh7cbUMptbdLSf+Qn+lGcQzuUNpiQlDg59I9IdWM/unpc2cbEkRQzf00TROrLq+U1YcKDklqeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OAJC+CJITfoSMZCA2JNatHaUC5TE1WNh+Oxn+K5WPA=; b=fw3PC5XPnk15FFsK8RfOv5335HqegHq83+5XbP+yVdH+0xLuMahJWXZKJ4Fb9szpSfgtf8Y3iHC9l2IRx0vCXafIfRR4Z0LjNF4M16a3oBLWEuWxLsR1FJJm9KwhdMPBYC0szgojVGDrMfHTylcqix0WG40YxLUh1e7tD0fUT1utjeAiuowTEvBlyZH90O0i19kXB3g1ZwA0rrjWDMQJimLzaD8PvynlEIv+fcv4y5Qhz6brLWxUMMi3bye7xgW8fTH6ZivmE7y9vhuxETRSL5mc27DGTlAN9OQTJNDeptuesLKJFoc1xiw3YR6sC/rG8xKzCJEllScDSt5Zt95qXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OAJC+CJITfoSMZCA2JNatHaUC5TE1WNh+Oxn+K5WPA=; b=ftk9k7ljHDxPNUw43e00BBq1ETUxfURgqqxUbMVL5whzU2x89eqhr71+eA7/qER+2g0zM3IVwLW9LKtMBK1GwNhQRsKeAFs9rWGy8QEnCZmTvvLUnu3tHLjnciOJP4dthT/jii5Rh/tXdxJLREoKZtsKOMfszOL7PHovNpiJ7uw= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (2603:10b6:805:5d::19) by SN6PR11MB2846.namprd11.prod.outlook.com (2603:10b6:805:5b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.19; Thu, 9 Apr 2020 13:00:44 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::3982:ee47:b95a:4ed4]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::3982:ee47:b95a:4ed4%3]) with mapi id 15.20.2900.015; Thu, 9 Apr 2020 13:00:44 +0000 From: "Ananyev, Konstantin" To: "Ananyev, Konstantin" , Honnappa Nagarahalli , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "jielong.zjl@antfin.com" , nd , nd Thread-Topic: [PATCH v3 1/9] test/ring: add contention stress test Thread-Index: AQHWCd9oRLg1U6SQzEmd0VvXgtS5hahusT2AgAIM4GCAAAmIIA== Date: Thu, 9 Apr 2020 13:00:44 +0000 Message-ID: References: <20200402220959.29885-1-konstantin.ananyev@intel.com> <20200403174235.23308-1-konstantin.ananyev@intel.com> <20200403174235.23308-2-konstantin.ananyev@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.161] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b37f956-fe1c-4823-182d-08d7dc860416 x-ms-traffictypediagnostic: SN6PR11MB2846: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0368E78B5B x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2558.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(366004)(396003)(39860400002)(376002)(136003)(8676002)(110136005)(9686003)(54906003)(66556008)(186003)(4326008)(33656002)(26005)(7696005)(6506007)(316002)(81156014)(71200400001)(52536014)(8936002)(76116006)(2906002)(66446008)(55016002)(66476007)(5660300002)(86362001)(478600001)(81166007)(66946007)(64756008)(2940100002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /901FMujTaAyBZ7Ie1uvhyZa9pStxradLVKWshuWpLIpVb6cYtvESQqsFqN7cSXQ8nImz4fA8IlX/ExCNebjwYNZDl9XFBz65IS08sVcIdWgDkFVq6PZdwYLOrtZE+7MFoXsgUgfBdAfdZfNT840xKFHl5HiIk06VWHwLs03z6XBTChsP/angwVlliroQIPx4v6kv8eWbIaJRumQYin4MY/t+EjMXBHrzh8PGJs1BSZQxVf3rZW7kLKNr8F7+xv1Qbo9rqIVZ0e+gdljS5bR/o9YdLC2cKu/zHXg4y9dLBAHHBPPvjXmxaXp/uPJ0eK1N8WQH9paXVHxkDE13g4e8cKOk8W48vkP8bBuBWmGl7zJhqDUUeiuz3gwDaoXY0xHrDv8ziQmesJeyKBouv+fhySgfzxraKtKR/NCh3R5xleQKVd3by3I4avcoUw3/1SA x-ms-exchange-antispam-messagedata: faB1eSrTAB2NxQwrb7XRThwL4kHjqZgOigeNpYdap1g9ptMp2YY63zB/vTvbMLq6MdCODkM8HYjxZRM69cE+N20K05OsfdGMxl6sjkhM1gX/UiSfZTdsj3ujsrqX4HYZWQ7pcVOy0EDhLXAlllc9dQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 6b37f956-fe1c-4823-182d-08d7dc860416 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2020 13:00:44.6770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: klRowBmjR1Q6kOLQVvmZR+olCFn8upTs4veREpHYLYW8cyFZ3SBcVuA5g6ljFWYGYGDj847jBYKyIkMlqGppl5oTbRwObFcaReEYjA8+L/0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2846 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/9] test/ring: add contention stress test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > +static int > > > +test_worker_prcs(void *arg) > > > +{ > > > + int32_t rc; > > > + uint32_t lc, n, num; > > minor, lcore instead of lc would be better > > > > > + uint64_t cl, tm0, tm1; > > > + struct lcore_arg *la; > > > + struct ring_elem def_elm, loc_elm; > > > + struct ring_elem *obj[2 * BULK_NUM]; > > > + > > > + la =3D arg; > > > + lc =3D rte_lcore_id(); > > > + > > > + fill_ring_elm(&def_elm, UINT32_MAX); > > > + fill_ring_elm(&loc_elm, lc); > > > + > > > + while (wrk_cmd !=3D WRK_CMD_RUN) { > > > + rte_smp_rmb(); > > > + rte_pause(); > > > + } > > > + > > > + cl =3D rte_rdtsc_precise(); > > > + > > > + do { > > > + /* num in interval [7/8, 11/8] of BULK_NUM */ > > > + num =3D 7 * BULK_NUM / 8 + rte_rand() % (BULK_NUM / 2); > > > + > > > + /* reset all pointer values */ > > > + memset(obj, 0, sizeof(obj)); > > > + > > > + /* dequeue num elems */ > > > + tm0 =3D rte_rdtsc_precise(); > > > + n =3D _st_ring_dequeue_bulk(la->rng, (void **)obj, num, NULL); > > > + tm0 =3D rte_rdtsc_precise() - tm0; > > > + > > > + /* check return value and objects */ > > > + rc =3D check_ring_op(num, n, lc, __func__, > > > + RTE_STR(_st_ring_dequeue_bulk)); > > > + if (rc =3D=3D 0) > > > + rc =3D check_updt_elem(obj, num, &def_elm, > > > &loc_elm); > > > + if (rc !=3D 0) > > > + break; > > Since this seems like a performance test, should we skip validating the= objects? I think it is good to have test doing validation too. It shouldn't affect measurements, but brings extra confidentiality that our ring implementation works properly and doesn't introduce=20 any races.=20 > > Did these tests run on Travis CI? AFAIK, no but people can still run it manually. >> I believe Travis CI has trouble running stress/performance tests if they= take too much time. > > The RTS and HTS tests should be added to functional tests. Ok, I'll try to add some extra functional tests in v4.=20