From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEDD1A0567; Tue, 10 Mar 2020 14:24:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1D6D81BF96; Tue, 10 Mar 2020 14:24:19 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 99AD41BF96 for ; Tue, 10 Mar 2020 14:24:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 06:24:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,537,1574150400"; d="scan'208";a="234346100" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga007.fm.intel.com with ESMTP; 10 Mar 2020 06:24:15 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Mar 2020 06:24:14 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Mar 2020 06:24:14 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 10 Mar 2020 06:24:14 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Mar 2020 06:24:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KnzlseuAIjIbkrylJPJd0PAEctcNcP7ora23t3ISW8DFHa/9YkWimf43ilLXq3w6G7dVvGcwKUtRzGkWyYNNm6tqDlvumA1Gt2liLY6sylEpCvOV+/y2jk8EUXoJYHo1gq/OA7TqeHe7cDF7N/fhZB1ZcNLSjensL7f13eJC0ZliKTMF3awcQPSCWJ2UW9UkMEGftodKKamZuWxf9lnQPKdMVn8xwrjUi291raLWqoEeSJPOVZGwxLOcBMVDh6NGrgdd2/Ur7FEbrTjABs+y9VpVg9FIs22cLawVHDNP702Ttq5k4J+5twwg4NyefAd3uFEEbjGZVrv4qF4G9dDOWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Szuj+NXwnZOnB2I+5mYu53yC5sxLdDG1WMGSavXdq1M=; b=CFpA4y0+nLAo+omzzBwrakplRhrpx2LsdQt9UrfnxyRFCnZHLEnkEwlZo8Rr5WQ1rYkUGqFjzRWsV/hjpSqCZIeTxy0+j9ZRCC7KGOILfLn5AG0CWCj6XHVK8JkaaLGyzUerWzen2IZYqMJZlZKwHz3W+8nfdnim2aPXRiBTSkaeVrZywO9GIf2FrL2S03fWfGwOdFZlv+Cp7spU3w8HIvAhdYhlCNP5GyE5AF1a8VeU8Q5xNxpACFNY3RPDr5AAdu1bWr+GGZYjjwTwsXxbMtDj9QX+xVMWeV92KY+4MRkvL2FU1ObG3LmE1CMLs7/u409eItDxljxu0nvjrw4uLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Szuj+NXwnZOnB2I+5mYu53yC5sxLdDG1WMGSavXdq1M=; b=kKwdiTJ4j+qz+vBjM39MywjUSyj3Lq6S0+s4cthiFs+aNtatlwiedVnXGZST8w6GArTEnJcaH+SNpH918fASoOr5wVuD+PFJiwKHgHuhxDF2KenN2+RaoUp84lgLvRWCe94h8LODczX7jMI37s0Qv0eqK9z2dNdFWD5Nqztl4uY= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (2603:10b6:805:5d::19) by SN6PR11MB2893.namprd11.prod.outlook.com (2603:10b6:805:dc::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16; Tue, 10 Mar 2020 13:24:11 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::395e:eb75:6ab7:2ba5]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::395e:eb75:6ab7:2ba5%3]) with mapi id 15.20.2793.013; Tue, 10 Mar 2020 13:24:11 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon CC: "Dharmappa, Savinay" , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "Iremonger, Bernard" , "Medvedkin, Vladimir" Thread-Topic: [dpdk-dev] [PATCH v3] app: test: measure libipsec performance Thread-Index: AQHV8r3yF8PlFyniRUCaa+zl1lyHCag54MsQgABcDwCAAF2+oIAAqs6AgAaSIPA= Date: Tue, 10 Mar 2020 13:24:11 +0000 Message-ID: References: <20200302114319.3886-1-savinay.dharmappa@intel.com> <2820277.687JKscXgg@xps> <2628800.AiC22s8V5E@xps> In-Reply-To: <2628800.AiC22s8V5E@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWZhYWUwZGYtYzQxYS00YWQwLWEyZTEtYjM2ODNiNzg5OGI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoidGozUjFtZUErc09FOUtsSExRRWlxQ0hcL2dJS2w0ZExuVWlFRmxUSUZHTVpXRUF0NUhLM3FqN1BOa1dUcnJaSGsifQ== dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87a0ebce-5be0-4e3f-8016-08d7c4f6522c x-ms-traffictypediagnostic: SN6PR11MB2893: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 033857D0BD x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(136003)(39860400002)(366004)(189003)(199004)(66446008)(66946007)(2906002)(81156014)(8936002)(76116006)(33656002)(8676002)(478600001)(86362001)(81166006)(66476007)(66556008)(71200400001)(55016002)(64756008)(107886003)(9686003)(186003)(316002)(7696005)(6506007)(26005)(6916009)(4326008)(5660300002)(52536014)(54906003); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2893; H:SN6PR11MB2558.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5J4Qh2u30oph6s/u9ZVEVFW2AdfiEDUIuGQWIY59nxwrTxZBcLjmLJhPgr8dESSm0XXgm+g8flBC8icW887wkYkbb0nimlgJcSW0mn9IoPXZpBOHQzSHHs3/QczRh519TNzlLsNfc3LZQsq/UphtAaj4q6ztzNt/PGnEvVaKfDvpLS50rHoyXzjDzmUkuH71CEOmS0xL4R3nwxtdzzqMA/GOzsU3f63bL6iHeJrlx63jfHi1ziRp1Egkz825cL2XQ1rujF6wuSogmQivblePA1lF2v4G9jVYQ+0jPoUc3ue4ZAq3azdoUVVx13De73vEYyxDYAkPZHau4VpwYpo773G8YJBs/Pjc+qKyzmBovhn2SHTznGkfW0iS0pcb0iMjWhqGP+4zz8bfbEu4xAI/0ym5XWwmtiEnyJwmQ9uvGL80Es5ps34n8BNz3qr+c7+p x-ms-exchange-antispam-messagedata: EriyFb0JD6JPo4BRVHMfeUS8vnSKpsYZ/IVjC0Wyx4eZgaYxQ0pHPE3EOtJOTmF1iIrDnN+ruzLywct5UxgWN0tD5C/Sutw7v65C+0dHEQHO5/BGBEvgx4543lSTCfwJ79BoOLvv2VEoDmr1eoRKcw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 87a0ebce-5be0-4e3f-8016-08d7c4f6522c X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2020 13:24:11.4572 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7F+JnH3DNoPfr3xsJh3/GW51my7z1AvZU2KfHyhHhlxnYyrqvD5XhYfrYxn+xd2Lb4BuqTif530qbYj9SLIcX4JmA7lCQ8rPvQ02S1BiM0s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2893 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] app: test: measure libipsec performance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 05/03/2020 23:51, Ananyev, Konstantin: > > > > > 05/03/2020 12:45, Ananyev, Konstantin: > > > > I think the header need to be "app/test", or "test/ipsec". > > > > > > It should be "test/ipsec" as it is an IPsec test command > > > in the test application. > > > > > > > Apart from that: > > > > Acked-by: Konstantin Ananyev > > > > > > I wonder why we have a different maintainer for each IPsec test. > > > It looks a bit confusing. > > > > > > IPsec - EXPERIMENTAL > > > M: Konstantin Ananyev > > > T: git://dpdk.org/next/dpdk-next-crypto > > > F: lib/librte_ipsec/ > > > M: Bernard Iremonger > > > F: app/test/test_ipsec.c > > > F: doc/guides/prog_guide/ipsec_lib.rst > > > M: Savinay Dharmappa > > > F: app/test/test_ipsec_perf.c > > > M: Vladimir Medvedkin > > > F: app/test/test_ipsec_sad.c > > > F: app/test-sad/ > > > > I suppose mainly by historical reasons - > > each of these tests have different authors. > > Obviously each author claimed maintanership of his own code. > > Do you consider that as a problem? >=20 > Yes I consider a maintainer should know a whole area > and be the point of contact for this area. > For instance, when there is a bug with a test, > we don't know whether the problem is in the test or in the library. But same problem could appear with any test/sample app. Let say you have a problem with testpmd. Is that testpmd itself, rte_ethdev or particular PMD? Obviously some preliminary investigation is needed before finger pointing. I don't see why having multiple persons as maintainers for the same area is a problem. In fact, it probably gives more chances for faster turnover (as long as they do their maintainer job properly). >=20 > Note that the original author can be found with the git history. >=20 > > > In general, only one person takes the responsibility to be > > > the main contact of any related question in the area. > > > > > > So the file pattern could be: > > > F: app/test/test_ipsec* >=20 >=20