From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EB07A0524; Fri, 31 Jan 2020 00:49:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EB6D1C035; Fri, 31 Jan 2020 00:49:22 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E47BF1C033 for <dev@dpdk.org>; Fri, 31 Jan 2020 00:49:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 15:49:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,383,1574150400"; d="scan'208";a="224280780" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 30 Jan 2020 15:49:16 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jan 2020 15:49:15 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 30 Jan 2020 15:49:15 -0800 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 30 Jan 2020 15:49:15 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jan 2020 15:49:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hkpZh/hmTtKI1uv0tEY0nJ6V58dfHnt9QEKjIgDwKncnJHjI83KbIQTL50EAsTbxUn+iLJQddwJN6iNbZG2+gusYJIcXR4TxJQNzXczj5d1Re8wWHPCVBiEvTQSxg2bS4XoZtUjVr6KiugHHoWZtYYnwh+PHofDMnJ7qxmE6X3ylAQSHkq4BDMX6T1iPWl9KkOaiK0/+MOCR3tZrzJaGErgpHsJgcAnr9L9kb1eECAnzELJxLhveE9Lh4I4stw/rvSfBv/etNCC6v5f3OLCym7AObILSnJSHpVf18hlVPnjyIhYsRj8A04rql/eOJ3dfosv8Ogemur+KABQ6exsgbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jp9kmZ97vUujmkXSWQtYkgnOHmqHL4Sr9M09FsXPRE4=; b=IzVF9CNNsCIjZhGQChcngcRsOZREbnz7n2R4F7vRQj70kPTRekl0XybGqINND0lAQLGNsf2RMkcnuYUwkMNf4DD5H6fw+plH0Ov8pABLaUC9E9Joeqb58k9G76rXJp4eTblWUCQHtfHAJDsZpCuIjVWsypHQB1I6MoPKsVC3WDIlHLRIuOewhTYut2uwDBgi9FdDG7RbM+b+KF+Dh9H3+Y+cxa/2BzggIyUzUdPUg75lTy+SL2iRyyDM2jEJgnDBdqUa+gCEK2IX8iI/Y2aNA179xfXLixIOdzqfynUOUjXSRT4IrAEklD7duM2UYfyyvx8P43nUlhXa5oMvuFjEtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jp9kmZ97vUujmkXSWQtYkgnOHmqHL4Sr9M09FsXPRE4=; b=j/vV+NfaaHG5yf5kSRPDgCIkA0upAIeV+cyK3OAbE/2LmqotWUDmw/PwTE0hFPujhddjCp7U66L4N9/TM2uQf+8qyFMU6IGUKjpxKidy3au7vPRoNrqxiu/SLQxVV+kpIdMso+IFduGMYqxveJNFo7xWLFidf3dQph+LY0zOyms= Received: from SN6PR11MB2558.namprd11.prod.outlook.com (52.135.94.19) by SN6PR11MB2687.namprd11.prod.outlook.com (52.135.89.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2665.24; Thu, 30 Jan 2020 23:49:12 +0000 Received: from SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::4d86:362a:13c3:8386]) by SN6PR11MB2558.namprd11.prod.outlook.com ([fe80::4d86:362a:13c3:8386%7]) with mapi id 15.20.2665.027; Thu, 30 Jan 2020 23:49:12 +0000 From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, Anoob Joseph <anoobj@marvell.com>, "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>, "Trahe, Fiona" <fiona.trahe@intel.com> CC: "dev@dpdk.org" <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "Mcnamara, John" <john.mcnamara@intel.com>, "Trahe, Fiona" <fiona.trahe@intel.com>, "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 4/4] add ABI checks Thread-Index: AQHV1smFFsBCT8/Ts0WE6L1M7kr0nKgB6XuAgAAHoQCAAT2IgIAAMFIAgACC34A= Date: Thu, 30 Jan 2020 23:49:12 +0000 Message-ID: <SN6PR11MB2558F5F11146D87C324673E29A040@SN6PR11MB2558.namprd11.prod.outlook.com> References: <20191220152058.10739-1-david.marchand@redhat.com> <MN2PR18MB287716C2FB283C93CE11AAE0DF050@MN2PR18MB2877.namprd18.prod.outlook.com> <BN6PR11MB17965D325A2C002EBC08C68BE4040@BN6PR11MB1796.namprd11.prod.outlook.com> <2118076.C4sosBPzcN@xps> In-Reply-To: <2118076.C4sosBPzcN@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiM2M5MDdlOWYtNmRlOC00YmQ1LTkwMjUtZGFmNzlkYTNlNjE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUFhDT1ZUUFl2NDVZZ3VKQWFBeVlNRFRGVlBaTThDdlFucGw1R2M0MWtUQ3VHcUlUMU85V1VkK2FxdGoxT2oxayJ9 dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ce03dc41-6d04-406d-7646-08d7a5df01c8 x-ms-traffictypediagnostic: SN6PR11MB2687: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: <SN6PR11MB2687F946C5F41D98217CCC759A040@SN6PR11MB2687.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 02981BE340 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(366004)(39860400002)(136003)(346002)(376002)(189003)(199004)(8936002)(66556008)(6636002)(71200400001)(4326008)(81156014)(7696005)(478600001)(8676002)(81166006)(2906002)(54906003)(316002)(110136005)(53546011)(86362001)(55016002)(6506007)(76116006)(186003)(66446008)(66476007)(26005)(64756008)(9686003)(107886003)(5660300002)(52536014)(66946007)(33656002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2687; H:SN6PR11MB2558.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MzXNxEl9qo42rP2wr2X/nXP+QkDkHQc2NAA6PXU4Dvhpum7YBO7row1lzjs/lRQl8eOqdPeyOyjlpEVa6TbDbA+1E9IO1uurX0TU0DiWfO91KvwKWzVvWX1ux9n6kt+znF+RwtWItjWyW0RyM3EUG0eeXBuMxVCW6OhYfB52Mjwa3l4bk/QRY1/vrrq5uFuITQAEkn+//W7FBe6PxH1z7DQ1zSJRpN/CWjQnMga4R8vPzjiGDtNLNGIBl5VH2dHj4aM7IGq2Y0Vl2YIMx+kBkXs1FhOPi4hOU8HfUeunDWXteiffNFtlXUqF1pk0x6tHGVBzkLj2VhQb1UK9uanGMlF5Uq3X0oXjkY+93Mnbp6nQfNiiLmMxEKLG6HQdea7IhyNsol8in9Zntkq4QWSGGuq2itAztwl2axeDH/VHCQEMbtKolOQ2Bf9deszTC2Fk x-ms-exchange-antispam-messagedata: U7DAmieEKCHs2K2XwedaIcdH4DPKz4nEK6X1lTvOeHUZkZ8NrQggUzqB/PDUYUIxMN0k5zShS8cwUWay/u301mEiQ4GKCE+qCZVpjVeLr5IvY/2wIXpfR9AOp+xatuI0O6DcKnZlPG7hzy587SP0QQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ce03dc41-6d04-406d-7646-08d7a5df01c8 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2020 23:49:12.0620 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r3Vx9h/zwZaGOnhoicbHiblm+DqtkOnIOX5j+JNV1DmJ1DhZ/8xDpK3f2q+w2k6OBdA1S4cAD7JpOFwCpAPXyiE7AXTI1Jm81SPaCtRaAsE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2687 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon > Sent: Thursday, January 30, 2020 4:00 PM > To: Anoob Joseph <anoobj@marvell.com>; akhil.goyal@nxp.com; Trahe, Fiona = <fiona.trahe@intel.com> > Cc: dev@dpdk.org; David Marchand <david.marchand@redhat.com>; Richardson,= Bruce <bruce.richardson@intel.com>; > nhorman@tuxdriver.com; Mcnamara, John <john.mcnamara@intel.com>; Trahe, F= iona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX > <arkadiuszx.kusztal@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks >=20 > 30/01/2020 14:06, Trahe, Fiona: > > We were unaware the LIST_END change could constitute an ABI breakage, b= ut can see how it affects the array size when picked up. > > We're exploring options. > > > > I agree with Anoob's point that if we don't allow the LIST_END to be mo= dified, then it means no feature can be implemented without ABI > breakage. > > Anyone object to removing those LIST_END elements - or have a better s= uggestion? Would have to be in 20.11 I suppose. >=20 > Yes, having max value right after the last value is ridiculous, > it prevents adding any value. > In 20.11, we should remove all these *_END and *_MAX from API enums > and replace them with a separate #define with reasonnable maximums. >=20 I think we'd better avoid public structs that have array of _MAX elems in t= hem.