From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13410A04BC; Thu, 8 Oct 2020 23:56:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 524B91BC76; Thu, 8 Oct 2020 23:56:09 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 582E81BC7E for ; Thu, 8 Oct 2020 23:56:06 +0200 (CEST) IronPort-SDR: mQgRjHj1ZCmzlwrmbcI4XuC52jHoDm7MTLIWU3rrd9l8SU7aE6sIEn6oZE4lP1zz1tLEJFM276 xKXfT4d/LeZg== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="165525411" X-IronPort-AV: E=Sophos;i="5.77,352,1596524400"; d="scan'208";a="165525411" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 14:56:04 -0700 IronPort-SDR: +KFmFJsUgc0hm7Thkbq0Xm6Z2G4ex0RQc5B612pxLlgiXD0bAxx5fS3kH4snT1hoebqW9EE8eF OueThQ/aDJNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,352,1596524400"; d="scan'208";a="461957384" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 08 Oct 2020 14:56:04 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 14:56:04 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 8 Oct 2020 14:56:04 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 8 Oct 2020 14:56:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jA4CCDHD6aMCWM9n+210YsJ2yLeOn09+ODR4E/nU9kegpk0FWDtgQQwpkSYYntR4DuFNxvCKh7q6p/me9RLGjc4ccKT8Ot8K0M4lV+IwWIw+tQzHhBCQGiqvjCQQly1iM1LHeaO+TozVLdfwGmF/MUS34pkUymZBbjMoV3SIQEEl8MFB+xbUB3lbCl4E/ov0Hc4rLUERsQRC6bGqXxa34v2a97cOtplPD3cVyVy8VZD6Z82Yp3xGKb/pTdjI6VKRRk8CoKQs+3JXvNub9/qy6JysJtToHb4kHcMnN1l0iohlETMUSd4cqFnj/YcP8Q3JoI2wNwpe/Ngn11YLxxWitg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YPCB1HpTnOI9zVKwskWU6aVcbl53qU1vhviSbEC2Rs8=; b=eeKzO6e+SIiPhA7L/zlYx+ZAOoF6oWyHkwJnB1pD3g04QyoPtQGt8Er2gwQMmrfTXEyXHEOFpMcNcpwVetuO5e5Ep58Xs07+YaW0vRatQWVtM0uvJnxLUhJt4ZR03ciYFK2BwOt389pWjoXqgmG/HT3WTwa1NbFXiDCXDT7XwRxm7bNfEAIl8VOhmpFdMPhHSgGQqmlWvzbWgHUepZcMW3xWKllKKX6Kb/TxULXz5SIKvCR8JpEd8M/duNR6jQSmbol8BAsOOlYq+X548ci+LrdnkcYwyyidugqqNxtuQDX4abLU8R1JkHyrFKKp2I6rnuD977racaZCWTmsUGwiBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YPCB1HpTnOI9zVKwskWU6aVcbl53qU1vhviSbEC2Rs8=; b=lIXjrqDxpZfQVmc8mw9WCVLKw/LLiPUnAyW0KE0rRKS3nHkOfNaeEgWlgk4+wbwZAsanIWyhPPxxJXXD271g4zolKsJGUM7HyU5ZXqaBtmOR+W0X8f8cITd5sq3UitaM0XR66oWgQ00E2qtMzW+Nuo+2Qp/kaJ1O6LM1IUmevx8= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SA2PR11MB5019.namprd11.prod.outlook.com (2603:10b6:806:f8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.34; Thu, 8 Oct 2020 21:56:00 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a%4]) with mapi id 15.20.3455.024; Thu, 8 Oct 2020 21:56:00 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" , Jerin Jacob CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" Thread-Topic: [PATCH v4 19/22] event/dlb: add PMD self-tests Thread-Index: AQHWiHDhDfj7Q5QYdkOAPi7qLYdToKmOadFg Date: Thu, 8 Oct 2020 21:56:00 +0000 Message-ID: References: <1599851920-16802-1-git-send-email-timothy.mcdaniel@intel.com> <1599851920-16802-20-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599851920-16802-20-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eb6f086f-5fad-42c5-2a5f-08d86bd4f1e4 x-ms-traffictypediagnostic: SA2PR11MB5019: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SHFTh2Xk209wVcTzMDTgpCEmZBhqNaVKCk5l3I0WmdfAESeWNyh67e6gAirAo1psQvaosyNNnts3hCT8x4R2Bun/c1ms6yEniXOqR8tXKPF9sK+GMFEM4lv4nbfcOdv+EiQCG2scQ+X+1gqD6cclPVPjSpuoP/SUy+wQaLnNjlWXPp9mK1nidFU5O3iDx52Beun4VB8byU+HsvQSf97gFhZk+LD10dxlKOKd+KJOwa6QwH9wrzJMeOHjajL8kyMuFoWcNMH7AXL5dts6N9zuKL8S1HEzCsTCZIELFGT9b63dQS8498YUv/U+7+WqKURFSAKA1MZEJ/Jkb1JhV+PhfA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(136003)(376002)(346002)(39860400002)(33656002)(5660300002)(53546011)(66946007)(83380400001)(6506007)(316002)(110136005)(66556008)(186003)(54906003)(71200400001)(7696005)(86362001)(66446008)(66476007)(76116006)(52536014)(64756008)(26005)(478600001)(8676002)(8936002)(55016002)(107886003)(9686003)(2906002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +EEb74cDFArFsrnFSS+N0ZilXH5NeRF0xwxuaA6Yff6pGGNgQyMOtegWyoWxZoVHCxmhdDYWKC2Ziek5Vr+5H6UwSZ6LjpZRsNCGTSClv1R9jncc7Mhqv8AmZ/GytO8ZBxrHIDDowYCzpoREvcgzuEeA3TgOxX6e5Q3f6Wg3vX05vU/q4s7wgo4jMI+8/4rJOiqxCCn/q7z8lUiiyxxciyiKPELWoZLDez93OnyxE4I1BJME1bXYnnhUjAmYUDgjUzwWUl7trhCVGIVTEtJbrWzS/C/gMxUOhLPv2Q4QdEQ202BUXOZrXVUE6q5WHwXYVppYPu2sw/XQGG1JHqttJVYKwKblRZN5muhlRmD1a2etHfVzmSNrZefuFaArc0b0seLtWEy4kMojTppYB+d7r4xdKO74a6QWtBs7bLikoLUcFgMpGPGrxerHcGOzEC3zfkSDZSil9n7uILg1ICWuGRFM5v6zx7baS06/kFv9vUV660xushS++X6tb+2FdiFSBRF/UiJAVQulgY9Kvv6uWhAS0hTb2VzbiB2tcLNdYkdOrdUYWPFEv74N2yOBBtDi2M6b8tMagpmTKcx/q+I2V3qxZ3gFft82/s+ZkpfUBq2oH2fHR9PYCahpKwElbPAQZxTDX8QIAetWGAXIC74UMg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb6f086f-5fad-42c5-2a5f-08d86bd4f1e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 21:56:00.6807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N4pNdnobdE7h8ELq+HDq9Uor3Q+gCIFY+GUyeBW8E33pJ6zrbIXBHNmjJqsAzkkXUBq6bPcV8PfKZIx/oNjcgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5019 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 19/22] event/dlb: add PMD self-tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 2:19 PM > To: Jerin Jacob > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry > Subject: [PATCH v4 19/22] event/dlb: add PMD self-tests >=20 > Add a variety of self-tests for both ldb and directed > ports/queues, as well as configure, start, stop, link, etc... >=20 > Signed-off-by: Timothy McDaniel > --- > app/test/test_eventdev.c | 8 + > drivers/event/dlb/dlb.c | 1 + > drivers/event/dlb/dlb_selftest.c | 1563 > ++++++++++++++++++++++++++++++++++++++ > drivers/event/dlb/meson.build | 1 + > 4 files changed, 1573 insertions(+) > create mode 100644 drivers/event/dlb/dlb_selftest.c >=20 > diff --git a/app/test/test_eventdev.c b/app/test/test_eventdev.c > index 62019c1..2f6ad49 100644 > --- a/app/test/test_eventdev.c > +++ b/app/test/test_eventdev.c > @@ -1030,6 +1030,13 @@ test_eventdev_selftest_dpaa2(void) > return test_eventdev_selftest_impl("event_dpaa2", ""); > } >=20 > +static int > +test_eventdev_selftest_dlb(void) > +{ > + return test_eventdev_selftest_impl("dlb_event", ""); > +} > + > + Nit: extra newline [...] > +/* destruction */ > +static inline int > +cleanup(struct test *t __rte_unused) No need for 't' > +{ > + int ret; > + > + rte_event_dev_stop(evdev); > + ret =3D rte_event_dev_close(evdev); > + if (ret) This can simply be if (rte_event_dev_close(evdev)) > + return -1; > + > + return 0; > +}; > + With those and the whitespace issue fixed: Reviewed-by: Gage Eads Thanks, Gage