From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85914A04D8; Mon, 21 Sep 2020 19:16:44 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 624CF1D95B; Mon, 21 Sep 2020 19:16:44 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C84221D921 for ; Mon, 21 Sep 2020 19:16:42 +0200 (CEST) IronPort-SDR: gb2TZi2LEoFuZwKz4e4nobd8018Kct6owvrxXV9p1tuZdfDsdb7RFeHUui3Gv65LArgbLx8mme OArZtH7iZ5zw== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="159730988" X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="159730988" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 10:16:41 -0700 IronPort-SDR: MRh50wDOIgv1XdQQ0tpwPIvDdnWQHb87UzeNhv0zd7TN3wqh2lleOOUqDjahdPM6fWOmtgY3GH peTkK96SMBiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="510810382" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 21 Sep 2020 10:16:41 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 10:16:41 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Sep 2020 10:16:41 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Sep 2020 10:16:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gHUY0DWQJHyWAdB5+JE0raj6M19Ior+cKnjlN/S+48o4b2ABoSFvyW+HqN46U53Keopk5MNvlZyVaytQHYtekwpIetd7OJg6wATst81HeGJesZJN+HYPWybS14bu4BxqgPiOtMdZj9gU0eXB5FIjPrnqAAPqtGc03yYlolTsoSm+pmxn4GxBuO19v0YoPOD14sdYPpGMLUqowVKfBOyXAoB7qtTbAsCgbu/SA6GmYhvW3akYBri4/NjnD4KI8zPgaWADjOL5hP0U7dcccaiii0djJTzO2UVsH/NZ/RCNIvbO8c5hY/oZNf/a7omF2KhnuFAucyLdJFUnpJNiCu1gZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vVdDfKJk/JQDe2EVxf4akWHkg3/wI4RyK/15F3o3cOw=; b=ggvRzdFuGmBSM5+/pLLuFLn3ap6cZlqosr/zzTieskjgagypRYwMqR7k+yqfpImUz3WePUOGlxcELNh8XZyAvNiTRWlzrtigNzeTgKv41G4VmD64riQMhAzCUdEAIxVz2uN7L8FN1cVKQjPvmazyo6/lUfet+7Nb4BQY7Lc3NQ6xgTk+6FXXIFp2a5FUE6c1TtoBLM0AfgLQ1KA9bhyf11/P79nOMHqCADhCg1tzviMwy7oy/eBe6ZYwDYHry7n2rt74laufNJmFExCtDNVynLjl5hQgol6KGi1wdMZj4pL62ErszPRO/EUafCKqP4djBK+uHtUpecNz10qtIJhitQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vVdDfKJk/JQDe2EVxf4akWHkg3/wI4RyK/15F3o3cOw=; b=mIc9k7MdcQ9c4aQigwehme7MVvKgjAQDDHk2KUmu4iSOKUVAtFj+HpesOxWQlWoECq/ixk4wBTci5WThvsxlOYTW0g3+fK0NnU3Tqrqwjy+IkknZLQiz6+TgYiHrMyiL862Z421viwPnnNRnFi6R519pi/YyLe8AivkdfLtagtc= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SN6PR11MB3295.namprd11.prod.outlook.com (2603:10b6:805:c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Mon, 21 Sep 2020 17:16:39 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::54:b143:c75e:41bd]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::54:b143:c75e:41bd%7]) with mapi id 15.20.3391.026; Mon, 21 Sep 2020 17:16:39 +0000 From: "Eads, Gage" To: Steven Lariau , Olivier Matz CC: "dev@dpdk.org" , "nd@arm.com" , "dharmik.thakkar@arm.com" Thread-Topic: [PATCH 3/5] lib/stack: remove redundant orderings for list->len Thread-Index: AQHWiFCtEg7quOBPsUiwfC0j3tV/tqlzUTiw Date: Mon, 21 Sep 2020 17:16:39 +0000 Message-ID: References: <20200911152938.8019-1-steven.lariau@arm.com> <20200911152938.8019-4-steven.lariau@arm.com> In-Reply-To: <20200911152938.8019-4-steven.lariau@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4237da04-759d-42dd-0664-08d85e521a88 x-ms-traffictypediagnostic: SN6PR11MB3295: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SOYymxuTq6Yc0iKfbhvTVP9f0/FxfaEh9o5azJquqjdE3LXLUrmv8DKY0GQli0QNbXTngp/ZpHOUw+RUOAcQ/DLqC0VKOHTfCXadk4lx8VZXAAZEv+QW9Oq6j3E5yiv/Pb2jAIHRow2Q5UtKzS2sN302bjE9E+SWalzIjIQzVu5Icuakjt1wRGVXUNaipbBC7rKgT+m9OfJU6Tjkmkrb7mwPkZ25/r595Da8d65rIWD2f2ZKR4SJ43ejxvTz9lLndsgdT79mUW6tln/nGyMxoUMGAvsjPYmJSS/2F5TQ0SUPn2tedTui0dQD46FFuC6AGq63ZktNX5mZqEk3N9soh3gi3AJuC59QsEJfVFMRVUJ2cH+O/EQfVSmLU04+AVZk x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(52536014)(2906002)(8936002)(33656002)(8676002)(110136005)(54906003)(478600001)(71200400001)(64756008)(66556008)(66476007)(5660300002)(9686003)(83380400001)(66446008)(186003)(86362001)(4744005)(316002)(6506007)(53546011)(55016002)(26005)(7696005)(66946007)(76116006)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Q3CVgI3jen7L4uIdzxum7ghLaT56IhoKnFT4UvIXVqyAu57Nmg1fGBj6UZBP8znsovpogayA0X3iuKxAXFB1vgEGg300f1TiEdITA0YQIxS7E/H0alj4jrXghS9EJyThtMAPRSQA579QhVs90ACLdhCs4xYe87owGpH/y7wBfBY0zvjDKhWbsr9UgTPfJzG7XlNeD6KH+jYn3qDfnEyehrrMcIo4uBY+rRN0s50+MPBs/OUVfxwho+pOR9gFufTGDDdn2eVe7YawDZyEFFWNItD47/f41fR9xgmNkfoyhio4/CR+Du0ZTl1XNMzJ52SbkBzbkzT2cTZBywvMbVsUoAH+8hEVD6RB/yUqrg9YPjnUUAS4M47GVnA4CfNyXA3hK/ng/JN6OOeDb1eK4t60r1InZTocUOabjfOYXf6tTC8zHoz/sTLwgmq+/dGP0kPpiRmXjuNo8YTGcaITXnPg+h17Q1R3iGOEt26YGBV5dQHbkogB/SUmQEX1meUc1fiug38VT5QoiKzba4mQaKlvPXuAeid3lAovyBn+J6k39pheg3l3d0LQ2/iSnbH22PSIXMzkRBi15s+EhGXY6Y3IYsbRDtf01Mvtzzke9rt0snOArrPodI72LfNWYAMNlqt6KPZpzkNoCR7JjljhZh8AjA== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4237da04-759d-42dd-0664-08d85e521a88 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 17:16:39.6607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wMmBszaU931n+PW7czWIoi79XgS0tPsKJZkfHTspoptnjX+FVva9fkJJoeL9jQ+7Ep7/KbK+3o+44gx7gomllw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3295 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/5] lib/stack: remove redundant orderings for list->len X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Steven Lariau > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage ; Olivier Matz > Cc: dev@dpdk.org; nd@arm.com; dharmik.thakkar@arm.com; Steven Lariau > > Subject: [PATCH 3/5] lib/stack: remove redundant orderings for list->len >=20 > The load-acquire of list->len on pop function is redundant. > Only the CAS success needs to be load-acquire. > It synchronizes with the store release in push, to ensure that the > updated head is visible when the new length is visible. > Without this, one thread in pop could see the increased length but the > old list, which doesn't have enough items yet for pop to succeed. >=20 > Signed-off-by: Steven Lariau > Reviewed-by: Dharmik Thakkar > Reviewed-by: Ruifeng Wang Acked-by: Gage Eads Thanks, Gage