From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C7EBA04C7; Mon, 14 Sep 2020 22:23:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 659AAFFA; Mon, 14 Sep 2020 22:23:03 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 49FAF160 for ; Mon, 14 Sep 2020 22:23:01 +0200 (CEST) IronPort-SDR: K6Lf/6hG6ZlNggEWJOFb2Ns0pxJoEMC+1enVJwzXsLgqG251gT0ki1L4bjoaICvkGWlWuGK5NH C+G5Mkym0KXw== X-IronPort-AV: E=McAfee;i="6000,8403,9744"; a="223340592" X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="223340592" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2020 13:22:59 -0700 IronPort-SDR: xESJE1aH6ofgJPFrwmIEYYofqyint17vo0mzjcrHqWzev+HLtFMcW+kofEwdvrIE26bzna5Cok 4biyXwluWHPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,427,1592895600"; d="scan'208";a="408960131" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga001.fm.intel.com with ESMTP; 14 Sep 2020 13:22:59 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Sep 2020 13:22:58 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 14 Sep 2020 13:22:58 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 14 Sep 2020 13:22:58 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 14 Sep 2020 13:22:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8GOTVHeWHScFEXQHisIJAf6BpciznwyMNfBzwc6z39D3AWhS1Tlxzdq/Ka6yhQvh4z29NNzt9H88eOBO+0KYasEWPiwxMgkTLgudOadOMTO0NqEQ2tYDlT6jj6V5h1zC19TbDsKQGtxMosg55Z/u4Yc48DV/PIo9giCwWI0PR1mQDFl4S77nEHrV+o7DPP/4uI9YZEpT3pFox35/nsnPlHIH/tK1ocd16s1b74K1y9mlEJRsp90wFw8GRv1mzypDXWWWo48mOMbizIaAWBw0cezJAOGdYwqthoiFVN/D41S9kkZ8H4ainxFyivGj2gtKd1HmEZUPDgYKJnM1eDSZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=toPu9DoQD6VPmEDmf3mZFwaD+PW1AtQDcD+jWyPxwZo=; b=gk57Rby4+c0PlI4jCt3bP2V1zzpW7mnxIEhPvTu8EMUx6koBJscC2UBk2W6e91uByywQPE7/NxyekfFtbsfGzJkny7LjFT7DukEOwIVZOvzDOF7z9UlU07o0GshjOE1Z87/wa7OReQdiy4w4lkK4DLq+pNU4szIQkHoMJu6yut8fTH4uvNgsJXnmNUOrgwbzSP/g/cpKJTwRZkZKoiCwtZAYvV5Iiw7kO8wTGDetjMU9KGBLt9uPD2tmP986Ox/wHT64lG8S2C1TFnHMFumoSILMC1NwMF5xSR5VYJJkVX4CffDlCy0w2s1Sa/gmEc/Efdfw+GbIxtyjJEPhxvBjlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=toPu9DoQD6VPmEDmf3mZFwaD+PW1AtQDcD+jWyPxwZo=; b=wapHNWh4osE7JHJBIRYp+HTiXd+xkBtOOg6MidyIudD8OEvKREBdwRtGzyvsLwC8XcR1I79gZ9JyGtRzU4l62GPql/mu4YVpqPh3YNXQVdGnCNs4OhNjxFHnklzZUOG3acDsJ/0bcd9eemV8C1bRCH2bKyiZ+S8Ee4mq19CGwN4= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SN6PR11MB2830.namprd11.prod.outlook.com (2603:10b6:805:57::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Mon, 14 Sep 2020 20:22:57 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::54:b143:c75e:41bd]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::54:b143:c75e:41bd%7]) with mapi id 15.20.3370.019; Mon, 14 Sep 2020 20:22:57 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" , Jerin Jacob CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" Thread-Topic: [PATCH] eventdev: add PCI probe named convenience function Thread-Index: AQHWiF4gMmRJ1Be1LUiVu9Vr5xHbf6lokgLQ Date: Mon, 14 Sep 2020 20:22:57 +0000 Message-ID: References: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 150d192e-690a-422d-f930-08d858ebf815 x-ms-traffictypediagnostic: SN6PR11MB2830: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7HEMcpOLrWRurvPL/pEK0aY7cXg3cIPTlD29l7UqNjxEfxAiY4/KiZt8vkWN1Vvtz4xbskykcYGvkg0hluXOiIaCqpa27wSVX5EfCH6V45h5e3qsaWPc/AFMED0VqPWNYFlSyfBW2c0eYSEBej5AaRmPpJJJObCef8q/bNNU3JOph+BmUDxP0GeBr0CcvYhLi0IePlRSi+3FjJslSac6Ek9TDGCZgH6+nIPvfe+b7jg/UJhbCYwWNLoS6dFsBSO4WoI9Z4I6U0RCnAbeIwSOKvICLzENpZPFDFPcesnaCPcorDSMjZKrVk+KF9WEe33T x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(33656002)(4326008)(26005)(316002)(52536014)(478600001)(4744005)(5660300002)(71200400001)(66446008)(66946007)(66476007)(54906003)(64756008)(66556008)(110136005)(107886003)(7696005)(2906002)(8676002)(76116006)(186003)(55016002)(8936002)(86362001)(9686003)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: D7Uxe7zJePIUcOFk0vk7cyZjSFNIr9xJWfv03tm9ETa51XQJrMd50UdXqr83qF5svjGQMQC9MZeO2PGFe+3kCNid04lKn1u6aVzRTj4TsuhIh6smrr8V4Y3pNvhX576p1o+AVSFZlO+6VCQCaKML6uQikoziED0J7SsftfjCBD4kvYViS/LKD4AiHS3+V787YHTo6GNj1Bb28P9Ni1CdCW97Ftb8GUzOxR1sVh7lZkP/f6Q842mXOvpCsS0iwKRmXMANwGH8lG0iYSl4yptNkrlOZ9UDPD/yM6gXsNLAEV7iwEGvoa/Jv/uHMN2G/t//w27owmMIgVebjfA6K5GIPRqp51pk1auhavK925t484vRLguHzJ5zHURmw4gEFO1zr5+gnGxnDwo9zC3qS+OOY0SgLY4EjtqehL2BcReorKy8AYfm4pHNGgZNou+a0WXU2KTTmB9cNbBeUJHRTiny8vmhuoKFKNHWcKBJ5TIzmsU8bHa8o43e4C+tbK0kEQ1UAi1jTArdXT+zzcKgXE7rjPcd3JGGm/6NsE5KX/D0DpZJCryXRV2LLEuQv+UkiATsPATnwL2KBtp4inQGpE1/vef/VwiMsryXHAbs753/utF4lpmtSsfxi/ATRZ1/WFoyhj16DrvQjJljgsC5b2t3gA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 150d192e-690a-422d-f930-08d858ebf815 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2020 20:22:57.3964 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F4hIgpCOOWQ/ZWNmtYEyzzepALKy4yxp/5yFXLcONgo8FFxKR/F2o1iuyJo8M4jdQaWEE0pf4niI1lNxDA+crw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2830 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > /** > * @internal > + * Wrapper for use by pci drivers as a .probe function to attach to a ev= ent > + * interface. > + */ > +static inline int > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev, > + size_t private_data_size, > + eventdev_pmd_pci_callback_t devinit) > +{ > + char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; > + > + Two blank lines -- DPDK coding style doesn't forbid this as far as I know (LINE_SPACING is ignored in checkpatch), but just an FYI in case this was unintentional. > + rte_pci_device_name(&pci_dev->addr, eventdev_name, > + sizeof(eventdev_name)); > + > + return rte_event_pmd_pci_probe_named(pci_drv, > + pci_dev, > + private_data_size, > + devinit, > + (const char *)eventdev_name); Nit: the cast is unnecessary, the conversion will happen implicitly without= it. With that, Reviewed-by: Gage Eads