From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C1423A04D8;
	Mon, 21 Sep 2020 19:17:00 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 605DB1DA92;
	Mon, 21 Sep 2020 19:16:53 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 734CF1DA7D
 for <dev@dpdk.org>; Mon, 21 Sep 2020 19:16:51 +0200 (CEST)
IronPort-SDR: sw+08tk1r9ZgqxltiAUMK5vSRl4QHi54P/jxELO56/kUbEko6HEuJRIXeUR2dxeBzZnRPwlLeb
 /VWlhwLdSi2w==
X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148195488"
X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="148195488"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Sep 2020 10:16:50 -0700
IronPort-SDR: MJBlAKeOC3m8lD97TYzgIHYfiCi64cHjTQZQ3ln4uVjWmuB0V6oGnsEMNr49dCSndtPAkdn4wI
 ENdNM119yi7w==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,287,1596524400"; d="scan'208";a="309145034"
Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17])
 by orsmga006.jf.intel.com with ESMTP; 21 Sep 2020 10:16:50 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
 ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Mon, 21 Sep 2020 10:16:50 -0700
Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by
 ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Mon, 21 Sep 2020 10:16:49 -0700
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
 orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
 via Frontend Transport; Mon, 21 Sep 2020 10:16:49 -0700
Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104)
 by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.1713.5; Mon, 21 Sep 2020 10:16:47 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=JB5WpQyJYbggNbHQhXx6WM1jDGrkyR1+9wnTUwPahnzGC3wpT1+Vqjrnsaj9FHdtG3pYI4KfkjLm0m/zlqJnkaqBKfJblhybsLKkAPQeNOAkocwha951NLeY33k1Yt8/dYYEe0fjUJTsBfL247TwDqp0ipFqkZ2+q1bhQuFHi0thEFYiI/CPLdk8IVkdY/kDWovLFlylR0VqaYytL6a6gTagel/A7ZQ0Ysm94x2Tb+S5SHeWz6joBGpzZuwE/4eIoDCsk7nJnqA6Hc9caakTIAvmjJVy0PqVj1SR4ATsviBWLVONyXMuV6RgJoPu+O6CxRTUNHuuj5vrdRNQXnCZBg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LOt78ySB69hH+H19+7zFruszzn/Cs8PyaiXjRxCPfLU=;
 b=itZNZDATHdryHVM/eDtP5gy4RiyoDnLDsPQTdMzWKMAaH1OOujzHGiSC4djzEhMXOP+Tq02R3rTN4cTXGMa7GfG7wVbxUP7vY+ReedN2QsGAi759phyeFR+AHqKiBqQWVt1TAH3SUkIk5yRPvJhqitKiD/BRXkBfFQbrJ5H45mi0fgjS1bb0Rm+oXfdORHAe9eig8qjGGSrHYUcGLdHhjR3oBMy3cgJeKx8utrvQtzEPyUmB97C6EDZ2zbcFUH44sbxlSs0d9ceWm+soItF9DphYOvFHgbGXAC0Jjf4OR0MFEDmaqwSNBZe5hwyqVy+mseGfrehiZumkp8TVCNS4rA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=LOt78ySB69hH+H19+7zFruszzn/Cs8PyaiXjRxCPfLU=;
 b=OWD12vFdVAheY0svP7ebvIIwWGF/7zcL1RZLqWTOEM8/rFMYks/kG+ArlSScqT9XF6eiin+0vKK2Pvvz9xyFdKS1pdRdQo/ojhbUBNvZWZpHOzoiaE7Iy/7dQEbPjTrkBWPfb5EN98tnwEt28D1SdL1s1yqDfv+EoA7uilr2BaE=
Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14)
 by SN6PR11MB3295.namprd11.prod.outlook.com (2603:10b6:805:c2::18)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Mon, 21 Sep
 2020 17:16:45 +0000
Received: from SN6PR11MB2574.namprd11.prod.outlook.com
 ([fe80::54:b143:c75e:41bd]) by SN6PR11MB2574.namprd11.prod.outlook.com
 ([fe80::54:b143:c75e:41bd%7]) with mapi id 15.20.3391.026; Mon, 21 Sep 2020
 17:16:45 +0000
From: "Eads, Gage" <gage.eads@intel.com>
To: Steven Lariau <steven.lariau@arm.com>, Olivier Matz
 <olivier.matz@6wind.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>,
 "dharmik.thakkar@arm.com" <dharmik.thakkar@arm.com>
Thread-Topic: [PATCH 4/5] lib/stack: reload head when pop fails
Thread-Index: AQHWiFCtiKlGMCC2H02LVYzq9LpvyqlzUWuA
Date: Mon, 21 Sep 2020 17:16:44 +0000
Message-ID: <SN6PR11MB2574E153F859066DECB31C8EF63A0@SN6PR11MB2574.namprd11.prod.outlook.com>
References: <20200911152938.8019-1-steven.lariau@arm.com>
 <20200911152938.8019-5-steven.lariau@arm.com>
In-Reply-To: <20200911152938.8019-5-steven.lariau@arm.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-version: 11.5.1.3
dlp-product: dlpe-windows
dlp-reaction: no-action
authentication-results: arm.com; dkim=none (message not signed)
 header.d=none;arm.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [68.203.30.51]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 861059c9-df28-4309-1bc0-08d85e521da9
x-ms-traffictypediagnostic: SN6PR11MB3295:
x-microsoft-antispam-prvs: <SN6PR11MB3295BB535C3E5E844998434AF63A0@SN6PR11MB3295.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:2887;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: YsUcbRtiiHalOOMNASZ6LlbNfm4bjVHrmaLlxRZNvHkYB8bED+EDJv4bEBkbp2HYMjyNH71z+9abSqj2hRoBVgUNOuKyO7lgIzeeCl2Z6qpv4xI+ACYzJgZrSDVpBJZHI3vRxL7RTuNKOGxKqacAWPuJYWj4CmN/x8iTtFqtVg9o19/ZSsZ6r6ku2IgvNUB/JTUoFoFOucN7mAjtl2MizKfIPNAEH/Q6DFfcDbCEyTT8PcsGzTAE97kUujYrMv3DUwRJlP6HCkwk5PolWHwB5mfTMODxn4BacmD43zgHvmAf5HyhXr1NqgoPI9Fx89Yh5+oRbL/vXgIMfUQeF5sVpKgx/1rftetNpzZDuU9o6m+lZovvj1LQqaxxXVSiIG3y
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(346002)(39860400002)(376002)(366004)(136003)(396003)(52536014)(2906002)(8936002)(33656002)(8676002)(110136005)(54906003)(478600001)(71200400001)(64756008)(66556008)(66476007)(5660300002)(9686003)(83380400001)(66446008)(186003)(86362001)(4744005)(316002)(6506007)(53546011)(55016002)(26005)(7696005)(66946007)(76116006)(4326008);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata: F37KqBfMSsu+lhYL96PyOrSqIZNQrOBIliwWdaduipEm9SzS/vAptEGUvQGInuGKhYROjvh5GwapaOlemiUYQLc8XJ7YN+PmUHkLVINCCT9SKhX1o/uMs0h8K/kbchFi1Ps35m+MPyc0ZyNdHHySDIQixA7El+AHgV9LXQvZKUXyGJOEPKSqYnWge+GFLvvJxPIWWwaUGtD+TU1XCVNx8czt8HdmQCqko36LfuEdmwCqqjwIs9hPEw9+Mr9AqCopUXn8aruQsp0lv1bBlAs/2x8SVHJdtehF23A225Bm1WLQqRwK6BED2/TrZA555srw5qO0cCYiNgEJhDxOVRT5KxgyMq9QUFiv2HytZYuLjDtU/Is+BFRdUYdePuE7VsUNrT4cIRbYAL4DMRoLlUSJByMLZJoZo7+dS1lD3qWcZrCZGuDZbUpHYA4eUXyOEkkVK4yXrLu1Pc0pRi9CbS9rWAORbHudxhpF61H0aIU56qf9MztraLX+YWx6PS4bUUc+MypG47Xvp7SGysZAiV3RN4xCQNbVHp0sr+P+jhwG+nX++fIawZyCZgS3l0qMpgmuRoSFpSWddfZZN20NdlOmStoz6RC1wdaD24pCWD5zRdjfVMtO4+Z3K+o+ZL+uYZK2yT9w0sIqdmSiSIoY+/Ghhg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 861059c9-df28-4309-1bc0-08d85e521da9
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 17:16:44.9537 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Wj+pD8GqzTvon0GufU85pMCsro4a+0VyTvqk4hHXJrtjm67NnKk6nyIVHKRqNij/hFMcwz/xhQIC23DJHhtQqA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3295
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH 4/5] lib/stack: reload head when pop fails
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Steven Lariau <steven.lariau@arm.com>
> Sent: Friday, September 11, 2020 10:30 AM
> To: Eads, Gage <gage.eads@intel.com>; Olivier Matz <olivier.matz@6wind.co=
m>
> Cc: dev@dpdk.org; nd@arm.com; dharmik.thakkar@arm.com; Steven Lariau
> <steven.lariau@arm.com>
> Subject: [PATCH 4/5] lib/stack: reload head when pop fails
>=20
> List head must be loaded right before continue (when failed to
> find the new head).
> Without this, one thread might keep trying and failing to pop items
> without ever loading the new correct head.
>=20
> Signed-off-by: Steven Lariau <steven.lariau@arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Good catch. Please add the following so the fix is considered for dpdk-stab=
le:
Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation")
Cc: stable@dpdk.org

Acked-by: Gage Eads <gage.eads@intel.com>

Thanks,
Gage