From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6CF74A04BA; Wed, 7 Oct 2020 23:25:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B0BE1B708; Wed, 7 Oct 2020 23:25:01 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 117A11B68A for ; Wed, 7 Oct 2020 23:24:58 +0200 (CEST) IronPort-SDR: mKoyapJXDgV+pOaBKRz9zpRkoolNbRP+cwi3iN8d+8W6wbwfD0EFcvgd0WdH8L9VvjgQOQDpJf 5QWhpe54pYKQ== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="165207061" X-IronPort-AV: E=Sophos;i="5.77,348,1596524400"; d="scan'208";a="165207061" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 14:24:57 -0700 IronPort-SDR: PLzrEmT7CG7MUw0ZC4fw/GdRKGJx2EBqjDC0CdZ8KP5Lik4UQYQPDk3n9Ul95qVQO0YDJcx7LL zQlM4K6qRCfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,348,1596524400"; d="scan'208";a="528171905" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 07 Oct 2020 14:24:56 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 14:24:56 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 7 Oct 2020 14:24:56 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 7 Oct 2020 14:24:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mzKAZ+f+pG20jvs8KrZ+XY6D87m1BeDwia31rIBGINGHpxaAhmM3FzV7KHlf331T1jVUKi3w8iuFzu9FT3oYbZw1tliFgF5olBWun4LapwoR4h8LzxhW+SzdZo0k+g6Ij0kNlO7tVQ8NSaLiK5Cgi3LJHBgCfYYCGtW1+xbwuHcHCcgVhy3o0k9sCRzh9iJgCLYGaWFYTuVAIeYUlQxHM2HDZe2ZExp5k8P16cFpU7y9Psg/sdp94zFIe921vKxrIz6nqNlclt60s9uZZmG857zfBaEVzZDCYUIYoIwgKaujqrHXFgHH/gdreQaQmVUw1Ztt33sZlWmu/EjcdmFC1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kun70QRTXNULos+r2Kb68+N5EWWeCQ3kNJdxE+fUdNE=; b=d8qMjZf5xv5wV93uiVGUSfHCBQe/tSixEICHTpnlCyGdUhwIikZ3dpdUfJQ+bdiq8hNkaVUgvo8hPy9lT/QIjJZ/eorDFb30FOSTvQAIcMbz/ueyQ9HBDcCGJQd6GIHPGyvVLVBrgf2VuekM6zy+iCK9g1sByYvvHoBaCvX+vK4GhJmN6KlzRAt/ia+Utjf9lEHe0u/yvnLoI0FRUlauEAFC1mAPSaiv4Rkt6mdk/2oda6MzJYLdZhmoCQL4dLRARdRnxZtZwQBN+QzVYsZIrQMpXM3RKJil0Q0o7A0z9j3oZoEvxhuDbb+LEDqYVKzNiwpfwKvEPNDPJI0Km0oouw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kun70QRTXNULos+r2Kb68+N5EWWeCQ3kNJdxE+fUdNE=; b=Pr1plbr01QF9ZhCmIoD2pV9rdkcFty1hkJShkd8p/BAnhUQUhTbV2HmMiew7q2RedpS8CeMol0j5o0yAuAL2ttdjttEGShs+0yILSXwxGtPUsRkclksF3lW7kNnlbjcxDyaMO8i0sLTklbVYL4nN7DLwxLuBBhB4x85SZL4ugn4= Received: from SN6PR11MB2574.namprd11.prod.outlook.com (2603:10b6:805:59::14) by SN6PR11MB2575.namprd11.prod.outlook.com (2603:10b6:805:57::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.22; Wed, 7 Oct 2020 21:24:54 +0000 Received: from SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a]) by SN6PR11MB2574.namprd11.prod.outlook.com ([fe80::902d:8f85:ea05:a7a%4]) with mapi id 15.20.3455.021; Wed, 7 Oct 2020 21:24:54 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" , Ray Kinsella , Neil Horman CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [PATCH 18/22] event/dlb2: add PMD's token pop public interface Thread-Index: AQHWiHphGk3G46+IeEG45VshKmGlcKmK51DA Date: Wed, 7 Oct 2020 21:24:54 +0000 Message-ID: References: <1599855987-25976-1-git-send-email-timothy.mcdaniel@intel.com> <1599855987-25976-19-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599855987-25976-19-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 690d81e0-c6f5-4200-6d73-08d86b076f17 x-ms-traffictypediagnostic: SN6PR11MB2575: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K+TvMUT3x001OE2oYsYsapIrONEGC6ubyTMMfOoduMEhLMKlv9ECg2swxzOMrCD5en6tVIEKK4dFyQRrF1S7KuEgreyLA+caaMn4ehdGIkPx+4EDi/fYJ/sDh/a8jy80otP/iJ6FQelBq2lmtR8m+rWNIdzMepOPSbMO1+a220qRIk5ksQ0DDArsTWhal2rqkprOegfTWeK+R5Ug9khQuPEPnk1Fh7I+vEVNtk27FSLxFYX2G+9ISRaFEBkKRfK0KaiALc5NUfkqpm9vWgIyzTda2LzsEewId/IBblCbxU/GD6919Sn2bRIPgsi1QFhw x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2574.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(136003)(396003)(376002)(39860400002)(9686003)(54906003)(316002)(186003)(4326008)(53546011)(71200400001)(33656002)(110136005)(83380400001)(26005)(6506007)(55016002)(478600001)(66556008)(64756008)(2906002)(86362001)(66446008)(5660300002)(76116006)(7696005)(52536014)(8676002)(8936002)(66946007)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Wd+Kbgx1pbtTvTbxoYBQfIYPKpOnuuG7BpwuEIpspC0kLwQueFWREBPpuynO0zFo9yyrm6x3nMIi5okOBfHIT5kn8RmU2YOwdR/GlE7i4YaqIb9lUZFkOu2K5gCQdm8NhAmVgr9n/7NVbrAQ4PIm9FR5eJ6yi+u8qaxutuGMFGwaNrgzqwTDdYHwVqZn2VDOgsl1Dl1Ww+Ifh8GPi+hSlQMyJuMhEXHPTFsyLSUX4phEH8VUM+fTMVbF0wN63FkDZsOkrhe6EiqYqnO0TpPldKb31Gn0K3TNVkQZ8I41czZMiFTRzIdteZRH14078j203kbZhYQCOskfhPW1x8PuEBH9vmJuTTwD6Gpe6KXrC98pZ7KK3Lw1+J+nKMnyK6hv/tjB8WRRQkOFmxGjYKFwPM4BKOvaG+7W2QEvKtgc47vdaYuk1Sg5dQHacBi/A7JeJXoged206VGp9NmsLlenGBUZJI3XWGOyhoqWivqBtEKIX85MG0JywFUyit16IxVGiRuTVWThmnDZGfIIYw/HM8WoSl/Mn2xBJrdvFE+NHIcBvArGJNMLnaXrH6m3atORNU9x+Rowry7DxE0nTPMilVH7/wh5g+7eClzsIgBwMyoXN1mCuXKw3LO+/A1QUVeR5BEFWC9+DFFU4AxWyNpsLw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2574.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 690d81e0-c6f5-4200-6d73-08d86b076f17 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 21:24:54.4425 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rDDdGh7YCFm4Lr6SvjfdeBmlCLMwnvG+2ff7jVs6tGg5n7mR0pa69Rc3N2BURafszrVp5XrkGWXuARqDzlzb5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2575 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 18/22] event/dlb2: add PMD's token pop public interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > To: Ray Kinsella ; Neil Horman > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com > Subject: [PATCH 18/22] event/dlb2: add PMD's token pop public interface >=20 > The PMD uses a public interface to allow applications to > control the token pop mode. Supported token pop modes are > as follows, and they impact core scheduling affinity for > ldb ports. >=20 > AUTO_POP: Pop the CQ tokens immediately after dequeueing. > DELAYED_POP: Pop CQ tokens after (dequeue_depth - 1) events > are released. Supported on load-balanced ports > only. > DEFERRED_POP: Pop the CQ tokens during next dequeue operation. >=20 > Signed-off-by: Timothy McDaniel > --- > drivers/event/dlb2/meson.build | 5 ++- > drivers/event/dlb2/rte_pmd_dlb2.c | 39 +++++++++++++++++= ++++++ > drivers/event/dlb2/rte_pmd_dlb2_event_version.map | 6 ++++ Should rte_pmd_dlb2.h be listed in doc/api/doxy-api-index.md, so it's inclu= ded in the doxygen docs? Besides that, and the build error related to the experimental tag mentioned= in another review, this looks good to me. Thanks, Gage