DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>
To: "Power, Ciara" <ciara.power@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/3] test/cryptodev: fix handling for config parameters
Date: Wed, 3 Feb 2021 10:31:04 +0000	[thread overview]
Message-ID: <SN6PR11MB257572802EC3C8B0E16D647DEDB49@SN6PR11MB2575.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210202165816.3767724-4-ciara.power@intel.com>

> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Tuesday, 2 February, 2021 17:58
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Doherty, Declan <declan.doherty@intel.com>;
> Dybkowski, AdamX <adamx.dybkowski@intel.com>; Power, Ciara
> <ciara.power@intel.com>
> Subject: [PATCH v2 3/3] test/cryptodev: fix handling for config parameters
> 
> The crypto perf graphing script did not handle parsing parameters from the JSON
> config files correctly.
> A common parsing function is used for both EAL and app parameters, to ensure
> they are handled the same way and to reduce code duplication.
> Short parameters are now passed with the value being a second argument,
> rather than as one argument with dividing space.
> Long parameters with no expected value are supported for EAL now also.
> e.g. "--no-huge" can be added to config as "no-huge": true
> 
> Fixes: f400e0b82bf1 ("app/crypto-perf: add script to graph perf results")
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>

Acked-by: Adam Dybkowski <adamx.dybkowski@intel.com>

  reply	other threads:[~2021-02-03 10:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-02 11:48 [dpdk-dev] [PATCH 0/2] Update doc for crypto perf script Ciara Power
2021-02-02 11:48 ` [dpdk-dev] [PATCH 1/2] doc: update release notes " Ciara Power
2021-02-02 11:48 ` [dpdk-dev] [PATCH 2/2] doc: fix crypto perf script guide Ciara Power
2021-02-02 16:58 ` [dpdk-dev] [PATCH v2 0/3] Update crypto perf script and doc Ciara Power
2021-02-02 16:58   ` [dpdk-dev] [PATCH v2 1/3] doc: update release notes for crypto perf script Ciara Power
2021-02-03 10:30     ` Dybkowski, AdamX
2021-02-02 16:58   ` [dpdk-dev] [PATCH v2 2/3] doc: fix crypto perf script guide Ciara Power
2021-02-03 10:30     ` Dybkowski, AdamX
2021-02-02 16:58   ` [dpdk-dev] [PATCH v2 3/3] test/cryptodev: fix handling for config parameters Ciara Power
2021-02-03 10:31     ` Dybkowski, AdamX [this message]
2021-02-04 18:27   ` [dpdk-dev] [PATCH v2 0/3] Update crypto perf script and doc Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB257572802EC3C8B0E16D647DEDB49@SN6PR11MB2575.namprd11.prod.outlook.com \
    --to=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=ciara.power@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).