From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7DDEA0A02; Tue, 6 Apr 2021 11:15:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B6C1140FB7; Tue, 6 Apr 2021 11:15:33 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id ECB93406A2 for ; Tue, 6 Apr 2021 11:15:31 +0200 (CEST) IronPort-SDR: xTJqu3SHj6ooJp+oKztvcBjMg2Pr8SUmIjZTOUpDGUs/qGQiLBysfQNqGM/4X0iA7AIt0uCgxy VQ1qSlCdNtfw== X-IronPort-AV: E=McAfee;i="6000,8403,9945"; a="257013507" X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="257013507" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 02:15:30 -0700 IronPort-SDR: hEETSmL8hopleU+W5qSSVf44axK74URUR+xlPtVmxt4JjOKDrB1z/+tD4hUjAaK74FAg6ws4mH PVTCx6k9gukw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,309,1610438400"; d="scan'208";a="457809741" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2021 02:15:26 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 02:15:25 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 6 Apr 2021 02:15:25 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.59) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 6 Apr 2021 02:15:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FMh3jJc6VWeIGhcKQCJdW38pLFm3xmlAgCcEwXk7x7Lwu/up/kuKMvsvbIow8Y9+p37J+Y+2F11Z5OVNewZfrqI+HhEdM863LEz3sSo4Db4QOTdGEb+Q1U7jJg69gMWoV18ydMD1ioaQSpX6oYiMDkaIu9bN+b+omadVPGqxC069m5pOlB48F2xXnB6eOlrgjM5go4JOFz3kRjvBnRtSIi2AO0CtwAqkkz/USqZGdOc7BCuvbhfTs7OLpq9oKMoYQpB2v6Y0BeEI7bENeTUe8zXVxQG6uXyQc9iUESq8ks6WOk7iixNHozkC5kTqZHGr4vJ/uIdxj+U158nCFI2dzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUNeSqkJW1AYMJsfq/ZaD3hHs1Ayt76eQydI25pF1VM=; b=n/RYB8lSU0FkUVvorbYdMYSwOkqLKw8s1GobSLA4WaAMKg97sqgCnxgp0R0ICQd0lTsOrOjgT4X8++t9tPuqzKXk/RJ+Xp1NUrjGzsgUnaVMoLKOrI8/I5pBY+7VAjvcpXj/naSwk4VImV12uvzGu0rMtDWzB+owlx6rGKCDecxQCN2VC+bAFEecoNI55ZcdysPGkAkbPE8bGHVvqZVd72ZBjVW/HC0w4lAJFtuLpqKn17ASDmBOa4mOAisChFOoB3h5IaUpllylA3MQaZs0382u4OQjJEtgZAv1KtZaAHY41vBVL+rmScP6+7yqRb1GdRmvii0YXFGd2Eg3qht7XQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUNeSqkJW1AYMJsfq/ZaD3hHs1Ayt76eQydI25pF1VM=; b=fSaxjXwKNM65YEhtpqhp43ZZVc72DhRQXWsponSx1V4WG1APcdHHaTfhHxwoRWAmVL95XJ27HbA8oUFItu2de+h+FsHu0VDe7dXIARuB68tJ59F8TJ6QV/Xqvcor3pl0rrgHOr57ta8hcZqfUpeYLOZVKa+FZTZUjTV1jlDRAHU= Received: from SN6PR11MB2575.namprd11.prod.outlook.com (2603:10b6:805:57::20) by SA2PR11MB4938.namprd11.prod.outlook.com (2603:10b6:806:fb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.29; Tue, 6 Apr 2021 09:15:21 +0000 Received: from SN6PR11MB2575.namprd11.prod.outlook.com ([fe80::450e:b087:eeaa:2b8f]) by SN6PR11MB2575.namprd11.prod.outlook.com ([fe80::450e:b087:eeaa:2b8f%5]) with mapi id 15.20.3999.032; Tue, 6 Apr 2021 09:15:21 +0000 From: "Dybkowski, AdamX" To: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" , "Kusztal, ArkadiuszX" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests Thread-Index: AdcgGdZT1LyyXAMxQtWE+7ZgU76dDgKM7OcwAB25ymA= Date: Tue, 6 Apr 2021 09:15:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.0.76 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.56] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dd7fd1b0-5fc8-4a81-e019-08d8f8dc8121 x-ms-traffictypediagnostic: SA2PR11MB4938: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NlleywBHxW7JkfjGocrTFP3xbndE6nAme0KZrhUbUE6L+IaPdsU/N4iLlAhWaJopytv3IMRVVi2a0Hp0jffvlvXcYWKYYcf3hxJ5Pti/o1/3M3Z8kAXobEAlztl7B6oneXe8ZrPv2KDXGNftxw+dMg5qjMSpXaaOiK0MIlGVtQpK+3J5ro6FGfLpfIkdNnk9Xd1BYR7eAFutxlfj7C72tSF+PHEh+5yVfzgToF9fod4qkCaUvkzQrKYYC31dGAf6cWlwhPOxihHoGUqMr4DhMD9AlMEfdkqTL+41XRDj4a6vT29w3QFMUp4OPnRvFsAau/VzjTnPpYf7xj/r0nGD1ytxkeb/Gx5uK5ME2PyTPvqKuep6SoovugEARm8DlPiCL2dzVq8pxwaJPmaEA7PQmLeLAuDaJWO+k05KrXmrAntnaekIZMegucygKXL8i/2ZTwDrrcOsn1ae0O1C3bFmQSm5RPpNmEo5eAq3N9WieA9zSJn9KhM1RwcALyRJZTOJV2UC3cM4nfVkTDZhSsY5cDoL2kK422ICsqY1xZrdEdx6WkJfwcF/r8AQU7cENmUXbmw6E+3guIyIVH3tIR+71tgzZSoJTZ8CbUvvD6LARrozAeQwSP6vntdCWHBqtLnVKxEXMasz2nNiaxRQwYRGAv5JYFVPfc9vPuD53hyEkAM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2575.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(366004)(396003)(39860400002)(136003)(2906002)(53546011)(66556008)(55016002)(76116006)(8676002)(7696005)(26005)(316002)(186003)(8936002)(38100700001)(66446008)(66476007)(5660300002)(478600001)(66946007)(33656002)(64756008)(86362001)(52536014)(71200400001)(6506007)(83380400001)(110136005)(9686003)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/bdvL4y/iaxMaNm+5pEa7mjthvLUbDDXuZfe6CrVSUZ1sxW55nJEl/Vystv4?= =?us-ascii?Q?cPlsXE++gRq78jv5rBlq8mTIIQVIJ6/UPAXirJGlbfjLGcqwCBl3Ifx73CR6?= =?us-ascii?Q?2QsnpJ9DiLdJH1OCKItrLsHIZNHOki0A3hUWDqkTdfLtmkmWkxidfQo6H2SB?= =?us-ascii?Q?oYDiU+7vKdWhDZDOPpgw0vQeicdW5t1O1GqGEAzn4P7zkLl+2HQnIb3xbtfB?= =?us-ascii?Q?bCDrTeYjN5fgo611e1KWVMVcQOySXe2jVgQ6rlFIfpMlt49ZFUWyRvieEm+1?= =?us-ascii?Q?SLccKZL5QPJsfbnkgTLk2kzGeomJJa4a/dkEDqwTx3nPE/x/mFg51oHx09UF?= =?us-ascii?Q?/38fHrSgywnEha+ynJvzNROe0e4G19hzl+K/RtAxe3m12/vTvYZnFpDmMuWl?= =?us-ascii?Q?q1gGAXU2Z7UwfDRPt5krcvBKYqGliW9dOAX7LHmEwE0QB9ov9YZniD3sWell?= =?us-ascii?Q?tds+6b9zevkZdGRJ/LF9ClcqCDK0AgyT9wMtFRzlp8gEHPoA/ALung3+vv1I?= =?us-ascii?Q?4WgJmB1aUicnr/x9IEUAfTDy0VuziufFIbus+wbaRH2cjxjJ6O/NTytQAbxH?= =?us-ascii?Q?8ItIgqH3Q20F4xkliIpd8cXRH/YhL2bzfGA7EUas/sPz0xpP9f/vsCeeVWfY?= =?us-ascii?Q?OYrza4vbJDA9d682n+E013wLOrPfdidbyISZfFYmdE/8A54FlDHiTSs+7MZD?= =?us-ascii?Q?pW8qyncUzGUBeyqHnNzRDMXPT1d95/nY9e7sGQC/yGZLZF+Lbzf5T8yE7tRx?= =?us-ascii?Q?SsWB2egMNEbJDhKqrbXV89msKLaqS9uz0U5xBMHlwLfusRT1yPs5fJ0ZkD4I?= =?us-ascii?Q?TPOUkAF6ETlJyiax6H72fn3/Q7W4YW9ApbQv3tzuLQobBZtgtwGjVXgrdFYA?= =?us-ascii?Q?ors1JWU6TZAHvO85Q2DLZO+eBbz8S7w9wG6M4ZB4wCNOBtaUf4l+Wavu99Nh?= =?us-ascii?Q?K3sNMHorQfUMX9QswD8kp/cj+LWIzkEGPFPQ6eF/YWugeyzezJQjq41K45Of?= =?us-ascii?Q?SpONjd9bkf83sW5JOzKMJrvQn3lmXF4dF9Xr4nvJjHqxf0sdEKwDHlWgqnqt?= =?us-ascii?Q?htswbMjJYY6FsFhPYpG3nqs0KwVOc+PcBdU7J4tUNoC4L8RAvmNnACddt1c/?= =?us-ascii?Q?9Vu3x9vCOUhZSkBykMKHxn8tSraytA6n4bh2YD+jMO1EgwmhUmayxyOktQ+A?= =?us-ascii?Q?UEPyvX4YgrQHvEhEtqOU5802mzKsrq3uT20FFlBMapTTK5LnP9pcrwQHMY8I?= =?us-ascii?Q?GIQOWQKtb2quf9GXO3iRUyq1pQhpQWEl5sLHtujJ7AcUr29ib30k1FY6986E?= =?us-ascii?Q?oyM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2575.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd7fd1b0-5fc8-4a81-e019-08d8f8dc8121 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Apr 2021 09:15:21.4330 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b94wFiacjoe2T2KnoC778rY4mxnojAhGOmXmWexcQkQeIfe7kXs7z8MPFFknJQ85BJ6sVb7NmQI7Inva5kOUupbVcSxivCQUNWi06EfU19M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4938 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The pmd is initialized in the setup function. This patch adds one extra step inside the teardown function: the call to th= e rte_cryptodev_close apart of the call to rte_cryptodev_stop function that= existed before. I don't see any sense of calling the stop function inside the setup, in my = opinion it's much better to do it during the teardown. Adam > -----Original Message----- > From: Akhil Goyal > Sent: Monday, 5 April, 2021 20:59 > To: Akhil Goyal ; Dybkowski, AdamX > ; dev@dpdk.org; Doherty, Declan > ; Kusztal, ArkadiuszX > > Subject: RE: [dpdk-dev] [PATCH v2 1/2] test/crypto: close PMD after tests >=20 > Hi Adam/Arek, >=20 > Could you please reply to the below query. >=20 > > > This patch adds closing of the PMD after running the tests. > > > > > > Signed-off-by: Adam Dybkowski > > > --- > > > app/test/test_cryptodev.c | 6 +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > > index f91debc16..ea965a64a 100644 > > > --- a/app/test/test_cryptodev.c > > > +++ b/app/test/test_cryptodev.c > > > @@ -928,6 +928,7 @@ ut_teardown(void) > > > struct crypto_testsuite_params *ts_params =3D &testsuite_params; > > > struct crypto_unittest_params *ut_params =3D &unittest_params; > > > struct rte_cryptodev_stats stats; > > > + int res; > > > > > > /* free crypto session structure */ #ifdef RTE_LIB_SECURITY @@ > > > -976,8 +977,11 @@ ut_teardown(void) > > > > > > rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats); > > > > > > - /* Stop the device */ > > > + /* Stop and close the device */ > > > rte_cryptodev_stop(ts_params->valid_devs[0]); > > > + res =3D rte_cryptodev_close(ts_params->valid_devs[0]); > > > + if (res) > > > + RTE_LOG(ERR, USER1, "Crypto device close error %d\n", > res); > > > > Shouldn't this be part of testsuite_setup() instead of ut_teardown()? > > In cases of vdev, devices are initialized as part of testsuite_setup(). > > > > Should we also call rte_cryptodev_queue_pair_release from > ut_teardown? > > > > Regards, > > Akhil