From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 803FAA0A0E;
Tue, 11 May 2021 11:20:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 45A9440140;
Tue, 11 May 2021 11:20:23 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id A00084003E;
Tue, 11 May 2021 11:20:21 +0200 (CEST)
IronPort-SDR: imq7//JXInxWCvOmxrLOA3c8D2ZKGpFvxcqSz/chJu2R+uXEj7uejRlF172my/AEv3DTsSUYqD
CU0nvzntESGA==
X-IronPort-AV: E=McAfee;i="6200,9189,9980"; a="178989428"
X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="178989428"
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
11 May 2021 02:20:20 -0700
IronPort-SDR: r7+Trpy8R2w6smnNK/fHXQn1H9qLwWkf65YyaTBmE2z9kGC985GxE0zzwteAhbyCVdQCoK9CqN
Lx+Or1L5cqww==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.82,290,1613462400"; d="scan'208";a="461836512"
Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82])
by FMSMGA003.fm.intel.com with ESMTP; 11 May 2021 02:20:20 -0700
Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by
fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2106.2; Tue, 11 May 2021 02:20:20 -0700
Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by
fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2
via Frontend Transport; Tue, 11 May 2021 02:20:20 -0700
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176)
by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2106.2; Tue, 11 May 2021 02:20:20 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=PK4JbTxtBKM5uWF2xrLPiAzZrWDplz0IPCvEBd/ChpLInvcORuYjvzcP3A3c29l1oRA0wVRm3J2JiE+e+xLzo8N4Q6WYMBL6RhFo01ViS5aebDBzX0MfyOBp2UPI7778rkBD78LWsG9e6LOos6N0qTQwMIPVqQxlk8OFmBPyysFK8Y31+D/P/JJtVOp+NT1hauhTmWMYKBL/ccmhgB64s6iWb+mipnBieiBACqThLNt+o2jVvuZRm4VJDAU6DxU6OinSLaJDO1BPLvi8kGg+dWN+xgc5vjmcSzeKHC01dUzpJBPDjtYhASoCh0m/D/Io53kqbao5X2wDG4OF46CUWg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=zb4gy6L4Ca04sibP25TtceAA+Eg3WsLlP8EhlcjQdHc=;
b=eZhO/hq7BwTTajAdcnoiDA7L+qW//YdQvLVuE79zbgubRKUMoZ1DXuQvHTD6cfmuWVsiFeGjZdD9J017YPehm49cBz76ymKJElsWPitjshRD7rPnM1y5Ayn0p/Z15rLkTK6eWIuQIBkE3Ic9jWVKQhl2AowIAMbiys9YYZ0qx0SN4NhzelSPowoo4O2Jn879uqKuUQTaWb800hp4W0C3DvPtJjKu4gCigLL8PgMuIpGwmnjNKw1Uk6EWCtqz3FEiO5MfRHD7AHzTicJKRQZS8XvvPE/LTMWCujMsuY+IR3oAKItWfKtluiPTjT1UdrB0OyMuoJTtX/wvZW8BSgKScw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=zb4gy6L4Ca04sibP25TtceAA+Eg3WsLlP8EhlcjQdHc=;
b=cKTrr7hQXYvJV9YW4iqoXzQMh9VhM7VVsPN2VlUhdxg6uZTRVQJ8c0JEoh9ZSUXNsqO/PdcZd7155jzHiA1IpTvtIdehpFNjZ2LFHc1MSS3gHi9+uRC4cSMPTq6HlM1Mb+8e+fa44pa9DG1nHOL8IOPpr+GOdMmmpObMOiV+nBU=
Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15)
by SA2PR11MB4841.namprd11.prod.outlook.com (2603:10b6:806:113::18)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25; Tue, 11 May
2021 09:20:17 +0000
Received: from SN6PR11MB2621.namprd11.prod.outlook.com
([fe80::50e2:3791:51f4:fc8b]) by SN6PR11MB2621.namprd11.prod.outlook.com
([fe80::50e2:3791:51f4:fc8b%5]) with mapi id 15.20.4108.031; Tue, 11 May 2021
09:20:17 +0000
From: "Rong, Leyi" <leyi.rong@intel.com>
To: "Zhang, AlvinX" <alvinx.zhang@intel.com>, "Xing, Beilei"
<beilei.xing@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v3] net/i40e: fix offload flag checking in simple Tx
datapath
Thread-Index: AQHXRkIIr4qRCMkaMke6vrbXjugmsareAMqQ
Date: Tue, 11 May 2021 09:20:17 +0000
Message-ID: <SN6PR11MB26210A70D901B5FF87BE998EEC539@SN6PR11MB2621.namprd11.prod.outlook.com>
References: <20210511023926.27296-1-alvinx.zhang@intel.com>
<20210511084531.34044-1-alvinx.zhang@intel.com>
In-Reply-To: <20210511084531.34044-1-alvinx.zhang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [192.198.147.193]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e03b9741-be2f-4436-df3e-08d9145dfde3
x-ms-traffictypediagnostic: SA2PR11MB4841:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <SA2PR11MB4841F22B3D41E9E172B72A8DEC539@SA2PR11MB4841.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:1122;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: 8LjO6hv5SNzJm8UlW/Cjb8no+u3f4ZE/9hl3gApeW1l5WZ3J+b5Eb3H+x/g9Pp7IN6Hzy2lJnkGpVSGjjl6q3mBxgqU7bxdVB92zaCtwQucmRbVdai9fs16hCL+iJ++bN989XjrqcmUJ+mvXqpRkNmcXtZGNHiaH0W3lGxjkqHp1pozIjh3ahygJ+7JWLymYvKIBMaSb0wWzyXB71VpjOfzNMcgbZOiJcXDL861RwjtVCx9zzMttIXvF1WcfSvIjYyASZcSZXFNC8Kv+dGlX+ZX32M92pSDKlPnBwFAnTXKJMyemDJCac2w7IqHDJiqcwLrOg2dj+kaTx2NisLhSeKEB6VNjnrss0S6cLVtc2HEBfqg6yQU/2BPFFKa6HTz1bC+WHGidTrKfznE9ijxMtg20z87d9tExkulTlvODigwX2dxyd+yRwjDxX6ChpgegYnG8D/l6HJ6P+lJq6k+oapG3vwVcJAinWcHosBxGTPcK/LUfhRSalsOEn6Z4EqdWXlFj7TfMRc06bHpHS5ZaJPoRcMRsUobQ075E/yQ+HBHz8BIf/xKQacVv3UZC3Cn5vlp6ES2F58CN9wDPscFL9w4dHFB0oqnKusO3pVKxMPE=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(376002)(136003)(346002)(39860400002)(366004)(396003)(2906002)(186003)(54906003)(8936002)(66476007)(66556008)(71200400001)(8676002)(110136005)(66946007)(450100002)(86362001)(64756008)(52536014)(66446008)(9686003)(83380400001)(4326008)(5660300002)(76116006)(55016002)(7696005)(122000001)(33656002)(38100700002)(478600001)(26005)(6506007)(6636002)(316002)(53546011);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?/fBhyFxPXPYuxLaduHfoMlugmi+6NRXFRFp11l3XL69aSTm4jCtEbDND/eLf?=
=?us-ascii?Q?rP0O2RPQlcwQh9ms8DQ1XeC2EJkBP4cPGMsImelCLM851iKQYEraxp53uUot?=
=?us-ascii?Q?enMFhsLc0vY/CF5xZbpT3iZvGw5U8XSytSFhMRlV+lqxVySfWeIk2mMoUbec?=
=?us-ascii?Q?/zpaHT8AK5ZRqaMBHlv0q4X4671n83V0webkTM7rlywoKAbR/LZFgzBjzWp5?=
=?us-ascii?Q?Eh6D5q0aIt74SRsEC91uXvFzmUrshLX9Pu1X8Zibnj/AjNmV3IpNMDJV1WTV?=
=?us-ascii?Q?WXZ+t85fArEYKwEFvfKHI586iG0hboIGgMxbR2yFIUJDIx8boibpSkOLpgoS?=
=?us-ascii?Q?RWYCYd90qkUkZWwMQRN5Be4hzIeF41h5Tc7esU6lFhKmGgj9Mrlrjfy/Z76z?=
=?us-ascii?Q?GU5765334FutLbqzbdfoBA6gb1K54s8WojGNuQc2gxboUdNxt5PLK4yq5Je5?=
=?us-ascii?Q?CBuWGv0aTlngcZ3XEg+o5BfYTIk8bqhd4p+N1qPEktIW5yVLiiZd+6FK2jRJ?=
=?us-ascii?Q?igCk0OT/Evo8qliHgpF2yTCsOYeio4+fv+J4OYJqiKZscTTM2lDSxTUf2lRO?=
=?us-ascii?Q?sT2fgKJZ+uXC39nJ17q1ZYuoyCFXOCB+H+EOW5PyWs5HoSPCWOrj6FytRr2e?=
=?us-ascii?Q?CitRHYyotLU3Qg6lVduKJ1DFzy6/26M20GKlbFmDGyR85Bul3ZL6SvkVFfKX?=
=?us-ascii?Q?WoWAHUDkvVB77qsc3LEA76s+29onyqhNvlJNO4kJE1+QKs1NXokU2XX6k1il?=
=?us-ascii?Q?d0p7qwQu6l5YFRtEGgETrh2N0/0ys/xDE70+zci8qVJy3r9WRMvSRMKDdAOw?=
=?us-ascii?Q?0BGwk2jxj03KQ08MDgX+T4UPVzk0+UN9sbsgy5Ex5U5xabsiunAqrFRNYu8Q?=
=?us-ascii?Q?TPZGl9Ur+m4qEX49XMGJEX07WFYki8pSkJTNrjZ5umgIiTHIkEpRKAc3Nn/N?=
=?us-ascii?Q?kJStxcoke1JtL/5K7azU6mMDzmjs9WLGjMn3ounnh3ouAFktXc7HeLA0Rv1v?=
=?us-ascii?Q?roiwNIv2qhvii9Q6BV81W3CFzh53uX5kFqoDx4OCRWx4FDmg8gAGArOyTCIX?=
=?us-ascii?Q?uATiatV10oeBk4XANV3v8c1Uq2XtltMEA0D+Ja8uvr3iaRsGutnvCHFDWw5m?=
=?us-ascii?Q?KyHEOfqmVPZXJDjlNRm2OqFVweAhLQgh7My20LvyzhAYZrRJa0cFRRQWr6Eb?=
=?us-ascii?Q?P88j2CE4gle0FmKGoR6eSNtt4BX6QBPaT4iWNSl7+YnCTbQmOtEHDIrk/ws+?=
=?us-ascii?Q?DBUWfDy4QBGGHFa+kKkvbciM+YLYNU7wHYR4blPgIdG+LJnqRaWY/yCy46iI?=
=?us-ascii?Q?jhCaNSjmM2lC7RvxYJ1XiCbv?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2621.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e03b9741-be2f-4436-df3e-08d9145dfde3
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2021 09:20:17.2170 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 1zyi1yQVPftULysE+bAf4+nNMMiI5Zfq86I/itBGcv4B8g4hy5kAmOIAm33FVXdag89HuGiqG5qQc7LXG4OIMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4841
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix offload flag checking in
simple Tx datapath
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Zhang, AlvinX <alvinx.zhang@intel.com>
> Sent: Tuesday, May 11, 2021 4:46 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Rong, Leyi <leyi.rong@intel.com=
>
> Cc: dev@dpdk.org; Zhang, AlvinX <alvinx.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH v3] net/i40e: fix offload flag checking in simple Tx data=
path
>=20
> Tx offload flags 'PKT_TX_IPV6, PKT_TX_IPV4, PKT_TX_OUTER_IPV6,
> PKT_TX_OUTER_IPV4' are supported in simple datapath.
>=20
> This patch removes these offload flags from packet checking in simple Tx
> datapath and defines 2 macro I40E_TX_OFFLOAD_SIMPLE_SUP_MASK and
> I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK.
>=20
> Fixes: 146ffa81d05e ("net/i40e: add Tx preparation for simple Tx datapath=
")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> ---
>=20
> v3: Update codes according to comments
> ---
> drivers/net/i40e/i40e_rxtx.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c =
index
> 02cf5e7..337916b 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -72,6 +72,15 @@
> #define I40E_TX_OFFLOAD_NOTSUP_MASK \
> (PKT_TX_OFFLOAD_MASK ^ I40E_TX_OFFLOAD_MASK)
>=20
> +#define I40E_TX_OFFLOAD_SIMPLE_SUP_MASK ( \
> + PKT_TX_IPV4 | \
> + PKT_TX_IPV6 | \
> + PKT_TX_OUTER_IPV4 | \
> + PKT_TX_OUTER_IPV6)
> +
> +#define I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK \
> + (PKT_TX_OFFLOAD_MASK ^
> I40E_TX_OFFLOAD_SIMPLE_SUP_MASK)
> +
> int
> i40e_get_monitor_addr(void *rx_queue, struct rte_power_monitor_cond *pmc=
)
> { @@ -1501,7 +1510,7 @@
> return i;
> }
>=20
> - if (ol_flags & PKT_TX_OFFLOAD_MASK) {
> + if (ol_flags & I40E_TX_OFFLOAD_SIMPLE_NOTSUP_MASK) {
> rte_errno =3D ENOTSUP;
> return i;
> }
> --
> 1.8.3.1
Acked-by: Leyi Rong <leyi.rong@intel.com>