From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99F2DA04B5; Tue, 27 Oct 2020 16:39:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 453C772DF; Tue, 27 Oct 2020 16:39:22 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id D66B76CA9 for ; Tue, 27 Oct 2020 16:39:19 +0100 (CET) IronPort-SDR: Y1M1E0nBetYXmBeTfIpp1XTNOVbKVTFIrBP1V1B5c/NRQTYzpHj0U/9kGkOlUeuLHWiHsYVGnX NDbPR2BPZEnA== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="147388138" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="147388138" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 08:37:04 -0700 IronPort-SDR: in2r0cZgRDU0DG/c3DawxTB2gP5NgLvqZLve/bhPc3LMxmyWREHMIPHpxjwBXQHnjcJEAckw60 cPdtriR+s8qg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="424442960" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 27 Oct 2020 08:37:03 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 08:37:03 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 08:37:02 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 08:37:02 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 08:37:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c2Wbdmx3QfOR1PsKmP7gnB79CJ56+sP3wtXzCeAVdVOzln47fVKhLUgUGrNvXIBn5cqdIR/inwITvf47PGnpgqmQFM6bIEBKJ8dH8EsTxNPnUx7Qk6QRsE+0ctIhS5/gunXxq9w0fIlIFxSZZpf7LxPJVh/euqOrN4BC1Faz2f4Oe/fYGUelsgCz/SFw22ZMVMKY5qdTaOqlhWpdPlodzXYLlF0cULaVOMLTNbUo6bVLS1IPqdrUboEFoDL3Ub93+CBConzLYgaBvFjpCmb18K8X6RLViS9m/ePrlB7bGuOET9oAtEt6v6i/0NE0b2ZYx0lXXRDmn1mU3/YO58uNVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X5cJhHpafiW0J95INagp0Jvr8qyda22J9l8+RTWjpP4=; b=OW3g6leNFYi0RFNGvLiXVLKmbsgv4C4uVsLLCRE20u4MixhZ6tzCOAUBCPwVY40w6K3FjeczMMtcvAbirHT7WT+u/k4H5kE9vswtpqIKDTjU1vO+6CDkFGfMCNMiihH2QdAumcSYsmWJCmeAevWqLmqXF0wkX1pCb7EUNKS1x2yPldVXf2d/HM19XCQD6Zr8HE8YIgjldUTtG1c9UCFl2CypojOm6ox3kjlWV69GTR8aWyp62kD/mDLgKF3jASvrmTZHGWwXaDs+N03F1/rl/d/EOaDGbOFtE2oM6DCFhAlW4bNs5vM8z278n8GOY1BfJwRLzY51UTPq8ULplCiLNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X5cJhHpafiW0J95INagp0Jvr8qyda22J9l8+RTWjpP4=; b=tfKdcdSOwjGGLytF6e9Yig3NFPSXSiPLokkxdyTeYSWdEVyjgpEXEUhDHUum6Bx2sHlw/1wy6JlUrLMQgiJs8lO2pTGN8vPoZvCes2FFU2aqfwbYg6so1WhfYQPyq3+dxFLwPM5xDm0YFCGFmmvhDiQBQ9a0JCH4PcxxuqV0HEs= Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15) by SN6PR11MB2736.namprd11.prod.outlook.com (2603:10b6:805:5a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.21; Tue, 27 Oct 2020 15:36:58 +0000 Received: from SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::9d62:7ffd:9b77:1f4]) by SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::9d62:7ffd:9b77:1f4%3]) with mapi id 15.20.3477.028; Tue, 27 Oct 2020 15:36:58 +0000 From: "Rong, Leyi" To: "Richardson, Bruce" , Ali Alnubani CC: "Yigit, Ferruh" , "Zhang, Qi Z" , "Lu, Wenzhuo" , "Andrew Rybchenko" , David Marchand , Raslan Darawsheh , "dev@dpdk.org" Thread-Topic: [PATCH] net/ice: add AVX512BW flag check both in build and runtime Thread-Index: AQHWrE3sUZorQQc0HkGnqb9o0fZ966mrV/QAgAAVCgCAAARUAIAAInDQ Date: Tue, 27 Oct 2020 15:36:58 +0000 Message-ID: References: <20201027101926.112609-1-leyi.rong@intel.com> <20201027132750.GI936@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201027132750.GI936@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.209] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ca53aa8-a71d-4df7-d772-08d87a8e2425 x-ms-traffictypediagnostic: SN6PR11MB2736: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xAn7oW4Iv/JDLiWcaaAYbKH0RBvTO1WK/A0biP5Az+mVEc+dGk2oksMAlV9lgFUbFVRMCHAyPaQ3lZKbX6Jie8p88dmkXtnz/4SBIPQaQCWkMk2kxbupu2LZzJ5vUDRvMqxPY7hdQmgTgaCVciYu3x6pUjDlOxPnYC+7GpQeiDAiJFX4a2/qN92cczst5HAsBBSjicqnQhqNXqra4jiKy9RH0e6FKTxbSqo/Msb14Gba7sivaXTQGePGezMpS4aVrEkhVDnE8g0LYIp4gvf/nsFnjuH69t7IwR+gP1KvJUuhecpsy7DBHn3vXJgUyo2z1kEDrNVq7ET3+8cafh/AIg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(376002)(346002)(396003)(9686003)(186003)(86362001)(55016002)(478600001)(52536014)(5660300002)(316002)(2906002)(54906003)(110136005)(76116006)(8936002)(8676002)(6506007)(33656002)(66556008)(64756008)(53546011)(66446008)(26005)(71200400001)(66476007)(4326008)(7696005)(83380400001)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: f05InLzN7RYNz8P96R/cttC5VGJXF4AG64WllP1GsjFOdtU826gqeag1H28Hpqf+/fdxvI+RzzTbj5q5cZ6Ftxw5uL8ck82QPlUm2bV+Rwle2wh5yPxLTzGZGu395x8aT71KSpWYY6KVQn3gj7K5DqCWqi9MG/pWbZ9R8XNO794IWVZ2ayacuTlsEcOesjSOnXQ44lJEBQpHkvnQVJt6vUlJ7d5TIwzP8Rl08Q0u0BK37ErwRyPASU/jj1CF5wcxQAw/iKFa5ITvWdhTodi48mVTjm2ysU4n5Amsy/ECZb3M17Q9y2uYfomtM6zcZ/W+9zXSX+g/5aM5WacXvs/EaubCVc4nmPbFQUWN3veZsw7gAd6rN4e/M1vLEcczGqhuzQ4ikEbSG1QXqeCN6UuSflZrm4KxKaCnwF2SXPm1YcvJyDoH4VarJnZ7oxnZ/8ngIj7+xQN+umler7R+v6GI1ovXnNmos2V7JOdJ2WtjDjTgGQ4pUllIv9/fiTRinwyOTvlRsDffxTTDcg4gzPKJkWFKLSpDbRHLLR4mWUuAl6phJoS6LAwxMuUqPIlEe4HL+s0LUSFLV0CI49kmvWVLDJLyMbyrqa7j8kXpygAad9IFhJgAAwEKGQy9yPZ74oj32ZdXJKA0sW3N1jJS7wWx2A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2621.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ca53aa8-a71d-4df7-d772-08d87a8e2425 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 15:36:58.1960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0R/N9MUVPDdNpj7+honK6BNsNIZgs2N7/oW7+3sKj4eqvDcuAx04IR/Tip6W/nMSOyQoNXdfgL4IRuF2h/95/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2736 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] net/ice: add AVX512BW flag check both in build and runtime X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, October 27, 2020 9:28 PM > To: Ali Alnubani > Cc: Yigit, Ferruh ; Rong, Leyi ; > Zhang, Qi Z ; Lu, Wenzhuo ; > Andrew Rybchenko ; David Marchand > ; Raslan Darawsheh ; > dev@dpdk.org > Subject: Re: [PATCH] net/ice: add AVX512BW flag check both in build and > runtime >=20 > On Tue, Oct 27, 2020 at 01:12:20PM +0000, Ali Alnubani wrote: > > Hi, > > > > > -----Original Message----- > > > From: Ferruh Yigit > > > Sent: Tuesday, October 27, 2020 1:57 PM > > > To: Leyi Rong ; qi.z.zhang@intel.com; > > > bruce.richardson@intel.com; wenzhuo.lu@intel.com; Ali Alnubani > > > ; Andrew Rybchenko > ; > > > David Marchand > > > Cc: dev@dpdk.org > > > Subject: Re: [PATCH] net/ice: add AVX512BW flag check both in build > > > and runtime > > > > > > On 10/27/2020 10:19 AM, Leyi Rong wrote: > > > > Intrinsic function __mm512_bsrli_epi128 should be used in the > > > > environment which supports AVX512BW, so adds check for this flag. > > > > > > > > Fixes: 5dd3b8f3af34 ("net/ice: add AVX512 vector path") > > > > > > > > Signed-off-by: Leyi Rong > > > > > > Squashed into relevant commit in next-net, thanks. > > > > > > > > > Andrew, Ali, David, > > > > > > Can you please confirm the issue is solved in the next-net/main? > > > > > > > The build failures in CentOS 7, Ubuntu 18.04 and in OpenSUSE Leap 15.2 = no > longer reproduce. But we just noticed that Ubuntu 16.04.7 (gcc 5.4.0) is = also > failing with a different error: > > > > """ > > drivers/net/ice/ice_rxtx_vec_avx512.c:1:0: error: bad value > > (skylake-avx512) for -march=3D switch > > /* SPDX-License-Identifier: BSD-3-Clause """ > > Which is also caused by "net/ice: add AVX512 vector path". > > >=20 > I think we can drop the -march=3Dskylake-avx512 flag in the build command= for > the avx512 file, since specifying the -mavx512f and -mavx512bw should be > enough. Testing in an ubuntu 16.04 VM (which has 5.5 rather than 5.4 > compiler, but should be ok), shows that the avx512 instruction set flags = are > recognised and enable the isntructions, which the -march one is not. >=20 > /Bruce >=20 > bruce@ubuntu-1604-vm:~$ gcc -mavx512f -mavx512bw -dM -E - < /dev/null > | grep AVX #define __AVX512F__ 1 #define __AVX512BW__ 1 #define > __AVX__ 1 #define __AVX2__ 1 bruce@ubuntu-1604-vm:~$ gcc - > march=3Dskylake-avx512 -dM -E - < /dev/null | grep AVX > cc1: error: bad value (skylake-avx512) for -march=3D switch Hi Bruce, Drop -march=3Dskylake-avx512 really impact the throughput performance in my= test, although -avx512f and -avx512bw are set meanwhile. Could we add a judgement before setting -march=3Dskylake-avx512, the judgem= ent can just like=20 if (toolchain =3D=3D 'gcc' and cc.version().version_compare('>=3D7.0.0')) Leyi