From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 929A4A0521; Tue, 3 Nov 2020 15:16:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 76916CAC4; Tue, 3 Nov 2020 15:13:38 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id D3E86CABF for ; Tue, 3 Nov 2020 15:13:36 +0100 (CET) IronPort-SDR: E0JdQGtKAlegGN96i5v0K2RWNoIEJHo3nU5NBgJuRuz1F+5MEwAv03qFJCE4CZCWsI7RFUV4pJ C9Ae6iPSQvZA== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="253766451" X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="253766451" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 06:13:35 -0800 IronPort-SDR: 5wGp+yG5eis4Eiv9tNRCi4ESD//fZHMSGhUj+O9QENgXVy1dXacFiUMv17SfQPfmykUWtrPQnu 3Wdns5OUKNnA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,448,1596524400"; d="scan'208";a="357689464" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2020 06:13:34 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Nov 2020 06:13:34 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 3 Nov 2020 06:13:34 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 3 Nov 2020 06:13:34 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.54) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 3 Nov 2020 06:13:32 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HNxUViqNO+8IlZa4lxQ7nPt7yyYNu4oX+UflD8k6zUQTaGdiT/D7ZOA27SgIv6CckcJZ1jqxLCDzuYYZkc1CNqwanUMWB5tYJ0n6l3XxRQeA1TfGhkCSh5QLkpBF38dDzp60nILImK9O3rPfW6dbBW9oOHmjRY0mNJBOJFhV7qQAi6YjZgHnzscy8gqx7Go4cQS9+AQURHZCgZn4AgcATpHD08ePZplbggWOIQopagWhnEQt4vjYbfP1KCLmON1pHFZkNvcxO+wYrOfrQutyXmSSYVB21AEQfAny3QUrW1UoycmiEl7rgSm8Ubj/PVS6Iv1yvnMsZ1iHeIT6lQWpEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3rP8CM9CGl4jZthYPSD+ytY/bsmhum5zcDrMQMAL7eY=; b=F5fUmB6WHp6YDu2M/n7j2mAwFKu+gAKZgMPRpPjWJ+u8z3YWLgRD9E9nBkEGk840FhydLxGq8HzCKmrcGWuSGPjqevFFDM4PCSeMWkmgZTRLgLVMRiCx06frIjk/ctcqbI7dAd9+MQjSDY5dkwogsXHWl84hVvrU2FakVrvTbI4uN4jpna7EWTBGGYxbSrIEE3t9oC2IvKlTAJN8grqTTohF2UVgl26OjBKdwOi/nP/Q6jJg60dZna2Cmnsupxr18GTqZl4oMlcFBBUxK1hymfpod3tww4QRaalrfo+74pojvuLnwF7I/zbpNAoQHSPjhABACOxtqRLzJurW2UVU0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3rP8CM9CGl4jZthYPSD+ytY/bsmhum5zcDrMQMAL7eY=; b=iX+h6eXAnmqqfu/bovIN8FZfp6fGkj4uEneZ32x588ni8iv9HiQjb30l7ZDnbMHEL91KUOWBI6b0VLUxy9XR9bCN6hd6I5i2GtAjsCLTD/F8Cmjr7gATTTgGDlMyrUkAIlFFk3oRynng4wjz+/2lCU7yAuYbvJRBZICdFDkEhFg= Received: from SN6PR11MB2621.namprd11.prod.outlook.com (2603:10b6:805:59::15) by SN6PR11MB2638.namprd11.prod.outlook.com (2603:10b6:805:58::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.29; Tue, 3 Nov 2020 14:13:31 +0000 Received: from SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::9d62:7ffd:9b77:1f4]) by SN6PR11MB2621.namprd11.prod.outlook.com ([fe80::9d62:7ffd:9b77:1f4%3]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 14:13:30 +0000 From: "Rong, Leyi" To: "Richardson, Bruce" CC: "Zhang, Qi Z" , "Yigit, Ferruh" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC Thread-Index: AQHWseQig1cll2xC4k+Uvfc8kmtVkqm2ZogAgAAMbrA= Date: Tue, 3 Nov 2020 14:13:30 +0000 Message-ID: References: <20201103125629.56030-1-leyi.rong@intel.com> <20201103125629.56030-2-leyi.rong@intel.com> <20201103132804.GC1144@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201103132804.GC1144@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.193] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 823e3a44-d980-45cd-e229-08d88002a46e x-ms-traffictypediagnostic: SN6PR11MB2638: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /eXBiaZDLr67rt8g178DvvfEUT3iC/CkPUpw35a+EW3dofflySJvs16tgAz1cXC+kutZbjekeSF1z2n1i5aPBFgDIKpcpit6jfJ6d/bO0j1+HJ1IwMwqOIXx+re14uPUkG0KpVYLY3k4D20lM09z1CWX7UGGLkk7he1++gew5ZlfXxM45V0+9MNaDBdqf0sCEqFtaD08smNdtMlh8+PW+60AZYJyizoS8qEFCxrAQOi09Px7vpiotw1Wxgl+oj/qg8ZDFVBzZe43VQ9QK5j7qYrJnb6wVcnvO4nzIvFw2ToSxBhd54upIbvwZmjjPP5WvlS9qHJ3drfIWIint2ssUQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2621.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(396003)(39860400002)(346002)(136003)(6862004)(7696005)(55016002)(53546011)(52536014)(86362001)(4326008)(33656002)(6506007)(9686003)(26005)(478600001)(66446008)(316002)(66556008)(5660300002)(54906003)(8676002)(66476007)(8936002)(83380400001)(6636002)(71200400001)(2906002)(76116006)(64756008)(66946007)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +9wd8Z69/sB+loFY46AOjqMcJGdnkpgMomupE6VjERKUMJHeeyuuPHVixUi/nIu0+WaUWwsgbk/+8rAJ32iyqypiA79GmlTP/B4ATKr4UWElszpnMQR3YhiJVQI4hvui1OdgtV+CYuyoqoHocyd3BMe+0YHF4+urxqwSj6VVg4Czdka8RypK9sn03S93qbAXjmvmeD4l7yNfeWzAgLMHSiwV5DAOSeAR11RzoIQGEiVCPlLFyWRLpdFec2HhmmbmxNua0Y6WQB5L6wl+hh/ZdN3iyljJ4a3wvda1sxV4Dpis0Oli1akdormArzLo9Cra+z3bRxtcr+3yLhZXQGqe2MsDLrFadxDHzp1zwPTDyheG+yS7QZ4m5dbshLDJy9OTJW0uFqUDzrNX+y9JX583CVFazq+gR6CAzGyoyOXfhFkaW/rxVj5/WKSmX9RITuat2A62dvUDXh8SzBUlmx7WWBU8q35lDtxuKhXWJaL8I1blXGwO7PKAxAz3JE3XSS7DtpyP7XQWN2N95sF2YfZlE3UiBiSHkl7wM2m8x/CDn3n7c0FK42Yj+0+iaE3411/z+pFYJe+riJq5bbQf5N/oAGAl2q6hqrXuVbkVRqSPh/1LjHgqcXq4b6T7IIcTM6SKDdbTYkFhpNswTx1HeAu+3Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2621.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 823e3a44-d980-45cd-e229-08d88002a46e X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 14:13:30.8576 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FC5UIuK+RmUKVUgIylXsFSmr+MNuM4xtYU2QyYtd8l0w4gIbil4zvM076AlqTBC/K9Bks+1qdSRNUDZYoHdioA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2638 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower version GCC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, November 3, 2020 9:28 PM > To: Rong, Leyi > Cc: Zhang, Qi Z ; Yigit, Ferruh ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: fix build error on lower ver= sion GCC >=20 > On Tue, Nov 03, 2020 at 08:56:28PM +0800, Leyi Rong wrote: > > Fix the build error when -march=3Dskylake-avx512 is not supported on > > lower version GCC. > > > > Fixes: ef5d52dae5e2 ("net/ice: add AVX512 vector path") > > > > Signed-off-by: Leyi Rong > > --- > > drivers/net/ice/meson.build | 21 +++++++++++++++------ > > 1 file changed, 15 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/net/ice/meson.build b/drivers/net/ice/meson.build > > index 7d54a49236..ec8933aa1a 100644 > > --- a/drivers/net/ice/meson.build > > +++ b/drivers/net/ice/meson.build > > @@ -46,12 +46,21 @@ if arch_subdir =3D=3D 'x86' > > > > if ice_avx512_cpu_support =3D=3D true or ice_avx512_cc_support =3D=3D= true > > cflags +=3D ['-DCC_AVX512_SUPPORT'] > > - ice_avx512_lib =3D static_library('ice_avx512_lib', > > - 'ice_rxtx_vec_avx512.c', > > - dependencies: [static_rte_ethdev, > > - static_rte_kvargs, static_rte_hash], > > - include_directories: includes, > > - c_args: [cflags, '-march=3Dskylake-avx512', '- > mavx512f', '-mavx512bw']) > > + if cc.has_argument('-march=3Dskylake-avx512') > > + ice_avx512_lib =3D static_library('ice_avx512_lib', > > + 'ice_rxtx_vec_avx512.c', > > + dependencies: [static_rte_ethdev, > > + static_rte_kvargs, > static_rte_hash], > > + include_directories: includes, > > + c_args: [cflags, '-march=3Dskylake- > avx512', '-mavx512f', '-mavx512bw']) > > + else > > + ice_avx512_lib =3D static_library('ice_avx512_lib', > > + 'ice_rxtx_vec_avx512.c', > > + dependencies: [static_rte_ethdev, > > + static_rte_kvargs, > static_rte_hash], > > + include_directories: includes, > > + c_args: [cflags, '-mavx512f', '- > mavx512bw']) > > + endif >=20 > Rather than duplicating the whole static_library call, you can just do: > avx512_cflags =3D [cflags, '-mavx512f', '-mavx512bw'] > if cc.has_argument('-march=3Dskylake-avx512') > avx512_cflags +=3D '-march=3Dskylake-avx512' > endif >=20 > and then use avx512_cflags inside a single static_library call. Much shor= ter code. >=20 > /Bruce >=20 Many thanks~ Fixed in v2 patches. Leyi > > objs +=3D ice_avx512_lib.extract_objects('ice_rxtx_vec_avx512.c') > > endif > > endif > > -- > > 2.17.1 > >