From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEF7EA04FA; Wed, 5 Feb 2020 15:21:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 370AE1C1A6; Wed, 5 Feb 2020 15:21:45 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 731931C0D1; Wed, 5 Feb 2020 15:21:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2020 06:21:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,405,1574150400"; d="scan'208";a="430171401" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga005.fm.intel.com with ESMTP; 05 Feb 2020 06:21:41 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 06:21:41 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 5 Feb 2020 06:21:40 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 5 Feb 2020 06:21:40 -0800 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.57) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 5 Feb 2020 06:21:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WP1ucW9mrS18MiSxcpjNPG7Wo5tvgi6yMvr92XIZH640EYFpEOoERXF/C7dAKJx92Bc2ZJaJE9iCKlLGiLAF/P+3dMDiDCHPv0OVLsuw+SPFlkO/HB3F/u3KRzYBB91113PC0l/7EzCE6Batgop3jyUpyUpDReYL2Y/FBRLA2PeuRgjQta60DXs7cNNKfuWL7n9Z73I5p7yXbzIqlUjE/S/hznaHF6FIJJNNJsSN3R2Q27cKRfDkbgReNgIcW3TX1r6qNv58OAM6dKnkGFX77VUh7wDQyQBUqI76e/NTjdXSm3yXY2jX9e6h/yS8P038xqN54SuIlDiAzRY3G4ZEKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNACzEX9mlpsY222S2NoRkdQ8+wnWCtBbux89RnyxIo=; b=DwVJTbbpA9aBk717hliKr/kQ2VP09+ztNZxwSkt6+OczpbnlmQfd18uwJcfnJUjmf8CJOmWgGO5V9KRZ8/l/vEjUxtRzr6lVYmil8+DxntX7xeaNkc5nveZ8NbMEIyUU/awymwDJ8b/USG1HUO45hKa+g/wxH9xejHN+cVfFV8Cn5JhN5xpnw7hrBgL5N7tS403XqwDehuFNQDz9G5q+FT0DhrmLaMN5/HOUmZ5z5//HBWVFhstUkKpnGCLzMtcFFWMyR5LwA5icSGGDhmkWeTZx4wnIryn5TzF2VZHV9cz/NaE8uRlanHi5AVY1OSDYqem5Fuo73Xg3q0Db0xfidg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BNACzEX9mlpsY222S2NoRkdQ8+wnWCtBbux89RnyxIo=; b=ZjDp8345+ELyyp7mPaBDtlvlZ71NE4FHDY1RqbfT/SQgeOYlW/MOdiTpY43YD0k2xhxEi+n8l4jrZN/cyKxyvMj92HPWpSn3nGNmYsKEXo7BKkUYA8Tvvp3Oazlt2dEYCZNRvtDcBcUnuV/gbxWH6fU19OZbfD3DO19ltEyFbZw= Received: from SN6PR11MB2717.namprd11.prod.outlook.com (52.135.95.160) by SN6PR11MB3326.namprd11.prod.outlook.com (52.135.111.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2707.21; Wed, 5 Feb 2020 14:21:39 +0000 Received: from SN6PR11MB2717.namprd11.prod.outlook.com ([fe80::88ff:f2d0:644c:a492]) by SN6PR11MB2717.namprd11.prod.outlook.com ([fe80::88ff:f2d0:644c:a492%5]) with mapi id 15.20.2686.035; Wed, 5 Feb 2020 14:21:39 +0000 From: "Dumitrescu, Cristian" To: Timothy Redaelli , "stable@dpdk.org" CC: "dev@dpdk.org" , "david.marchand@redhat.com" Thread-Topic: [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10 Thread-Index: AQHV3C5xeGHiSLvqVE2R+ibkOEnzoagMpjBQ Date: Wed, 5 Feb 2020 14:21:38 +0000 Message-ID: References: <5de9fca287dbda831bbe11e34ecf89631e3a812f.1580911676.git.tredaelli@redhat.com> In-Reply-To: <5de9fca287dbda831bbe11e34ecf89631e3a812f.1580911676.git.tredaelli@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGE2YWM0YmMtNzNhOC00MDYyLWE0NDQtZTY3YWM5OTI5ZTQwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiNEtvRFhzMlJqdUQ0aXlXdG1QMVRveGlYVkJpeUJBVzdHTnpzb09IcjhBcVVvd2VZSnpaalJMMzFHemNYWWQ3VCJ9 dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-ctpclassification: CTP_NT authentication-results: spf=none (sender IP is ) smtp.mailfrom=cristian.dumitrescu@intel.com; x-originating-ip: [192.198.151.179] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8466b07-71e9-4090-fe92-08d7aa46b6fe x-ms-traffictypediagnostic: SN6PR11MB3326: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 0304E36CA3 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(136003)(396003)(346002)(366004)(39860400002)(189003)(199004)(66476007)(110136005)(81156014)(316002)(81166006)(8676002)(478600001)(54906003)(52536014)(66556008)(66446008)(5660300002)(7696005)(2906002)(66946007)(64756008)(33656002)(76116006)(9686003)(55016002)(53546011)(4326008)(6506007)(26005)(8936002)(86362001)(186003)(71200400001); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB3326; H:SN6PR11MB2717.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /w1XWJ+n4QzSdq3/vMU4R/cf3LkZCfye2zgDQLWhkoZUYil2ubARnNgQPY6DJ2H1WO5VJBWzf/xcEyw1EQY6KKqkdgy3+zb5tYAXwcaJGArirmSUXwUXBD5kva4PdiKNzkTN4P0u4qap5CKAUrWi3huY31VKpplt1rswLGlbGuxJQBLASNxRmjNM1ueYA1Ab3XtNFCS/JTi5bPH32H4S6WY1gGhZEAa98F2AUVDUDSiazmAs7xpuUo6GHeheMO6yVNQoM6sBW2qF4hzTUwphcAse7aLLHm/k67TnORTBPDAp77kZjJ5svhHqhzvquxGcTc96U0rlASuEMeMqDUrxQsGSHp0I2RluuxblfV/nR3TCRPYyRWljYpkl3aft8C1QnB706u906UNfbxqZFZS1B3o0+Ob7/NTinJf0swaA8kyIwCU2KQPMNx2gv4Cj2Ii9 x-ms-exchange-antispam-messagedata: 2BZjTTZSxWDEApOwa9r5HtDMW9SVNzCYoXr2ZlZ2aFwfXtCG0VSXIKJ7yMogAP6/dXQD5hn3Y6auX/T0Q7vpGWnWhn0baZ/0TkLdg9S+hQWjxNT6GQI91B2ClhKOZLGO8tsdwroBYJ9knr0REktP8Q== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c8466b07-71e9-4090-fe92-08d7aa46b6fe X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2020 14:21:38.8882 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X+9W3BZcKwQogI+xq1CxMgoLbInoUnVZW28JMWHCOhhRCUhf47uswV4cI1S0/ljCni7BiHF2JzX6xGznmGViPP2qT84ApaRmp+Jb/pVQ+LY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3326 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Timothy Redaelli > Sent: Wednesday, February 5, 2020 2:12 PM > To: stable@dpdk.org > Cc: dev@dpdk.org; david.marchand@redhat.com; Dumitrescu, Cristian > > Subject: [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10 >=20 > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. >=20 > Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") > Cc: cristian.dumitrescu@intel.com > Cc: stable@dpdk.org > Signed-off-by: Timothy Redaelli > --- >=20 > v2: > app is already declared as extern in main.h. (as reported by David) >=20 > --- > app/test-pipeline/config.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/app/test-pipeline/config.c b/app/test-pipeline/config.c > index 28ac9fcc0..33f3f1c82 100644 > --- a/app/test-pipeline/config.c > +++ b/app/test-pipeline/config.c > @@ -42,8 +42,6 @@ >=20 > #include "main.h" >=20 > -struct app_params app; > - > static const char usage[] =3D "\n"; >=20 > void > -- > 2.24.1 Yes, app is declared in main.h and defined & initialized in init.c, no need= to have it defined the second time in config.c. Acked-by: Cristian Dumitrescu