From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 05854A0526;
Thu, 9 Jul 2020 07:30:10 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D1D511DA96;
Thu, 9 Jul 2020 07:30:09 +0200 (CEST)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
by dpdk.org (Postfix) with ESMTP id 0E6F11DA91
for <dev@dpdk.org>; Thu, 9 Jul 2020 07:30:07 +0200 (CEST)
IronPort-SDR: +figa5UdOrHt1A0rdnhYKP5Roaz/ob+OByiCQdU0WrVpphFecxodrnmh3moA4v9ARPXmCN9i0y
AaEtieHqJS5g==
X-IronPort-AV: E=McAfee;i="6000,8403,9676"; a="232815639"
X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="232815639"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Jul 2020 22:30:07 -0700
IronPort-SDR: b7VGTw6jqvuboGVajORqaTxwqkyotXghBWfBZ76IVzxIlPGCQnPoZRbq++cQvXckKQW/kbSuYN
tbefGd5MrQ2A==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.75,330,1589266800"; d="scan'208";a="324110220"
Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14])
by orsmga007.jf.intel.com with ESMTP; 08 Jul 2020 22:30:06 -0700
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Wed, 8 Jul 2020 22:30:06 -0700
Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by
orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5
via Frontend Transport; Wed, 8 Jul 2020 22:30:06 -0700
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174)
by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Wed, 8 Jul 2020 22:30:06 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=jx/x1fkT6u/jZxtkDQ6efg1nw1Q9hmvLwJx+WSD3fh8pVdIyETHafJGHpHCBXI5ryzq2HeyGyG1p+yfyQO5FFMf3hah/iQEoo3iHBLUnS+dldu2xPE7PxileGMbZdTB9l4RDLatcSL9eeVIFBaoyw2x0HNH08JfqKwrDVs8UjczOZRRwgPTZgKMB7yJcL5Cp+NVKdBrUQdK6609CgexZuLxkEKzixjWFyS2lV8tt/v9SLgpioiyI1ytxrfFqXJDOT2eZFf0aTnsLsAXK63tEj204L1mUPtJf6QDWd+5iHLX4ACvr+JJcU9LoDoI3kF2p2QuTmmpNsrvny6pry6eXzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=MQ0FDbevTgzpidGnYvOFEAkm5npwJe6yGOn55xDcbe0=;
b=HtaZsLYf2U6ak0pou5B16SAB7/t0RRcFNGLgj8pjo+BmjVuERnw571JRlyYKcdl7wkR7C4W3NttKg+3Czag8ESd9OL/RP67RKKXPJDRURx/V6S07OM9OILrlIHEMObZ+Rm3ZSFiofDwh0EK1PxMoD/9VotWeX98ih++t8SrrUvOz4R8TFEORkVnY/NCRa/m0026F9G2Tsrg4714wRONZPxONEZxSuxFWYVUaUcmKbnSWay/NNaMspyK8KENkDbfAGqvmmCmBdrW5vijqt5OBe4BEf688Cq4Fm1p3iSjK7nJJQjzMAVtItI+LM066qaVwRiv/G7FqAlafgtipDgQ7TA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=MQ0FDbevTgzpidGnYvOFEAkm5npwJe6yGOn55xDcbe0=;
b=Wx1h8/EMPBOvhChJITsNpqV9mLkaD4kVs03xEgAJ/tZNgvjbA68WXTbAoyrHXKTok+jhU7VtLSIA0+Zt/RchcMBM27DXiHR/ElYTgqD6zxEwxNLELaaP/v3ChdE81MWUilcuOlbMGmYbv3ZxK34jXQeKOIbuWuqmvamSr8R/fcs=
Received: from SN6PR11MB2829.namprd11.prod.outlook.com (2603:10b6:805:62::28)
by SA0PR11MB4687.namprd11.prod.outlook.com (2603:10b6:806:96::16)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.20; Thu, 9 Jul
2020 05:30:04 +0000
Received: from SN6PR11MB2829.namprd11.prod.outlook.com
([fe80::9db:f59b:3671:ab]) by SN6PR11MB2829.namprd11.prod.outlook.com
([fe80::9db:f59b:3671:ab%7]) with mapi id 15.20.3153.031; Thu, 9 Jul 2020
05:30:04 +0000
From: "Sun, Chenmin" <chenmin.sun@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "Zhang, Qi Z"
<qi.z.zhang@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "Wu,
Jingjing" <jingjing.wu@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate optimization
Thread-Index: AQHWQJhK0JKABVxGbUKc2SMxd7VJDaj9hewAgAFcuzA=
Date: Thu, 9 Jul 2020 05:30:04 +0000
Message-ID: <SN6PR11MB282911065F8A915A0C6044E4E3640@SN6PR11MB2829.namprd11.prod.outlook.com>
References: <20200612180015.14760-1-chenmin.sun@intel.com>
<BN8PR11MB3795D78FA0314F0AE19FE823F7670@BN8PR11MB3795.namprd11.prod.outlook.com>
In-Reply-To: <BN8PR11MB3795D78FA0314F0AE19FE823F7670@BN8PR11MB3795.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [192.102.204.45]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2efc46e2-33f8-4918-c2cc-08d823c92285
x-ms-traffictypediagnostic: SA0PR11MB4687:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <SA0PR11MB468758BDBEF8BFED5012E10BE3640@SA0PR11MB4687.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7691;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: cZoYXle4Pm7tsNwSZ3VVc9RncI4sIBGRnfHFYADM3PcrSm79mebC9XlZlYDWEkRZ7tLrwi5kDQOx4VivJqmIxxLXrOizPDuaq1sM0UpYKxek7Kc1Tky52LqTXyGdipnQw0CxODkfJWpO6WmtCQDDhJDyT/AicJirLb34NY2moaEmHWzn6MmUKAhUPb5TULsZb/Q78BlPcmW0cLtpX2K1qJnCdAzoiQTk4LTPhb1FgSne7Oep+DpwCDXUzFmp7NOv0huK/j/AXk1375OlQXKDjhoweG1a1g2e/hpX+2ZSojfgpYWZp+2Emnthp5BtKskV
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SN6PR11MB2829.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFTY:;
SFS:(4636009)(396003)(39860400002)(376002)(136003)(346002)(366004)(2906002)(478600001)(83380400001)(8936002)(5660300002)(86362001)(186003)(66446008)(64756008)(66556008)(33656002)(15650500001)(66476007)(4326008)(26005)(52536014)(76116006)(66946007)(6636002)(316002)(9686003)(55016002)(110136005)(6506007)(71200400001)(8676002)(7696005)(53546011);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: q+56xqCLp3MHglsPYJ9RgVD49lP0rTlVKk5xZq9dFSa9MbYsMum5nEAUVXSWFZEolhck45Ff55QJDGA9gNOdCPLeKFgZ7jE0g5lM2Jk9IJEtcrfyopdvbLPTepT3OTsOTT298mgsg3Mw6aqVMPqyj8bLxPT/VfnxsDYSd1tHcgOfqMAH/560X7UDbdGgbOlzf/a1Y2KkVn40jwzxy2JxGc3D+V5Eg1nKCNpF8sqzBVvk8keovcdk7wwBv/W3feMMPeZrRfVkqNRukHKkjcTb4oxptnPxLPqmjazKH3kxbhakqACV9mKXjfcHUlbaYp2y1thXRg9RjvlSAYI8N0cD3WzzX85y8lclihrwV+AM/JFsSByjFghy/M/UaX9/uMiYHc2GPGZm+QQFHsZvvNdN9fyttzDKMFoYXHoCGoIH+HJNpQgRh5cqm1oRzOPDyf2F/24YsbuWHnsz+7nXUmihTJOiwD/wiDa3KTl3n2SefqNwH8eBgzl8pdQX3l7VQiNu
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2829.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2efc46e2-33f8-4918-c2cc-08d823c92285
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2020 05:30:04.5606 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9vd+Cc4yclOhy5kYkktfzyjUWrUWI+F/2AqKgqRnxGQHuYjMSSCvEkC5eHXGZk2pu/9S4E/MERGnmAf9E1rnSw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4687
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate optimization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Best Regards,
Sun, Chenmin
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Wednesday, July 8, 2020 4:41 PM
> To: Sun, Chenmin <chenmin.sun@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Wu, Jingjin=
g
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Sun, Chenmin <chenmin.sun@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate optimizat=
ion
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of chenmin.sun@intel.com
> > Sent: Saturday, June 13, 2020 02:00
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> > Cc: dev@dpdk.org; Sun, Chenmin <chenmin.sun@intel.com>
> > Subject: [dpdk-dev] [PATCH] net/i40e: i40e FDIR update rate
> > optimization
> >
> > From: Chenmin Sun <chenmin.sun@intel.com>
> >
> > This patch optimized the fdir update rate for i40e PF, by tracking the
> > fdir rule will be inserted into guaranteed space or shared space.
> > For the flows that are inserted to the guaranteed space, it returns
> > success directly without retrieving the result for NIC.
> >
> > This patch changes the global register GLQF_CTL. Therefore, when
> > devarg ``Support multiple driver`` is set, the patch will not take
> > effect to avoid affecting the normal behavior of other i40e drivers,
> > e.g., Linux kernel driver.
> >
> > Signed-off-by: Chenmin Sun <chenmin.sun@intel.com>
> > ---
> > drivers/net/i40e/i40e_ethdev.c | 96 ++++++++++++++++-
> > drivers/net/i40e/i40e_ethdev.h | 57 +++++++---
> > drivers/net/i40e/i40e_fdir.c | 182 +++++++++++++++++++++-----------
> > drivers/net/i40e/i40e_flow.c | 181 +++++++++++++++++++++++++------
> > drivers/net/i40e/i40e_rxtx.c | 15 ++-
> > drivers/net/i40e/rte_pmd_i40e.c | 2 +-
> > 6 files changed, 417 insertions(+), 116 deletions(-)
> >
>=20
>=20
> >
> > +static
> > +uint32_t bin_search(uint64_t data)
> > +{
> > + uint32_t pos =3D 0;
> > +
> > + if ((data & 0xFFFFFFFF) =3D=3D 0) {
> > + data >>=3D 32;
> > + pos +=3D 32;
> > + }
> > +
> > + if ((data & 0xFFFF) =3D=3D 0) {
> > + data >>=3D 16;
> > + pos +=3D 16;
> > + }
> > + if ((data & 0xFF) =3D=3D 0) {
> > + data >>=3D 8;
> > + pos +=3D 8;
> > + }
> > + if ((data & 0xF) =3D=3D 0) {
> > + data >>=3D 4;
> > + pos +=3D 4;
> > + }
> > + if ((data & 0x3) =3D=3D 0) {
> > + data >>=3D 2;
> > + pos +=3D 2;
> > + }
> > + if ((data & 0x1) =3D=3D 0)
> > + pos +=3D 1;
> > +
> > + return pos;
> > +}
> > +
>=20
> Try " __builtin_ctzll ", DPDK has many examples to use it. ;-)
>=20
Thanks, I have replaced it with rte_bsf64()
> > --
> > 2.17.1