Re: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi Mairtin,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Mairtin o Loingsigh
> Sent: Wednesday, March 4, 2020 9:26 AM
> To: Doherty, Declan <declan.doherty@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org; O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] crypto/aesni_mb: support DOCSIS AES-256
> 
> This patch adds support for DOCSIS AES-256 when using AESNI-MB
> 
> Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> ---
>  drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> index d8609ad..110f1f1 100644
> --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
> @@ -314,8 +314,8 @@
>  				.block_size = 16,
>  				.key_size = {
>  					.min = 16,
> -					.max = 16,
> -					.increment = 0
> +					.max = 32,
> +					.increment = 16

Since this is going to be available in release 0.54, you should add a check for the version,
so IMB_VERSION_NUM > IMB_VERSION(0, 53, 0). Otherwise, key_size.min = max = 16.

Thanks,
Pablo