From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CECEA00C4; Thu, 4 Jun 2020 20:41:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F233E1D603; Thu, 4 Jun 2020 20:40:50 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B15571C1A9 for ; Wed, 3 Jun 2020 04:48:01 +0200 (CEST) IronPort-SDR: CBDa/h5cx91Or3ZJx5ZncZA4p5y6eb31VZCGrUgjb+Nxc2tRal0cl51hUycQNxtXF8Z8M8LZTp ocStAYQ2xr2w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2020 19:48:00 -0700 IronPort-SDR: X7NGgyR2mfiBScur6lx67ctcu/JBot3ASEwcntDm+o4X0Ho1eJXga2JJQCDL74VPDraYdrijwY zgSJTxh1iuXQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,466,1583222400"; d="scan'208";a="444934037" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga005.jf.intel.com with ESMTP; 02 Jun 2020 19:48:00 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jun 2020 19:48:00 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jun 2020 19:48:00 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 2 Jun 2020 19:48:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BA1fBF7mCqWX2q+4mjAW1oVxxal3Mizaonbm8jI87qBqhFAZ9B7LNkLTfZsasRHVdlLSfbVhE8KitSmTr4VrvyRwcfPMkydvS9J73J3JIhhxLfF1kHdAC3sHbDoEMJgMh2TLqCQz9h/0Bq8lBgwomlvLcJkdiCOtdE1H4pwpLFj358QcRqVY7BmDJ0gH4PelOnqx+nwAMPhJYMXfj6/DHKXiF3PJvV2VeH9m2j7/DCqR36SWkOTnb7sgQTl05qscWJB1RvLhdYr6DUe3Dieuqg2PgDdX8ZybtGDrk3ZCT+hPng3yKPYV0LSlWVTSIYIif1ERqiay5+L6qu+zS77yjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4JUzUaceOTfQNdgz1IC4O9r/FebptkCUBl262E3ZVY=; b=U7RU6m686g33H9bmQdY2a1Rb6ryTRxXWIKQwk4ajxC2kIO6GAuivT/j58MbX8A+kdQ617+jqh1ZGjR/h84SYBJkcSMye9klDYz6raugTauKVGInag3VooVan6RTqa6oyhuUDA5dkAJvg7dLa6aWosQWABbpI3RH3ywRNV1NeDlYmiwrHWHUabDcbQX0+MuyxwIVgBrKhugEHv+4XC8yLBBlqfzOKIMAYozPMQ3xtqra69p0rclFPVYqI5V1d453b3IwOP6z4YK2dMZEv94b+3chmKUO5pjzvweW4HNb/YMzhUY5UzafMYBZsBekkazPEjUP8YzwveS+bGsm9TP7qmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C4JUzUaceOTfQNdgz1IC4O9r/FebptkCUBl262E3ZVY=; b=isGZrYWphh26koOHthx+m8ejGynrfAziIO5ITMhpAqdf6fpuvOWG12K2W33KprJ0BlEoCX86sv/hFPzBJQvporlknAgion4oscw/nq0FsPaaDQUjpH4UrrTvCWJUbOTw0cUhO8bH5VTWrb81RKUfnJrBWJWRGPM+ULmNPcVKts8= Received: from SN6PR11MB2847.namprd11.prod.outlook.com (2603:10b6:805:55::31) by SN6PR11MB2862.namprd11.prod.outlook.com (2603:10b6:805:5b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3045.21; Wed, 3 Jun 2020 02:47:58 +0000 Received: from SN6PR11MB2847.namprd11.prod.outlook.com ([fe80::d89d:a96a:98c8:5acb]) by SN6PR11MB2847.namprd11.prod.outlook.com ([fe80::d89d:a96a:98c8:5acb%3]) with mapi id 15.20.3045.022; Wed, 3 Jun 2020 02:47:58 +0000 From: "Patil, Kiran" To: "Zhang, Qi Z" , "Yang, Qiming" CC: "dev@dpdk.org" , "Ye, Xiaolong" , "Stillwell Jr, Paul M" Thread-Topic: [PATCH 35/52] net/ice/base: correct return value Thread-Index: AQHWOU//29DsJZ6UBEGXEBOisAv/hajGMB9Q Date: Wed, 3 Jun 2020 02:47:57 +0000 Message-ID: References: <20200603024016.30636-1-qi.z.zhang@intel.com> <20200603024016.30636-36-qi.z.zhang@intel.com> In-Reply-To: <20200603024016.30636-36-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.222] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f39626da-fa7e-4bab-c1b1-08d807688623 x-ms-traffictypediagnostic: SN6PR11MB2862: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 04238CD941 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZfUYA/9NbxzSNlRIYHYeKkMZ2LEiDX+jaLcg5Kx8myqhzoI17AxSIu7LzLiwXGGMkdNhST26c0tTX5nKE/xRgN8fjNGhDu56A9rOKdwIo6xn6Y76Ubjgi9EGuUMAuthMitR8pcAGqc6x3P7qDMsqrSKoH7Y8cHQDEW5pL7j+vwmkT9OjxxE+ZhdzlxT4/LFdA+pyIg1SA7tEznpMdOdehmEZoxsyJmJlv9IPFQjlmZDHaqniMX49/UxLWrOSbzMtjb0ha6N0yEbZTSjtly8ntFMj1qg+eNiLbLncg8vXNALJ4RXYoNS5AVLbTGvcLNbt x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2847.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(136003)(376002)(39860400002)(346002)(396003)(33656002)(9686003)(83380400001)(55016002)(52536014)(6636002)(8936002)(86362001)(478600001)(4326008)(107886003)(26005)(110136005)(2906002)(66556008)(53546011)(66946007)(66476007)(186003)(64756008)(6506007)(7696005)(316002)(8676002)(5660300002)(71200400001)(66446008)(54906003)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Mqo7QNM9ubdbhlsifEqdZeIwBX2CJUrB95qXoz/A4GRlmxvH1JD8eRWpz8bQfzAVSN/Pj+TGtJNtxHNysJqGfVJAh3QamE6pf3Gw1DjwKTsQqaQlgdQp5sNEjymTKwkFn9GuOq7GQoOU6MnaA5cv/XVJPzuXKcgMOlRWZhX56SiyRFg0WiQ7G19ziuESLbL9bbiCBMPK981Se1zmjsici+VLnSfssAHHicVJXDzUP1wv44DYsmYD8ylxxAI79ymeAfYqOY3IQqUAVg8kLFtLxKtorWNayOVSg9bYqDqfYIw1jApKicro3+6HaxaCYaA5tUy/drkZx4804H0V+ViUx/+lvSX4b2mzmOC6iYCDwi5AB/Le1UuXWtXdK4P9AQAnwI2Rv9psuS6+FYI3yDrfqi35nqu+ZnMyyVT3X8BSki/lTOrbsbvW+3tXb+gWrBRSHo2IKT7OayRnvRaNIJxWheE0LNYLDDzcUaDzyS6hu34mYUV3K5/29MZq6VetfAUR Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f39626da-fa7e-4bab-c1b1-08d807688623 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2020 02:47:58.0009 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ttvS8lzIzifGtq437e1Z2UH6z+hDXSCSb15mjpmavHo0oWSeTt4zgknMIlHXBu9CK1t9MOReUHffW15lIA8gew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2862 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Thu, 04 Jun 2020 20:40:47 +0200 Subject: Re: [dpdk-dev] [PATCH 35/52] net/ice/base: correct return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ACK -----Original Message----- From: Zhang, Qi Z =20 Sent: Tuesday, June 2, 2020 7:40 PM To: Yang, Qiming Cc: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z ; Patil, Kiran ; Stillwell Jr, Paul M= Subject: [PATCH 35/52] net/ice/base: correct return value Function ice_rem_adv_rule_id return incorrect error code (ICE_ERR_PARAM) wh= ereas it should have returned ICE_ERR_DOES_NOT_EXIST return code if filter = list is empty or unable to find "rule" in list Signed-off-by: Kiran Patil Signed-off-by: Paul M. Stillwell Jr Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_switch.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_s= witch.c index 01dcace55..5c53b9ec3 100644 --- a/drivers/net/ice/base/ice_switch.c +++ b/drivers/net/ice/base/ice_switch.c @@ -7661,7 +7661,8 @@ ice_rem_adv_rule_by_id(struct ice_hw *hw, list_itr->lkups_cnt, &rinfo); } } - return ICE_ERR_PARAM; + /* either list is empty or unable to find rule */ + return ICE_ERR_DOES_NOT_EXIST; } =20 /** -- 2.13.6