From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 509AEA0352; Thu, 16 Jan 2020 09:36:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9C5E51C1B9; Thu, 16 Jan 2020 09:36:37 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id A66791C1B6 for ; Thu, 16 Jan 2020 09:36:36 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2020 00:36:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,325,1574150400"; d="scan'208";a="423929804" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 16 Jan 2020 00:36:34 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 00:36:34 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 00:36:34 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 00:36:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OT1RdEPYha4ENHu6mP2+ee9/DrF3M5YpfsATvDtgtDR/Q8URUJeD8fnlQQZ2pXydbsmKgSBpGF/dag1ZCbUoQMD/HtbKhPOvTK1UiE6720QbFuIEK5nJATDpJbfMpZ+yRadJSV6Tqw6XHLHkLS6fBN3jDZ/hOe8i/eyv52rIIJMPQhzyGMiZA0w5rbkz8CEsEALqt33aXc7BTEZ1p25Mrr3VN/r0w90h8UuoWqbayWEk0MCNulyfFgBgSMiAWgQsSLclArsX0b8lB5Qct6W8v+9ACv4D+8htW1X1l5f8T5FOT6BK2PJyFEOlWQuw6QXTi1PzsLtGHBElFbwsXLrYEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d2OZQbi40o090zzJWVnUGm41AEm34+o5EoYXoSLsFG8=; b=kjtmlM7ioBnv9uXa3LR+jpCZGhfzL1g08iryA2ypB6a7yoQAnbUZc7xfHSEXYFwN/r5ekbF2rRhHF+amjLcKSHFDBm28KylrweJBPgWd4YdXTD3+qPTaJz6cbDLQ+sYH0zj/rTHJTKMnbtFrvGNaxriNPALtHhPD9r10IFCjOZZAELlh7hPuzRL8V/+cFo+vm28i9SHNBm4itkpoLoziTZhlt9H5QGrd1t/RnWDEkhuUDFDelSp4nnp77XiDimNGsNqNo2iXBNr30+lCgcVT9LZniUk2B5HSCz75Fz8vV+/sSD5B62cF7MDUepkpu1IL/GwTG7Ckuy93/KqML6LbAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d2OZQbi40o090zzJWVnUGm41AEm34+o5EoYXoSLsFG8=; b=MYHY2dGGO8BEIlln4PlhYReQTKKv8XktbE9wHOAQx3FIUyCZ/CoYog+vEEuBOOaB9tVB/1aah8WPqRWVG/FPSwVaUOS+AfINsf7JkHSmMMSH+Fo/XIbt0LHxAipgV0Bh1VPG5pfNIm2tFSGS85pUx3PCQw4FIqYxSbrhvEp45Xo= Received: from SN6PR11MB2847.namprd11.prod.outlook.com (52.135.90.31) by SN6PR11MB2957.namprd11.prod.outlook.com (52.135.124.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.18; Thu, 16 Jan 2020 08:36:32 +0000 Received: from SN6PR11MB2847.namprd11.prod.outlook.com ([fe80::3053:f119:eadf:6c7a]) by SN6PR11MB2847.namprd11.prod.outlook.com ([fe80::3053:f119:eadf:6c7a%7]) with mapi id 15.20.2644.015; Thu, 16 Jan 2020 08:36:32 +0000 From: "De Lara Guarch, Pablo" To: Ali Alnubani , "akhil.goyal@nxp.com" , "Doherty, Declan" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless PMDs Thread-Index: AQHVyhxOXHk8sVHEdE+/2SE7b342zafs+3+w Date: Thu, 16 Jan 2020 08:36:32 +0000 Message-ID: References: <1576074044-250855-1-git-send-email-pablo.de.lara.guarch@intel.com> <1578915625-237451-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTk3ZDEyZWQtODViOS00NDJhLTg4NjItMWQ0YjNjYWI4YWNkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiU2U1U2VmREFhR1ZHSkNYdDNSRktsY1psSVo2aG1VNlRSQm9KRWtnNk53Y1FoSlZENDNyTXpmbXJLbmV4K0NkWSJ9 authentication-results: spf=none (sender IP is ) smtp.mailfrom=pablo.de.lara.guarch@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 890f5e8e-eee7-4b37-8ac1-08d79a5f3092 x-ms-traffictypediagnostic: SN6PR11MB2957: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 02843AA9E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(199004)(189003)(81156014)(2906002)(4326008)(81166006)(6636002)(8936002)(76116006)(52536014)(7696005)(5660300002)(86362001)(66476007)(9686003)(53546011)(55016002)(26005)(6506007)(64756008)(186003)(66446008)(71200400001)(33656002)(66556008)(66946007)(498600001)(110136005); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR11MB2957; H:SN6PR11MB2847.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: izYi/xJ8l/LKbhQSjQ49jFE0gIywp6lAdpljye1/bW8DUxp6kYQs0wzAmNbRHn2ZbSQMVlkCIdt555/DLQ4fttL1TAzJvLmy+ztfvxJjJ5TO6IUUMPIFLQ2bVjmL2Hy2rPLDAAuWzZfp03QvMSD4kGcEFpXad1dSPV66JMX7XHko1xSGpqRekwHZRKM6HK00rSgbe+MZBgzkd/XTbHBBqryi022iHyUvZ7sr0CjyN96g8Kj4wbERjbl6SP/z2ssEQ5+rXFsmZuY7wc76GO5hxAnMhbj1qqEZWmpZNWOdKYshI1FHAwtjHTaJX0+OUm1c1VYucFJ5GnlH/LvaxTNsESSXp1owdgxHW2zjew5Oza86xLOJcrY1sg+8kM7d1kBDFLPbFDffgi0Xl2uTGUIuvUTwDKxPssBVLyCn4vQyAB6ViCQCXa5eU6QokNWxW0cJ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 890f5e8e-eee7-4b37-8ac1-08d79a5f3092 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2020 08:36:32.2186 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WCHyJM/oG5vzKLb3uYV4yImL6gFq54sFYWlN9Z26gOiANNiqSTudUYZQ0alqubsGNaHqyKGOa488GcKK2WAKozzhF3cmmce5kMBKn/OZbn4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2957 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wireless PMDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Ali Alnubani > Sent: Monday, January 13, 2020 2:18 PM > To: De Lara Guarch, Pablo ; > akhil.goyal@nxp.com; Doherty, Declan > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in Wire= less > PMDs >=20 > Hi, >=20 > > -----Original Message----- > > From: dev On Behalf Of Pablo de Lara > > Sent: Monday, January 13, 2020 1:40 PM > > To: akhil.goyal@nxp.com; declan.doherty@intel.com > > Cc: dev@dpdk.org; Pablo de Lara > > Subject: [dpdk-dev] [PATCH v2 0/3] Use Intel IPSec MB library in > > Wireless PMDs > > > > The three Intel SW Crypto PMDs supporting SNOW3G, ZUC and KASUMI link > > against libSSO libraries. > > The Intel IPSec Multi-buffer library recently integrated the code from > > these libraries, in version v0.53. > > This library can be downloaded from > > > > > KASUMI, SNOW3G and ZUC PMDs have been modified to use this single > > library, which is already used in the AESNI MB and AESNI GCM PMDs, > > reducing the number of external dependencies in the crypto PMDs. > > > > Changes in v2: > > - Updated ZUC PMD to support future AVX512 and AVX2 implementations. > > > > Pablo de Lara (3): > > crypto/zuc: use IPSec library > > crypto/kasumi: use IPSec library > > crypto/snow3g: use IPSec library > > > > devtools/test-build.sh | 16 ++---- > > doc/guides/cryptodevs/kasumi.rst | 62 ++++++++++++---------- > > doc/guides/cryptodevs/snow3g.rst | 58 +++++++++++--------- > > doc/guides/cryptodevs/zuc.rst | 52 ++++++++++-------- > > doc/guides/rel_notes/release_20_02.rst | 17 ++++++ > > drivers/crypto/kasumi/Makefile | 26 +++++---- > > drivers/crypto/kasumi/kasumi_pmd_private.h | 12 +++-- > > drivers/crypto/kasumi/meson.build | 24 ++++++--- > > drivers/crypto/kasumi/rte_kasumi_pmd.c | 79 +++++++++++++++-------= -- > > --- > > drivers/crypto/kasumi/rte_kasumi_pmd_ops.c | 8 ++- > > drivers/crypto/snow3g/Makefile | 29 ++++++---- > > drivers/crypto/snow3g/meson.build | 21 ++++++-- > > drivers/crypto/snow3g/rte_snow3g_pmd.c | 85 ++++++++++++++++++--- > > --------- > > drivers/crypto/snow3g/rte_snow3g_pmd_ops.c | 8 ++- > > drivers/crypto/snow3g/snow3g_pmd_private.h | 14 +++-- > > drivers/crypto/zuc/Makefile | 28 ++++++---- > > drivers/crypto/zuc/meson.build | 24 ++++++--- > > drivers/crypto/zuc/rte_zuc_pmd.c | 51 +++++++++++++----- > > drivers/crypto/zuc/rte_zuc_pmd_ops.c | 2 + > > drivers/crypto/zuc/zuc_pmd_private.h | 6 ++- > > mk/rte.app.mk | 6 +-- > > 21 files changed, 395 insertions(+), 233 deletions(-) > > > > -- > > 2.7.5 >=20 > I see the following build failure when applying the patchset: > """ > ../../root/dpdk/drivers/crypto/zuc/rte_zuc_pmd.c:225:51: error: cast from > 'uint8_t **' (aka 'unsigned char **') to 'const void **' must have all in= termediate > pointers const qualified to be safe [-Werror,-Wcast-qual] > IMB_ZUC_EEA3_N_BUFFER(qp->mb_mgr, (const void **)cipher_keys, > ^ > ../../root/dpdk/drivers/crypto/zuc/rte_zuc_pmd.c:226:19: error: cast from > 'uint8_t **' (aka 'unsigned char **') to 'const void **' must have all in= termediate > pointers const qualified to be safe [-Werror,-Wcast-qual] > (const void **)iv, (const void **)src, (void **)d= st, > ^ > ../../root/dpdk/drivers/crypto/zuc/rte_zuc_pmd.c:226:38: error: cast from > 'uint8_t **' (aka 'unsigned char **') to 'const void **' must have all in= termediate > pointers const qualified to be safe [-Werror,-Wcast-qual] > (const void **)iv, (const void **)src, (void **)d= st, > ^ > 3 errors generated. > """ >=20 > It reproduces with meson on Fedora 31 and clang (version 9.0.0). > I'm using intel-ipsec-mb version 0.53. Thanks for reporting this issue. By the time I sent the patchset, I saw no = compilation errors. Will send a v3 fixing this and addressing Bruce's comments. Thanks, Pablo >=20 > Regards, > Ali