Re: [dpdk-dev] [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test vectors

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Trahe, Fiona
> Sent: Wednesday, March 4, 2020 1:40 PM
> To: O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>; akhil.goyal@nxp.com
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test
> vectors
> 
> Hi Máirtin,
> Wasn't this patch already upstreamed with the QAT patchset?
> If so no need to resend.

Actually, I think this patch (or the one in QAT) requires an important change.
If a device doesn't support 32-byte keys, these test cases will fail, so you need
to retrieve the capabilities of the device and check if it supports the key size.

Thanks,
Pablo

> Fiona
> 
> > -----Original Message-----
> > From: O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> > Sent: Wednesday, March 4, 2020 9:18 AM
> > To: Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> > Cc: dev@dpdk.org; O'loingsigh, Mairtin <mairtin.oloingsigh@intel.com>
> > Subject: [PATCH 2/2] test/crypto: Add AES-256 DOCSIS test vectors
> >
> > This patch adds test vectors for AES-256 and sets AESNI-MB as the
> > target PMD
> >
> > Signed-off-by: Mairtin o Loingsigh <mairtin.oloingsigh@intel.com>
> > ---
> >  app/test/test_cryptodev_aes_test_vectors.h |  176
> > ++++++++++++++++++++++++++++
> >  1 files changed, 176 insertions(+), 0 deletions(-)
> >