[dpdk-dev] [PATCH 0/2] cryptodev: remove list end enumerators from asymmetric crypto api

[dpdk-dev] [PATCH 0/2] cryptodev: remove list end enumerators from asymmetric crypto api

[Arek Kusztal]

This patchset removes RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END,
RTE_CRYPTO_ASYM_OP_LIST_END, RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END
enumerators from asymmetric crypto API and its references.
When asymmetric API will no more be experimental adding new entries
will be possible without ABI breakage.

This patches depends on "crypto/qat: remove asym list end references" [1]

[1] http://patchwork.dpdk.org/patch/76634/

Arek Kusztal (2):
  app/test: remove list end references from asym crypto
  cryptodev: remove list ends from asymmetric crypto api

 app/test/test_cryptodev_asym.c         |  6 ++++--
 lib/librte_cryptodev/rte_crypto_asym.h | 10 +++-------
 2 files changed, 7 insertions(+), 9 deletions(-)

-- 
2.17.1

[dpdk-dev] [PATCH 1/2] app/test: remove list end references from asym crypto

[Arek Kusztal]

This patch removes RTE_CRYPTO_ASYM_OP_LIST_END reference from
asymmetric crypto tests.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 app/test/test_cryptodev_asym.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index dc62ed7bf..63a6bba4f 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -542,7 +542,8 @@ test_one_case(const void *test_case, int sessionless)
 		printf("  %u) TestCase %s %s\n", test_index++,
 			tc.modex.description, test_msg);
 	} else {
-		for (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) {
+		for (i = RTE_CRYPTO_ASYM_OP_ENCRYPT;
+				i <= RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; i++) {
 			if (tc.modex.xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {
 				if (tc.rsa_data.op_type_flags & (1 << i)) {
 					if (tc.rsa_data.key_exp) {
@@ -1028,7 +1029,8 @@ static inline void print_asym_capa(
 			rte_crypto_asym_xform_strings[capa->xform_type]);
 	printf("operation supported -");
 
-	for (i = 0; i < RTE_CRYPTO_ASYM_OP_LIST_END; i++) {
+	for (i = RTE_CRYPTO_ASYM_OP_ENCRYPT;
+			i <= RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE; i++) {
 		/* check supported operations */
 		if (rte_cryptodev_asym_xform_capability_check_optype(capa, i))
 			printf(" %s",
-- 
2.17.1

[dpdk-dev] [PATCH 2/2] cryptodev: remove list ends from asymmetric crypto api

[Arek Kusztal]

This patch removes RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END,
RTE_CRYPTO_ASYM_OP_LIST_END, RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END
enumerators from asymmetric crypto API. When asymmetric API will
no more be experimental adding new entries will be possible without
ABI breakage.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/librte_cryptodev/rte_crypto_asym.h | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/lib/librte_cryptodev/rte_crypto_asym.h b/lib/librte_cryptodev/rte_crypto_asym.h
index 9c866f553..915a586c1 100644
--- a/lib/librte_cryptodev/rte_crypto_asym.h
+++ b/lib/librte_cryptodev/rte_crypto_asym.h
@@ -92,10 +92,8 @@ enum rte_crypto_asym_xform_type {
 	/**< Elliptic Curve Digital Signature Algorithm
 	 * Perform Signature Generation and Verification.
 	 */
-	RTE_CRYPTO_ASYM_XFORM_ECPM,
+	RTE_CRYPTO_ASYM_XFORM_ECPM
 	/**< Elliptic Curve Point Multiplication */
-	RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END
-	/**< End of list */
 };
 
 /**
@@ -114,9 +112,8 @@ enum rte_crypto_asym_op_type {
 	/**< DH Private Key generation operation */
 	RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE,
 	/**< DH Public Key generation operation */
-	RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE,
+	RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE
 	/**< DH Shared Secret compute operation */
-	RTE_CRYPTO_ASYM_OP_LIST_END
 };
 
 /**
@@ -131,9 +128,8 @@ enum rte_crypto_rsa_padding_type {
 	 */
 	RTE_CRYPTO_RSA_PADDING_OAEP,
 	/**< RSA PKCS#1 OAEP padding scheme */
-	RTE_CRYPTO_RSA_PADDING_PSS,
+	RTE_CRYPTO_RSA_PADDING_PSS
 	/**< RSA PKCS#1 PSS padding scheme */
-	RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END
 };
 
 /**
-- 
2.17.1

Re: [dpdk-dev] [PATCH 0/2] cryptodev: remove list end enumerators from asymmetric crypto api

[Trahe, Fiona]

> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Thursday, September 10, 2020 12:43 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; anoobj@marvell.com; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH 0/2] cryptodev: remove list end enumerators from asymmetric crypto api
> 
> This patchset removes RTE_CRYPTO_ASYM_XFORM_TYPE_LIST_END,
> RTE_CRYPTO_ASYM_OP_LIST_END, RTE_CRYPTO_RSA_PADDING_TYPE_LIST_END
> enumerators from asymmetric crypto API and its references.
> When asymmetric API will no more be experimental adding new entries
> will be possible without ABI breakage.
> 
> This patches depends on "crypto/qat: remove asym list end references" [1]
> 
> [1] http://patchwork.dpdk.org/patch/76634/
> 
> Arek Kusztal (2):
>   app/test: remove list end references from asym crypto
>   cryptodev: remove list ends from asymmetric crypto api
> 
>  app/test/test_cryptodev_asym.c         |  6 ++++--
>  lib/librte_cryptodev/rte_crypto_asym.h | 10 +++-------
>  2 files changed, 7 insertions(+), 9 deletions(-)

Series Acked-by: Fiona Trahe <fiona.trahe@intel.com>