DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero
@ 2020-05-06  9:37 Ankur Dwivedi
  2020-05-07  5:11 ` Anoob Joseph
  0 siblings, 1 reply; 4+ messages in thread
From: Ankur Dwivedi @ 2020-05-06  9:37 UTC (permalink / raw)
  To: dev
  Cc: declan.doherty, pablo.de.lara.guarch, akhil.goyal, anoobj, Ankur Dwivedi

For null cipher the iv length should be set to zero.

Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
---
 app/test/test_cryptodev_blockcipher.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
index 473dad9..909b615 100644
--- a/app/test/test_cryptodev_blockcipher.c
+++ b/app/test/test_cryptodev_blockcipher.c
@@ -379,7 +379,11 @@
 		cipher_xform->cipher.key.data = cipher_key;
 		cipher_xform->cipher.key.length = tdata->cipher_key.len;
 		cipher_xform->cipher.iv.offset = IV_OFFSET;
-		cipher_xform->cipher.iv.length = tdata->iv.len;
+
+		if (tdata->crypto_algo == RTE_CRYPTO_CIPHER_NULL)
+			cipher_xform->cipher.iv.length = 0;
+		else
+			cipher_xform->cipher.iv.length = tdata->iv.len;
 
 		sym_op->cipher.data.offset = tdata->cipher_offset;
 		sym_op->cipher.data.length = tdata->ciphertext.len -
-- 
1.9.3


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero
  2020-05-06  9:37 [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero Ankur Dwivedi
@ 2020-05-07  5:11 ` Anoob Joseph
  2020-05-07 10:37   ` Trahe, Fiona
  0 siblings, 1 reply; 4+ messages in thread
From: Anoob Joseph @ 2020-05-07  5:11 UTC (permalink / raw)
  To: Ankur Dwivedi, dev
  Cc: declan.doherty, pablo.de.lara.guarch, akhil.goyal, Ankur Dwivedi


> 
> For null cipher the iv length should be set to zero.
> 
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>

Acked-by: Anoob Joseph <anoobj@marvell.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero
  2020-05-07  5:11 ` Anoob Joseph
@ 2020-05-07 10:37   ` Trahe, Fiona
  2020-05-09 22:00     ` Akhil Goyal
  0 siblings, 1 reply; 4+ messages in thread
From: Trahe, Fiona @ 2020-05-07 10:37 UTC (permalink / raw)
  To: Anoob Joseph, Ankur Dwivedi, dev
  Cc: Doherty, Declan, De Lara Guarch, Pablo, akhil.goyal, Ankur Dwivedi



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Anoob Joseph
> Sent: Thursday, May 7, 2020 6:11 AM
> To: Ankur Dwivedi <adwivedi@marvell.com>; dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; akhil.goyal@nxp.com; Ankur Dwivedi <adwivedi@marvell.com>
> Subject: Re: [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero
> 
> 
> >
> > For null cipher the iv length should be set to zero.
> >
> > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> 
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero
  2020-05-07 10:37   ` Trahe, Fiona
@ 2020-05-09 22:00     ` Akhil Goyal
  0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2020-05-09 22:00 UTC (permalink / raw)
  To: Trahe, Fiona, Anoob Joseph, Ankur Dwivedi, dev
  Cc: Doherty, Declan, De Lara Guarch, Pablo, Ankur Dwivedi

> > >
> > > For null cipher the iv length should be set to zero.
> > >
> > > Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> >
> > Acked-by: Anoob Joseph <anoobj@marvell.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Title should start from test/crypto:..

Applied to dpdk-next-crypto

Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-05-09 22:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06  9:37 [dpdk-dev] [PATCH] app/test: set null cipher iv length to zero Ankur Dwivedi
2020-05-07  5:11 ` Anoob Joseph
2020-05-07 10:37   ` Trahe, Fiona
2020-05-09 22:00     ` Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).