From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: "Dybkowski, AdamX" <adamx.dybkowski@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug
Date: Fri, 24 Jul 2020 11:54:31 +0000 [thread overview]
Message-ID: <SN6PR11MB28809B1E596D8C13E0A5E67AE4770@SN6PR11MB2880.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200724094010.1025-1-adamx.dybkowski@intel.com>
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Friday, July 24, 2020 10:40 AM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] common/qat: fix uninitialized variable bug
>
> This patch fixes the uninitialized variable bug in QAT PMD.
>
> Fixes: 9f27a860dc16 ("crypto/qat: move generic qp function to qp file")
>
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> ---
> drivers/common/qat/qat_qp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
> index aacd4ab21..0ee713955 100644
> --- a/drivers/common/qat/qat_qp.c
> +++ b/drivers/common/qat/qat_qp.c
> @@ -582,7 +582,7 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t nb_ops)
> register struct qat_queue *queue;
> struct qat_qp *tmp_qp = (struct qat_qp *)qp;
> register uint32_t nb_ops_sent = 0;
> - register int ret;
> + register int ret = -1;
Nack - this fn returns an unsigned. So the correct option is to default to 0
next prev parent reply other threads:[~2020-07-24 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 9:40 Adam Dybkowski
2020-07-24 11:54 ` Trahe, Fiona [this message]
2020-07-24 11:58 ` Dybkowski, AdamX
2020-07-24 12:20 ` Trahe, Fiona
2020-07-26 19:19 ` Akhil Goyal
2020-07-29 13:19 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB28809B1E596D8C13E0A5E67AE4770@SN6PR11MB2880.namprd11.prod.outlook.com \
--to=fiona.trahe@intel.com \
--cc=adamx.dybkowski@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).