From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D92A1A0518; Fri, 24 Jul 2020 13:54:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A1F361BFE7; Fri, 24 Jul 2020 13:54:36 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id BDE381BFE5 for ; Fri, 24 Jul 2020 13:54:34 +0200 (CEST) IronPort-SDR: HT4vrxd2ew48CVANrDYQm/4kHmj1JWmlvD+7WT1PGJ9TOO4GmN0iHb1VCAzTakGVeCHfntVz1E UdyrJ9m9iPLA== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="148610672" X-IronPort-AV: E=Sophos;i="5.75,390,1589266800"; d="scan'208";a="148610672" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2020 04:54:33 -0700 IronPort-SDR: 2ZvFZSwUDlKAy4cv0HPylkOpwwm4XGLClkXP8WpjBst0qq1ARlmTf+z8170owdUWjB4nOB1But cnEfDBjabIng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,390,1589266800"; d="scan'208";a="288969367" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga006.jf.intel.com with ESMTP; 24 Jul 2020 04:54:33 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Jul 2020 04:54:32 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Jul 2020 04:54:32 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.50) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Jul 2020 04:54:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4J16lDreqEXFj6Sk6PqFrAjielcPIKNFRWU043B8bzv3ExxovvF27yEmmDp5N2sVKgdUXr3/ukzsmAobUwkUXWhIz1o6kSKICkf9d8wrgRczI0vQJkF3QniLeMrE6EdQdvM4yiErn//TNQmc22l7QiKrcX3ZrdtM5OFebljBcLW39u/GLM6efCClWKNaqDbiLtw5zYxUn5wS6NoGP+c9EwaN6ZNmg3pnX4sYbxPcbTAgSAxhG3IWtYAVt+C4gWsVNywlvLkFFDjhlAYG6HpHxhQP0jFuSytI+dAOVGvb1OmL+LAuJF+je0q16C/r6jMVBJ7HIIhMdIRXpt7309QzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BF/lr7PCY0Um/RoQ9WXx1zlPRUYSaTuPXstrQ9P8FjA=; b=htz6OH7BojSGUDe3PqJc9IoTIDwLZlA/ALpbrs5JMSDcIwuGEGVyl6lTngCclszvYIv4+iZRLq17ypRZAxx4uibQRgkl7AY8C8O6lAScsNvqSbCuJve+enREcrhy2B4798bSWS/lZaIxw/cRjvsGRd6DFvg8NcTl0i6+R0PPH6hQ8Kkgr6jfmCfknA0d4b3shvWNMxRlvthNmhzN61sTbraIdLk1CPR5WL3xSUw5MOx41+haPVVOsN4EMKD6xS97QhRrqAgYxxPaWKNGh4ISFa/OPBGIb7Gdm9xQZYZMpjJgNFahErttsG1ifgnr8vhRJhWJjOW6SR8ZJ480Kt8iNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BF/lr7PCY0Um/RoQ9WXx1zlPRUYSaTuPXstrQ9P8FjA=; b=VG//g3vztNvWOBGTJLew2EJfjVDCWa0mlIhkwjQw3BP3FFilhtr/lnUQAWcwOeOIm8eSG4nWT1+ZrvoOS/9jzibYUSyW+Z+6H1rUf8d+AtCM2XVV5vhjmJWdH/FBQ/JbLzjhzcXdd8HcI5MsKMef6Xv+ZYgex3WnhpV2FGfxSug= Received: from SN6PR11MB2880.namprd11.prod.outlook.com (2603:10b6:805:58::15) by SA0PR11MB4655.namprd11.prod.outlook.com (2603:10b6:806:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Fri, 24 Jul 2020 11:54:31 +0000 Received: from SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::ec8b:8f35:800d:13f4]) by SN6PR11MB2880.namprd11.prod.outlook.com ([fe80::ec8b:8f35:800d:13f4%3]) with mapi id 15.20.3216.023; Fri, 24 Jul 2020 11:54:31 +0000 From: "Trahe, Fiona" To: "Dybkowski, AdamX" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Trahe, Fiona" Thread-Topic: [PATCH] common/qat: fix uninitialized variable bug Thread-Index: AQHWYZ6H+7Fpp6bs7UGPpApgwnhqw6kWnSPg Date: Fri, 24 Jul 2020 11:54:31 +0000 Message-ID: References: <20200724094010.1025-1-adamx.dybkowski@intel.com> In-Reply-To: <20200724094010.1025-1-adamx.dybkowski@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.123.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b1f2624d-34f8-46e8-800b-08d82fc85390 x-ms-traffictypediagnostic: SA0PR11MB4655: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qESYYQUjSp3AzNtRbH6GQt1MMugoYMazOKgu9svTDy0gMZGaR8tI+2O4vWPY0RiwsDKP5kDG4MP/TXh8P4+VUbJUHJ7a5gjUFFFBS0P1FWaPU/G0OL0fjZYGDRdszvzkOesKF5+ZzDl8tAmoah5THXyE/+VQtW0bT/GtPK107HL0ZehwKFckVJjWhZUkv0JiMkzpMEGVsytQeIC4EU1nAZvG2WQV9aYrAVVhWOVGRpvI1jMO0+JIqCmUO8WVPJwKOQ2UA+DnuNc1zYTpDYq83sUAW9TBs8XGi9ESW4omEIZsCW+U+1I4Kf18hj48a7gsf0u3LSGV7J3wBLAVBB6jUA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB2880.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(5660300002)(52536014)(110136005)(26005)(316002)(8676002)(4326008)(53546011)(7696005)(33656002)(6506007)(186003)(66446008)(66556008)(9686003)(86362001)(66946007)(66476007)(64756008)(2906002)(8936002)(83380400001)(55016002)(107886003)(76116006)(71200400001)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: AxY4CbMveEipX/2c0RwPbbGEPWn/D4CyJpJr01W4C6a+0BQfAXamgRKOeZ3+MbwmBwOux3HvpYLDmxjIMvPjjng+oGU0CL5XkjWPOVD4LaztHLoSS6ZsUDQDDZTGQxuoyR7cDrghq1xI3yfHXWZcdALxj8Upf94TFTHK/3smuM94yPKZr+XXaev8Cywy6z3fqriMmyVQNS4QU0EgTmurMrVOXyWdDeV2ngPckOraElME1xt1ir7oYz61kgBTa9QUbRJHYEa2AuL+E5ZldvDTt13xkXqBdHM+m8LE70kso/X9hpHgK1TL0dll2ICClzJW/JCoLyRuj3NoJJHmdGDtK3pEDWgmGb+aDZ1r5qDDxfImL8tTnG83qbRLXWS2T8hrhiYTdiIGcSFqaysQr6JHdA6tfZDpaFs/Ojyn5IgAMhQnS89yIxr47FcmPJiFnyeENg/TbhnZoMavvk6rvzelcrrdIE9NO+w/hkeLqY/ZPuE= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2880.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1f2624d-34f8-46e8-800b-08d82fc85390 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2020 11:54:31.3579 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HXbDbyygH1CL1yIx3y1AURwpbmbojBLcnwmol+CxA0ooofdyyWbbqaLvytZdMJxXehE/aSjrS9Zcp1/fu2Z0mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4655 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dybkowski, AdamX > Sent: Friday, July 24, 2020 10:40 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.goyal@nxp.c= om > Cc: Dybkowski, AdamX > Subject: [PATCH] common/qat: fix uninitialized variable bug >=20 > This patch fixes the uninitialized variable bug in QAT PMD. >=20 > Fixes: 9f27a860dc16 ("crypto/qat: move generic qp function to qp file") >=20 > Signed-off-by: Adam Dybkowski > --- > drivers/common/qat/qat_qp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c > index aacd4ab21..0ee713955 100644 > --- a/drivers/common/qat/qat_qp.c > +++ b/drivers/common/qat/qat_qp.c > @@ -582,7 +582,7 @@ qat_enqueue_op_burst(void *qp, void **ops, uint16_t n= b_ops) > register struct qat_queue *queue; > struct qat_qp *tmp_qp =3D (struct qat_qp *)qp; > register uint32_t nb_ops_sent =3D 0; > - register int ret; > + register int ret =3D -1; Nack - this fn returns an unsigned. So the correct option is to default to = 0