DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Govindharajan, Hariprasad" <hariprasad.govindharajan@intel.com>
To: Luca Boccassi <bluca@debian.org>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to build the kernel module
Date: Thu, 29 Oct 2020 18:42:45 +0000
Message-ID: <SN6PR11MB2958AA07F9B9A43E4294EF6684140@SN6PR11MB2958.namprd11.prod.outlook.com> (raw)
In-Reply-To: <19bcf4dda0f0908e1ebda104867441cf38870dda.camel@debian.org>

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Thursday, October 29, 2020 10:16 AM
> To: Govindharajan, Hariprasad <hariprasad.govindharajan@intel.com>;
> dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: Re: [dpdk-dev] [DPDK_KMODS v4] linux/igb_uio: add Makefile to
> build the kernel module
> 
> On Thu, 2020-10-08 at 10:40 +0100, Hariprasad Govindharajan wrote:
> > With DPDK 20.11 release, the igb_uio module is no more part of DPDK.
> > There are use cases where this module is required, for example while
> > testing the virtual ports in OvS, the virtual ports are bound to
> > igb_uio module inside a VM. So, this patch provides a Makefile which
> > can be used to build this module and use as needed.
> >
> > Before building this module, the user is expected to build the DPDK
> > using meson build system and make sure that the required libraries are
> > installed in the path /usr/local
> >
> > Signed-off-by: Hariprasad Govindharajan
> > <hariprasad.govindharajan@intel.com>
> > ---
> > This patch will be part of dpdk-kmods repo
> > https://git.dpdk.org/dpdk-kmods/
> > ---
> > v4:
> > Corrected the indentation
> > v3:
> > Edited the commit message and corrected the mistakes in the variable
> > definition
> > v2:
> > Added more information to the commit message
> > ---
> >  linux/igb_uio/Makefile | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >  create mode 100644 linux/igb_uio/Makefile
> >
> > diff --git a/linux/igb_uio/Makefile b/linux/igb_uio/Makefile new file
> > mode 100644 index 0000000..45dbe42
> > --- /dev/null
> > +++ b/linux/igb_uio/Makefile
> > @@ -0,0 +1,8 @@
> > +DPDK_HEADERS ?= /usr/local/include
> 
> Please don't hard-code values that are provided programmatically. Use
> pkgconfing instead:
> 
> $(shell pkg-config --variable=includedir libdpdk)
> 
> > +RTE_KERNELDIR ?= /lib/modules/`uname -r`/build
> 
> This is not a dpdk specific location so it doesn't need an RTE prefix.
> While there isn't a unique way of calling this, the most common name I see
> being used is KSRC.
> 
> > +
> > +all:
> > +	make EXTRA_CFLAGS="-I $(DPDK_HEADERS)" -C $(RTE_KERNELDIR)/
> M=$(PWD)
> > +
> > +clean:
> > +	make -C $(RTE_KERNELDIR)/ M=$(PWD) clean
> 
> --
> Kind regards,
> Luca Boccassi
[Govindharajan, Hariprasad] We are sending another patch by removing the DPDK dependency to build the igb_uio module

Regards,
G Hariprasad

  reply	other threads:[~2020-10-29 18:42 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-05 14:47 [dpdk-dev] [PATCH] " Hariprasad Govindharajan
2020-10-05 15:12 ` Ferruh Yigit
2020-10-05 16:18 ` [dpdk-dev] [PATCH v2] " Hariprasad Govindharajan
2020-10-05 16:26   ` Ferruh Yigit
2020-10-05 18:27   ` Stephen Hemminger
2020-10-05 17:55 ` [dpdk-dev] [DPDK_KMODS v3] " Hariprasad Govindharajan
2020-10-05 17:57 ` Hariprasad Govindharajan
2020-10-06  9:02   ` Ferruh Yigit
2020-10-07 12:50   ` Burakov, Anatoly
2020-10-08  9:40 ` [dpdk-dev] [DPDK_KMODS v4] " Hariprasad Govindharajan
2020-10-08  9:43   ` Burakov, Anatoly
2020-10-19 18:07     ` Ajit Khaparde
2020-10-21 11:37       ` Kalesh Anakkur Purayil
2020-10-10  1:30   ` Ma, LihongX
2020-10-28 21:09   ` Narcisa Ana Maria Vasile
2020-10-29 10:16   ` Luca Boccassi
2020-10-29 18:42     ` Govindharajan, Hariprasad [this message]
2020-10-29 19:16 ` [dpdk-dev] [DPDK_KMODS v5] " Hariprasad Govindharajan
2020-10-29 19:31   ` Ferruh Yigit
2020-10-29 21:11   ` Thomas Monjalon
2020-10-29 20:10 ` [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Hariprasad Govindharajan
2020-10-29 20:10   ` [dpdk-dev] [prefix=DPDK_KMODS v6 2/2] linux/igb_uio: add Makefile to build the igb_uio module Hariprasad Govindharajan
2020-10-29 20:17     ` Ferruh Yigit
2020-10-29 21:16     ` Thomas Monjalon
2020-10-29 20:17   ` [dpdk-dev] [prefix=DPDK_KMODS v6 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Ferruh Yigit
2020-10-29 21:14   ` Thomas Monjalon
2020-10-30 10:10     ` Thomas Monjalon
2020-10-29 21:28   ` David Marchand
2020-10-29 21:42     ` Thomas Monjalon
2020-10-29 23:17 ` [dpdk-dev] [PATCH DPDK_KMODS v7 " Hariprasad Govindharajan
2020-10-29 23:17   ` [dpdk-dev] [PATCH DPDK_KMODS v7 2/2] linux/igb_uio: add Makefile to build the igb_uio module Hariprasad Govindharajan
2020-10-30 10:04   ` [dpdk-dev] [PATCH DPDK_KMODS v7 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Ferruh Yigit
2020-10-30 10:52 ` [dpdk-dev] [PATCH dpdk-kmods v8 " Hariprasad Govindharajan
2020-10-30 10:52   ` [dpdk-dev] [PATCH dpdk-kmods v8 2/2] linux/igb_uio: add Makefile to build the igb_uio module Hariprasad Govindharajan
2020-10-30 11:03   ` [dpdk-dev] [PATCH dpdk-kmods v8 1/2] linux/igb_uio: remove DPDK dependency for building igb_uio Ferruh Yigit
2020-10-30 11:28     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2958AA07F9B9A43E4294EF6684140@SN6PR11MB2958.namprd11.prod.outlook.com \
    --to=hariprasad.govindharajan@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git