From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
"jerinj@marvell.com" <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Carrillo, Erik G" <erik.g.carrillo@intel.com>,
"Eads, Gage" <gage.eads@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference
Date: Fri, 20 Nov 2020 10:03:29 +0000 [thread overview]
Message-ID: <SN6PR11MB30861BDB1EB38AB4539A93F2FCFF0@SN6PR11MB3086.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1605548439-31240-1-git-send-email-timothy.mcdaniel@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Timothy McDaniel
> Sent: Monday, November 16, 2020 5:41 PM
> Cc: dev@dpdk.org; Carrillo, Erik G <erik.g.carrillo@intel.com>; Eads, Gage
> <gage.eads@intel.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> jerinj@marvell.com; thomas@monjalon.net
> Subject: [dpdk-dev] [PATCH] event/dlb: fix potential NULL dereference
>
> Add NULL check before using t->mbuf_pool.
>
> Coverity issue: 363719
> Fixes: 83326 ("event/dlb: add PMD self-tests")
This is similar to a fix on the dlb2 driver which fixed a similar Coverity defect (according to the last Coverity run). So, on that basis, I'll ack this patch.
Jerin, could you try merge this for RC5 if possible.
Acked-by: John McNamara <john.mcnamara@intel.com>
next prev parent reply other threads:[~2020-11-20 10:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:40 Timothy McDaniel
2020-11-20 10:03 ` Mcnamara, John [this message]
2020-11-20 12:25 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR11MB30861BDB1EB38AB4539A93F2FCFF0@SN6PR11MB3086.namprd11.prod.outlook.com \
--to=john.mcnamara@intel.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=gage.eads@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).