DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: Aaron Conole <aconole@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: David Marchand <david.marchand@redhat.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Power, Ciara" <ciara.power@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] guides: add a guide for developing unit tests
Date: Fri, 6 Aug 2021 09:53:07 +0000	[thread overview]
Message-ID: <SN6PR11MB30866A54AD9D4C5A5F8F1C07FCF39@SN6PR11MB3086.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210714164047.511561-1-aconole@redhat.com>



> +  $ ./build/app/test/dpdk-test --dpdk-options-here
> +  EAL: Detected 4 lcore(s)
> +  EAL: Detected 1 NUMA nodes
> +  EAL: Static memory layout is selected, amount of reserved memory can be adjusted with -m or --socket-mem
> +  EAL: Multi-process socket /run/user/26934/dpdk/rte/mp_socket
> +  EAL: Selected IOVA mode 'VA'
> +  EAL: Probing VFIO support...
> +  EAL: PCI device 0000:00:1f.6 on NUMA socket -1
> +  EAL:   Invalid NUMA socket, default to 0
> +  EAL:   probe driver: 8086:15d7 net_e1000_em
> +  APP: HPET is not enabled, using TSC as default timer  RTE>>


Minor suggestion. You could truncate the long "Static memory" line in this and other blocks to prevent it invoking the scroll bars. Something, like this:

> +  EAL: Static memory layout is selected ...


Apart from that, great work on trawling through the weeds of the DPDK units test infrastructure and creating this really useful doc.

Thank you.

Acked-by: John McNamara <john.mcnamara@intel.com>

  parent reply	other threads:[~2021-08-06  9:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 16:52 [dpdk-dev] [PATCH] guides: add a testing guide for developing tests Aaron Conole
2021-02-08 18:03 ` Kinsella, Ray
2021-02-09 20:02   ` Aaron Conole
2021-02-10 14:55 ` [dpdk-dev] [PATCH v2] " Aaron Conole
2021-03-02  9:07   ` David Marchand
2021-03-02 10:04     ` Bruce Richardson
2021-03-02 15:26       ` Aaron Conole
2021-03-02 16:00         ` Bruce Richardson
2021-03-09 16:14         ` Aaron Conole
2021-03-11 21:25           ` David Marchand
2021-03-17 14:44             ` Aaron Conole
2021-03-09 15:57   ` [dpdk-dev] [PATCH v3] guides: add a guide for developing unit tests Aaron Conole
2021-05-31 15:17     ` Ferruh Yigit
2021-06-01 13:11       ` Aaron Conole
2021-07-14 16:40     ` [dpdk-dev] [PATCH v4] " Aaron Conole
2021-08-04 16:25       ` Power, Ciara
2021-08-06  9:27       ` Zhang, Roy Fan
2021-08-06  9:53       ` Mcnamara, John [this message]
2021-10-15 17:06       ` [dpdk-dev] [PATCH v5] " Aaron Conole
2021-11-26 16:20         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB30866A54AD9D4C5A5F8F1C07FCF39@SN6PR11MB3086.namprd11.prod.outlook.com \
    --to=john.mcnamara@intel.com \
    --cc=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=ciara.power@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).