From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89757A04C0; Thu, 17 Sep 2020 18:08:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5E4E81D6BB; Thu, 17 Sep 2020 18:08:53 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id DBE5B1D6B8; Thu, 17 Sep 2020 18:08:51 +0200 (CEST) IronPort-SDR: 1+mnnUWVvQq/umCIKGQa26dnb7kv+MCuMLsfPV8iWm1pyP/wnyww6d2/pjN+G/Arnf3xQAUxVA iBSM3169diEA== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="139732439" X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="139732439" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 09:08:47 -0700 IronPort-SDR: VnPpQBKMKarhqmTqRNLmZ1T2pYqebb0rOeV8RBCjqlupgsnC1q9e7T1YbGwZ9c5sK19xsuHO4z 2A+Y3q0hGhnw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,271,1596524400"; d="scan'208";a="332214325" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 17 Sep 2020 09:08:46 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Sep 2020 09:08:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Sep 2020 09:08:46 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.50) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Sep 2020 09:08:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HI/e2v+goTFn5fVwrBKVMUm/I+Nse8a0cywgLGveDx4e0wV09YPEINqJ0IZE614l4xhvMgGCZan/vF+zXALaOsILMPlD87aPEtLRHH48Mp+W7nMu9bgO4zovci+UFlwp2a2AbhnoB/fKSihcZQjtRTg+ufsCRjS+MWJv8tInlZHC9WPX0SJqvxB9dCB2S4rWeMBwaVLNfxrNe1T9WZZL/ViK7jOy+UMWdlPVm6jeIr0PNqUMF8z55aZJq+DIcB3oIoIRsW635q6+xvz9I3i6pQGIXTs66kyIJpBn2OdTPgw5xfcbZU261iYyOhf1TPaV3SlrI+DjMSeRIHdP9mLOtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZj6Bro1aAznF+sIIdJ+x8rjKmXctATuRU4anTH7Iik=; b=RI5wBO5Ha4vbc85IU+tAGoEkGGrqiaHJyuNCaLbIxqHhCMIs3u/R1j7/QhWOLdMrz8BsT90TvwLOUtfreoqgUtw8gEyCHczctJARTebJ5jvBQg8aogxUW+ioMD+mlZsJYc5hsNw/bQmKAW2mW0NWrtnSZ2QHQGNKSQiZHilhJXzyE0mkmK9aJbOS4tpxbPxd+92H6jhN68roWuj1LvUwpHjSGoTWOLGs8JjvGhXSZiJLTBCiEE6cO0BUM7JM385F+ePFKINSFTm5qZAgM9LGZabEgYj//UJ2qG5MYdXHi8pXlR4DUBtqjtZUfqA4nVWapEJ1X12H5KDjhZYRh95deQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oZj6Bro1aAznF+sIIdJ+x8rjKmXctATuRU4anTH7Iik=; b=nVPg9k1tl4zHE7sEWeh2DUUUDOl1gnD+qL/N52oaw9AluXvcNjOg44oLALXdo81ljru9L9XukqXVwN/XaJDj4E+FkYNkGLaY9PGrAQ0s9coz0xtz3KM48A0ZwMXPFYe76xD7R7ccW+bQxdYYpC2PDKPMZBeJ6wPZdtGKgLxpgRk= Received: from SN6PR11MB3086.namprd11.prod.outlook.com (2603:10b6:805:d6::14) by SN6PR11MB3262.namprd11.prod.outlook.com (2603:10b6:805:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Thu, 17 Sep 2020 16:08:40 +0000 Received: from SN6PR11MB3086.namprd11.prod.outlook.com ([fe80::5c09:39db:1135:8dfc]) by SN6PR11MB3086.namprd11.prod.outlook.com ([fe80::5c09:39db:1135:8dfc%2]) with mapi id 15.20.3391.015; Thu, 17 Sep 2020 16:08:40 +0000 From: "Mcnamara, John" To: "Power, Ciara" , "dev@dpdk.org" CC: "Power, Ciara" , "stable@dpdk.org" , "Wiles, Keith" Thread-Topic: [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail Thread-Index: AQHWjQRU7O1Xpbjb2UKYTFoI2jWj6qls/2fQ Date: Thu, 17 Sep 2020 16:08:40 +0000 Message-ID: References: <20200917150341.66298-1-ciara.power@intel.com> In-Reply-To: <20200917150341.66298-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.22] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1cab64f8-6b5d-4507-34a1-08d85b23f197 x-ms-traffictypediagnostic: SN6PR11MB3262: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a2KWAWPncpsFB4SymqBodCgp72EZZkzqHVV7FMJkv+4vBBIGYOqA9oVLDwDvDaUKjHdbNifuVYOR6lmY6+AF7N2H2MxP3GAMEBIO/s2kcrDXpnxD1YEiKzdZ3B+PzcS+9V0vTA4KEJfC8izPWS3q6jpIvBUabH2cw7NzdUe0l2EPSqdMGGih1T2HrwebhOTQm8zBlYQQGdi10VrqhbcIO6VM4vgAyvcZB9HJVGX4F/LqvPr7p8YVXE/ecWp2WmVXllcaLv2KIaTKUVNpfSFpk2nQX1S8Js+gUkO1jcFgyiF5OB7PAQAYoYANCXH9Qctg8hNkHswBkUrWSF7dqxwPog== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3086.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(366004)(346002)(396003)(136003)(9686003)(52536014)(2906002)(8936002)(186003)(4744005)(71200400001)(478600001)(4326008)(316002)(86362001)(76116006)(55016002)(6506007)(5660300002)(7696005)(107886003)(450100002)(110136005)(66476007)(33656002)(26005)(66946007)(66446008)(54906003)(64756008)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: kQaPRcvH0BJBoTMpXhWpIlFDJ9US5/4ysFUVMEsw9s1AX8mx2sCTmgilwnTr9opl9Li1C4uoN25EyOepoH1QduFhR7xrsnF40jsvZZKz0VJ8cTvZYCzyoMmOexOJGLmG+RYYdSTV5ripkLCfH0jjl1prG2094i8shf8vTNh6IC38AeBjtm2uKxqb8XS/goqb3QvpdssLdy3YjtF+NUS6ezNLDZoJUzhvWWmSsSwUr4bogBhyc1OIMDCt5469j2us52KCGNwmQ7C3KKQWYDHu+xr4lVdHbxPBFA8dM8ucMgPnOEtL7nCGkwGPAfRD46MOZF838qD9IOynJFW7HfCzi5UN0JM2wZppCfNKOKjwypse68dym2/mAmP8WmUoVfOrhZDTpCDtZcBD5UJTsqMcDx9xWmsv2qfnQcaW61QU8uRBu/Kvz0kc/tqz0vgHbodZ3UUNi0wUchnP/2GfA/75mLhQaEcUIYCFn1xvAtoSYr5vtOXf2ZD00CsgTVKNyoQjgUf9fL8U5U9h4SWC8a3syuoceutDCc6TSOycvERb798CCibT0LzHfmISNyW01Hm22nPVytuXj4eW0PX6McpiB+jB/A/TvNqTdS8xa+Dmy0WpxkjGXgAOPXapgdomDYv4/VqUkp1TRuEfJPDhgvoDkg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3086.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cab64f8-6b5d-4507-34a1-08d85b23f197 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Sep 2020 16:08:40.6507 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cpQYaVuTlDviHg41D1aIQsn9r/HZ+50ObCbzxnL6acRe9X1UgOK/QGuTw12mMvg+ESoICz/3u9u4qBCZc9i3yg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3262 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > If an error occurred when allocating memory for metrics or names, the > function returned without freeing allocated memory. This is now fixed to > avoid the resource leak in the case that either metrics or names had been > successfully allocated memory. >=20 > Coverity issue: 362053 > Fixes: c5b7197f662e ("telemetry: move some functions to metrics library") > Cc: stable@dpdk.org Acked-by: John McNamara