From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B28EA0526; Wed, 22 Jul 2020 09:58:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E89F1BFE4; Wed, 22 Jul 2020 09:58:26 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 378111BFE4 for ; Wed, 22 Jul 2020 09:58:24 +0200 (CEST) IronPort-SDR: b27HoLIfMxLmjnxXTy9TA3hWQ3a0AHfGF0vmHPk3XWsqan106GGQfHbu6qc+GlcCaIxvp9WrMW zJmiUliqEMGQ== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="138370022" X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="138370022" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2020 00:58:23 -0700 IronPort-SDR: nDmnsygLtZho5LLInaJd+cb0i1nbwIvj9BU2DbrJfdQRSq6slUgzeNlhFBgV7Xrvw5UxYzXU8t h0BreXZy13zA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,381,1589266800"; d="scan'208";a="326624600" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by FMSMGA003.fm.intel.com with ESMTP; 22 Jul 2020 00:58:22 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX103.amr.corp.intel.com (10.22.225.130) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 00:58:22 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Jul 2020 00:58:22 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 22 Jul 2020 00:58:22 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Jul 2020 00:58:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jVokrm2D9OlB6TWgWUzzxMCfBd+OxIlHfx6sF8nDlI2t/hnyhBXR/352XIqYey7yXowlwH99+OuZviC4L6LoCY0C8iQLvnh4Ua0484OltdA1/C4CDAIB0LAmEigJ/Jsz1X6anaUJvwt5/1SsvmDvWPvIrM+ybM0ZXD1ZfDCiTs/c2bIbI1MblYsS9gmaziTWtyp30sVYtfoG/NJNyNHZpvGtpalA0FkJA7ThNlmy5Z1Suw7NCNwpnY5KvUBZ7XIksKbmC/UActmHQ9xCgavc4LPndvOxf30j+wKRzADEEGyY5j6f5bFRPqnKHU0a8kbbAjpjkt6YrLszzDVQVJ13ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PkwCFjlzPl/pwtcIapddcUHGa1ugl66b/6A/Si6iZ3g=; b=BcSBWn6bPIRhgRuAyD4LpoyWeQVTq9JkmDRzYERih63DX7sZrXfYkZyqXybuCPty0kAaLWVzyfOQB04Nq/pgUe9Ut9UptH1aO+jkApVyogWRNvEsL3OEn1FT5GgxULau0eWW9Fwl9mrRlY8BNML1Ljl4l1I4brNdIVH1vFDDYKDleST56r4IMbLixGMRt2051NgsgH/eixhDrvJCntGZAn+t2nitdXS+FOGpOKxKXgubPShGUCXxodSvFQbRYLTiUcUhWQ4WNlIFpzsSjvhis8YAjGSdC2hExjW5TEn6SWXRRKamKB9k7GiO2xD3w/9Nyc6eK+yXjUeXeiNrXi56GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PkwCFjlzPl/pwtcIapddcUHGa1ugl66b/6A/Si6iZ3g=; b=BxbVZqDpbb9K6BK3OIdknglsfSR7OHrQJo27KhgCxEAAkXnNj+/8wmdzdhc+gAMuXDzOdHLfsnd5xMivoy5xpW1sBNgrBVOeOf+Y7c+ZwFW1mZjRtln47BRSWcC7iCqIHhLQUiSBNyeNLQSfPKhP8G43wSQ3W0B6Yl+Z4QT4NqM= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB3390.namprd11.prod.outlook.com (2603:10b6:805:c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Wed, 22 Jul 2020 07:58:19 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::ac58:2cf3:c611:9b0]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::ac58:2cf3:c611:9b0%3]) with mapi id 15.20.3195.027; Wed, 22 Jul 2020 07:58:19 +0000 From: "De Lara Guarch, Pablo" To: "Coyle, David" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "Trahe, Fiona" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v2 2/2] crypto/aesni-mb: improve security instance setup Thread-Index: AQHWXpMMwXP+GB8fS0Car+js2ONXfKkTPm+Q Date: Wed, 22 Jul 2020 07:58:19 +0000 Message-ID: References: <20200716153600.66071-1-david.coyle@intel.com> <20200720121621.23628-1-david.coyle@intel.com> <20200720121621.23628-3-david.coyle@intel.com> In-Reply-To: <20200720121621.23628-3-david.coyle@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1499cfe9-c2cf-4e8a-7b11-08d82e14ff66 x-ms-traffictypediagnostic: SN6PR11MB3390: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tXNEB/rdorUgG8y2Zfgehy7jjk9bbBU7iBL/7Whj5IhuGT4s1sc63ziJZFr2u0adcwpoRooxsD7pCjmo+nXHN/knkSdRIo/aEkc+HLHF32bJDZSfxgjq/ocDX0lUWEmoviCmDd4hIhJU9sXmyx0kvQhtZxCV9AekM7at81eN8xWlL7Oq2ONVwPFUMXaShzQdLB2N1CXtVEF6LAoIndg0vJvSbyRrsS3HMKB1hJ8u/sQp5UYuk0PSsZnQ7Q+N5ZUSpXr0pQ8dX6UrwdfEVW+u91VGznaKkTZKbmCG60a9H7nsLZAdFhJcLZbLu+x9emf5k+o3FRnIRGd3lFCyL06HZQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(136003)(346002)(366004)(396003)(376002)(66946007)(76116006)(83380400001)(5660300002)(9686003)(15650500001)(53546011)(86362001)(52536014)(66556008)(7696005)(6506007)(71200400001)(66446008)(33656002)(66476007)(4744005)(64756008)(55016002)(110136005)(6636002)(8936002)(316002)(55236004)(107886003)(26005)(4326008)(186003)(478600001)(8676002)(2906002)(54906003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: CbEV3Gi9sMEq8FTk7CAiEO/ECrmufmPDMTVkNwuCeDFc9Xxl2i8RH7CEl93d1Lu+aGF2ZpnDfy67J6sg8MZOu+bKdHP/vQ2loBLmOUoEUq+V9xvFoq14tPJ9lVTxhM+Zp2QhiiTVc3+MW1+nIEBE0Xs3c89Luq/UB0T3ooUq1azT1xgCumLUbVncBewz/YCMNeevhRoacfpgFIdlK94APpIVkIRhxOsVmQKpOhPXvH2A13477NhsyXDFj6Xp/VadA2X/qrA2ZJDdyk5xCp3TMfe24ksogxHeHKkOuVglai3mSXveQM/QvKI4J0iZH7hRbatiY7DTrfBpdeFEVf7xgLhjIY+QCmt+annHyBWcQLlt6BXzNQmFgp1OstMBomQ4S7d8UPWVFsx/GP59d8QfE2dims3l7MSJ9cA5xRUHy/JJwFOp/u3GNg7n5Ar6CJL3VcL2zIgUI3IZSqj5A5j+GXMS70EObLYzKGo+iq6MvUlgYN55jLKWGS744geVlJVi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3101.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1499cfe9-c2cf-4e8a-7b11-08d82e14ff66 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 07:58:19.0505 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mzRZXRV/Ui1G3EEdWsIrb/in+4S02y2CpeytJYBzlhkJQ2ASOox9Rs6HwyZJ0tz5fYoTv9uJlN0X+3IU99FeHIw09+i+gG1trx9fvYFxwks= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3390 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] crypto/aesni-mb: improve security instance setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Coyle, David > Sent: Monday, July 20, 2020 1:16 PM > To: akhil.goyal@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin ; Coyle, David > Subject: [PATCH v2 2/2] crypto/aesni-mb: improve security instance setup >=20 > This patch makes some improvements to the security instance setup for the > AESNI-MB PMD, as follows: > - fix potential memory leak where the security instance was not freed if > an error occurred later in the device creation > - tidy-up security instance initialization code by moving it all, > including enabling the RTE_CRYPTODEV_FF_SECURITY feature, into one > '#ifdef AESNI_MB_DOCSIS_SEC_ENABLED' block >=20 > Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") >=20 > Signed-off-by: David Coyle Acked-by: Pablo de Lara