Re: [dpdk-dev] [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests

["De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>]

Hi David,

> -----Original Message-----
> From: Coyle, David <david.coyle@intel.com>
> Sent: Thursday, July 16, 2020 4:31 PM
> To: akhil.goyal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; Ryan, Brendan <brendan.ryan@intel.com>; O'loingsigh,
> Mairtin <mairtin.oloingsigh@intel.com>; Coyle, David <david.coyle@intel.com>
> Subject: [PATCH v1] app/crypto-perf: set mbuf lengths correctly for DOCSIS tests
> 
> Set the source mbuf data and packet lengths correctly for DOCSIS performance
> tests.
> 
> Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")
> 
> Signed-off-by: David Coyle <david.coyle@intel.com>
> ---
>  app/test-crypto-perf/cperf_ops.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/app/test-crypto-perf/cperf_ops.c b/app/test-crypto-perf/cperf_ops.c
> index f851509ec..3da835a9c 100644
> --- a/app/test-crypto-perf/cperf_ops.c
> +++ b/app/test-crypto-perf/cperf_ops.c
> @@ -48,6 +48,10 @@ cperf_set_ops_security(struct rte_crypto_op **ops,
>  			} else
>  				buf_sz = options->test_buffer_size;
> 
> +			sym_op->m_src->buf_len = options->segment_sz;
> +			sym_op->m_src->data_len = buf_sz;
> +			sym_op->m_src->pkt_len = buf_sz;
> +

Actually, I am wondering why this is needed at all (for DOCSIS and PDCP). This is already set in " fill_multi_seg_mbuf" or " fill_single_seg_mbuf" (and this was already working without this patch, right?).

Regards,
Pablo