From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC55DA0350; Sun, 10 May 2020 21:33:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 487521C2A5; Sun, 10 May 2020 21:33:11 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 5BFF01C0BD for ; Sun, 10 May 2020 21:33:09 +0200 (CEST) IronPort-SDR: lQmb6+f5z6NYsoVTktbubtav/UhLAM/SU4fdr+rJp57D+G0r6rW/rwditWH/eTas3nb4TUBqYb Zj5+bVCUTlNg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 12:33:08 -0700 IronPort-SDR: Q6vY6HebsACGgqDhED9D/Zo9fHZALBRIfr5akd/Od/5/SclXN66KMEbSfysgPcyHlHF1HHbInk JPWuKzJZvnDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,377,1583222400"; d="scan'208";a="462882686" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga005.fm.intel.com with ESMTP; 10 May 2020 12:33:07 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX107.amr.corp.intel.com (10.22.240.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 12:33:07 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 12:33:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KZLNT3meYTJgc/Dbf/w+Qvoll7NIei889MPQC+9q5aYTLhp2xefeHcsYBsYaiHYdqia42FbPP0OvE+afyXhwTxJNhG6vNzLE32qr2ARGgI2QcFZs4ch7p4vKcVWKUlN4HQLfiWZmooMKr9Ho3ew6VvfxhXvF/w6TVor+FMKG2C0DP+QMxq+J9+0dRbBq+8DkpUXXjqR+FDgvLVTZVODSr0asLLT9tavTJAeFd4LzRZHw7Z9imlNRaIiZaEFHFvuNPc3Y+/ysg9Q1lGpgKJicX2wOVt06KMkHtTw7E7d3K5lM+1JQjbccDdDVCjLu0cmLBJL1Slm8v4fYxiQWWa/MTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1MFgXZoNg/dBLiVO9UiBuwh6NwjIFhqGjuYX13g8ww=; b=EY0wd+ywdbLs1sl3JQB527rlWmJYHnTiRt87OfcegJj0YXGJsgaOUzXBcqG1JzRLVDeCzyhVEaOvkUkYGomVvwJOKTQxQ9hBb+SjS5/L0xjHnCa8uDjlmyIFF6qBzSuauYMnP1msudCXK/JCI5hbp3Ez117iIy9PWYy25PKAsh8wKSonmpT7sxklPBCdHRBlOTIgeX4JLzQfCiR3EGRw02nid0+omZEXi9qygarIbPOmB90mX9ZKUu1M0pP7bOmMO2HslAzIZ8J7ris/WVdVqtI58xOG0tBU+8rIL9p3Rrh5BeOy0X2CBaqhb3qc1l+nZ9jSIKBM6tUguHquSusVDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X1MFgXZoNg/dBLiVO9UiBuwh6NwjIFhqGjuYX13g8ww=; b=aZgqQXOW/Hz0IJVDW0VSG7aG48Y0kMHAnESF/aemQakwQwaO81AQvo5yWLUL9Lys382W0MYJ0JmoOvz9X0RRR3Kiz8S6OXJ3vXsBNir5Cz+135kVeePTXq1nrkvZLQ5Y1fGi2YRdBUOAKt/HJSxLqDWorS4EPReiRMcCrzMagu4= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB2720.namprd11.prod.outlook.com (2603:10b6:805:56::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Sun, 10 May 2020 19:33:05 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::7d0f:735a:8d8b:1d40%7]) with mapi id 15.20.2958.035; Sun, 10 May 2020 19:33:05 +0000 From: "De Lara Guarch, Pablo" To: Akhil Goyal , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54 Thread-Index: AQHWF/3+dop6P2RaP0WfAVKqyRUn76igOYIAgAGZ/dA= Date: Sun, 10 May 2020 19:33:04 +0000 Message-ID: References: <1587488214-68422-1-git-send-email-pablo.de.lara.guarch@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8aca77eb-d1e0-48e8-1b24-08d7f518f611 x-ms-traffictypediagnostic: SN6PR11MB2720: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 039975700A x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /Fb9DgyJnRbt1NOnN1xvfzUCBE1qVCIxPLy7r3oefui75AzNMPXJAdBoXarfg5Zmbx34YH1HEaopjCY5fcUP90XQKfz+PsqyLP64rbb9EHbabkD9dCTeFc556BBISqYvF4RJlipNSwqyaQFrDmzLokniPazpOfHlVWtlElxArr3RH2JO7eGIJwlUrc+Jh9J5ulqkJLlDVvDWBOF2U3MsxwYKQ0mfBa2pPg1RIAOeEzJxImwP6Ih3wYtTpyTbnM/Uol5T5a57yb6j5Jqs3hEczTrUa4ytNABglAonUsgp1QE8T50ZKN8ZP0Mum2s5Bmr3d04/ML2ouLbr7yNZhrJnZlkfKWTG5zrcICA4Re63qxxBU4cChIcNAM9HUN/im53p09uX+6pK7+gBmz/JOPsSe0R3OHsioSRoREczq8GPR2lDSqNHrtIOcuGdkm6kN4JFmoeHN5DiYJMC3j0SWCJaQ4mXJyRMIFwLhwhMYLVgXfsRwwkfxkikuvwFZP+ltz0Sq9y6rUt/o1IsD5IL44jckQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(136003)(346002)(376002)(396003)(39860400002)(366004)(33430700001)(53546011)(6506007)(2906002)(186003)(9686003)(33656002)(5660300002)(71200400001)(478600001)(8936002)(26005)(86362001)(316002)(110136005)(52536014)(55016002)(33440700001)(76116006)(66946007)(66556008)(66446008)(66476007)(64756008)(4744005)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: AUf/W1hktTol2zm+NENDBIAyRrWdjPvuYPFPSbv+3Y7vL7+qBL/9XrcV+AFAhB2BCj9saKXn05eslT6PQsJZbb5JvQoYaWPH+An521N3Epuf3DaHiLv61JwRh/0wa4bpzHrtnJ3jHzOq+dow6+TSYGS6ldqHjM4x/HIOPH0N4+xLGiSelvzoJixP5UbqcitvjGlr+tX6x3A/TjZbvsAZdfHdkcYAg2HliGZvGGh8E0IuxhtV1ONYY78df/iWN+8orkveOI9PALwDfzdiBoebNwLKy8rMGNWDJK4Wtmo+l0e/Hda5NajQl9DmjocLwOls7uOkFqGU8PND6aPtWQvRUqApDbsroBJYEq+DpCwH4QSzjBgHPRS6mjCbJ+qPHtxOxmCBNc/Csx8fbOR3x5M8/4riuUfeGcP3dmnpX2MDp+U1wa0rwDDK10b7U3Z30UjrTabHv6ZFuGzwTJcOmMLK5YkfYz5pbIo2/cIDhuvZSBqVLa4eujSezBzJ01rfzqw7 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8aca77eb-d1e0-48e8-1b24-08d7f518f611 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2020 19:33:04.9682 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y0+6X0tZxYihJhd0vRMkDblyo3oo/ClajwFda1HQivwJE0j/m0kb9tpKzwSR/lqjmaazS/4erq3kmzd4GvbE873QerP5G9YNor57N8ctoyI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2720 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffer lib v0.54 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > -----Original Message----- > From: Akhil Goyal > Sent: Saturday, May 9, 2020 8:05 PM > To: De Lara Guarch, Pablo ; dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] crypto/zuc: support IPSec Multi-buffe= r lib > v0.54 >=20 > Hi Pablo, >=20 > > +#if IMB_VERSION_NUM >=3D IMB_VERSION(0, 53, 3) > > + processed_ops =3D process_zuc_hash_op_mb(qp, ops, sessions, > > + num_ops); > > +#else > > processed_ops =3D process_zuc_hash_op(qp, ops, sessions, > > num_ops); > > +#endif > > break; >=20 > Instead of having a separate name for process_zuc_hash_op in case of newe= r > IMB version, Is it not better to have same name of the function but havin= g > different definitions for different IMB version. This way you can reduce = the #ifs > in the code. Good suggestion. Will send a v2 shortly. Thanks, Pablo >=20 > Regards, > Akhil