From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BBACA0528; Fri, 17 Jul 2020 21:29:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26DD61BEE1; Fri, 17 Jul 2020 21:29:34 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 1A9841BEBF for ; Fri, 17 Jul 2020 21:29:31 +0200 (CEST) IronPort-SDR: oGYidG5cQpvBuo8QghF2nbaXf/VNFnyPEjW07L1s87GOV7OVERjqtAf9qht+iZF5qWTG8j9z3M /Vsi/1Td+q+w== X-IronPort-AV: E=McAfee;i="6000,8403,9685"; a="129231843" X-IronPort-AV: E=Sophos;i="5.75,364,1589266800"; d="scan'208";a="129231843" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2020 12:29:31 -0700 IronPort-SDR: UTILpjxaGBYMzMQZWazV5k+IVWESii9GhWTGbaV4sr8a4EvUIjpxTSKtIo4Nq6BXiL1Pmci29t 4BeD1Bt+uUwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,364,1589266800"; d="scan'208";a="486563061" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 17 Jul 2020 12:29:30 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 12:29:30 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 12:29:30 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Jul 2020 12:29:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UI5tK9e7VadYrGrS8jHo9+yKrNcnTRvi6tm75FVeJHyD2Xu1aOFnBE+fuhJjeVflH3Q0t+HbMOOaW11L6CSimOtCtG8wPNh3NSMMjzRk1jLtVs9clezmGMCe4Dx9sSHtsEzNaiLh48jiqoNvJOIFBFl/+lIr90cDfa05IUwykEKYi4hcOI+2K6OwVqiJ6PdvL+24HM82rFeXT4vyLmPZ9mqAf+smyP+PkQjlZ3DyEG9VwCtWhrFbpUo9FbEVuBE4lolCFNZ5wz/+vXCkGfyOyvbTXt80Zf30hbCjOpcZB+vQo/JPrGHmhSAVE66KUQX4eevCDVEB1Q/UCX0VattsnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sveEs+tT3cmsA/bNIdQ+va2Z2Lqdawei/KyKgmBVayo=; b=X2kax7hZT3mfRar5XHqxcxGSFJZ02Qkz/XV7t7Vo9NFA++ye93KWO3GK67wmFSYc5PYlnVBf4XNXCScUugj9pjxYzoHkTpPzCIh13U90PfV5FcdE19LBkkBGgApne6WVMfSbz4Oq+qrVJQjxgytZceh2gISqOwjwdVxdS0ToWTlKieJoLOl0+P3lJTwcaYNNaddFcuDE7dgx5iJYJPfQY274t2GDV8XScbGDl2QOPtYn78b9qJoYPlZ92xjSKuRXMzr6tBtW0cSD5BSq5xpqwHsDTzWso/sRGSCIvZrbHSzMK/Q7LeDTMuhuZKmCHfTufbaiHXO93KJrgMcjFjFhKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sveEs+tT3cmsA/bNIdQ+va2Z2Lqdawei/KyKgmBVayo=; b=sZ+dxluq5kON7Oq5MvZayBp9yUeiqhrWwBaMJGO7SkiSQSZDdIhviM069dhOBFKZkP+AQ5ytyL3f+jnRLw9ugVrAZ6SxfGp4vzfdI1qUCUcg/YSLQIJefT/hHTJuYu0cxyuhFTB66PIR7qaTlC0ARPp7yR2wwhP9bBnMtLYqABs= Received: from SN6PR11MB3101.namprd11.prod.outlook.com (2603:10b6:805:d8::23) by SN6PR11MB3488.namprd11.prod.outlook.com (2603:10b6:805:b8::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21; Fri, 17 Jul 2020 19:29:28 +0000 Received: from SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::ac58:2cf3:c611:9b0]) by SN6PR11MB3101.namprd11.prod.outlook.com ([fe80::ac58:2cf3:c611:9b0%3]) with mapi id 15.20.3174.026; Fri, 17 Jul 2020 19:29:28 +0000 From: "De Lara Guarch, Pablo" To: "Coyle, David" , "akhil.goyal@nxp.com" , "Doherty, Declan" , "Trahe, Fiona" CC: "dev@dpdk.org" , "Ryan, Brendan" , "O'loingsigh, Mairtin" Thread-Topic: [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup Thread-Index: AQHWW4pKJpOt43B9JUaqTA/YoULIoqkMKAlw Date: Fri, 17 Jul 2020 19:29:28 +0000 Message-ID: References: <20200716153600.66071-1-david.coyle@intel.com> <20200716153600.66071-3-david.coyle@intel.com> In-Reply-To: <20200716153600.66071-3-david.coyle@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.188.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d3fc9182-5930-4d73-7bd5-08d82a87b8f0 x-ms-traffictypediagnostic: SN6PR11MB3488: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +d6xunvigO52n9dMio2JKCBYbGCTpnR4H4Q7JRIXU1xnOlsMZv5LQUGcKHjIkBcaEfBj/8VMgBT6x9gTvpKib4gNV170JuTin7Ob+jqUpM9cgtAGkNw67NNQyWaJo2CFvAOzhslazz78JQa0kYL/4Ov8NplEgMEGPQcfwoSrOC7bIOUQyzN1UorgunZDkBa0/K4U4sbVUPS5OEzSRL/+t75EEqruL4FIgeV6DVzoeEmGlJZWunxU4+SA/seMC3N3I+XyY/0B9aKg94Xhq/FxyvXuQo6/XX/D1pGTNpWoeqxAHkDe6odiEwYH9Ep/f5g7MdlHhLORN5kx78cXzeZRuA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR11MB3101.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(8936002)(66476007)(55016002)(64756008)(8676002)(186003)(66446008)(66556008)(66946007)(26005)(7696005)(86362001)(316002)(478600001)(110136005)(83380400001)(4326008)(9686003)(33656002)(2906002)(5660300002)(6636002)(107886003)(76116006)(71200400001)(54906003)(55236004)(52536014)(15650500001)(6506007)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: zJpYN0ILmVu57uc+UhwA2XAEVUr3b5lYGucRnkYC21SZHjprvP7A6Q7YmY5/3913dUyzkkgmHM5UhqIVzDwkB4KOfOkaKD5AbFOV9hMDfFH2Ut/D3CDSvdhcJSETNLWDapej97jNfNwgErmFf9dxJjVBm4HniZSjZ01kkET6MPz+S5ueHmjppe0V7lRrc9hXNdEMxijJ0Cnhtt+rR+WbG8nzCrWRYIZWkAA4WtRdibu/zB2O5f0jgwtNtOys4MvbSTMzBgOK94vzyA54A/qzBQ4l5K5g607F0cA1L7JFOlaxCxw8C00COXZ+Y6TdmbJhEZhk1qXSbBgmjTWFxPYUhn6BfyLhctQzYx8Rl7/pw1yl0RyVbXSGtOb3z2vy/uCIbXw1wzS6aJIahsvjLsC4JjGcMxXbs0Q/Ko//elqgoqXcZYp+gt2CfYt/q8wekC/QI0v37v5ybhDDlgxm2wa8rMZ/b+3Dis7vXMEe2mNIViVygdJ2+1vouAjLth/SdDhm Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3101.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3fc9182-5930-4d73-7bd5-08d82a87b8f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jul 2020 19:29:28.2815 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tkvWuZLIz2vEX8T7sDk04n017CNjBsuIk8RXs3BRAByF9JZQY/bRTG1AADCYC3xnFQBhRbUYR5PjxKTPzSEVjhAzDmsZ6mfuSi+el9FTiVE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3488 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi David, > -----Original Message----- > From: Coyle, David > Sent: Thursday, July 16, 2020 4:36 PM > To: akhil.goyal@nxp.com; Doherty, Declan ; De > Lara Guarch, Pablo ; Trahe, Fiona > > Cc: dev@dpdk.org; Ryan, Brendan ; O'loingsigh, > Mairtin ; Coyle, David > Subject: [PATCH v1 2/2] crypto/aesni_mb: improve security instance setup >=20 > This patch makes some minor improvements to the security instance setup f= or > the AESNI-MB PMD. All of this setup code is now in one '#ifdef > AESNI_MB_DOCSIS_SEC_ENABLED' block. Enabling the > RTE_CRYPTODEV_FF_SECURITY feature for the device is also moved to this > block. >=20 > Fixes: fda5216fba55 ("crypto/aesni_mb: support DOCSIS protocol") >=20 > Signed-off-by: David Coyle > --- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > index b54c57f86..171d914a3 100644 > --- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > +++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c > @@ -1881,9 +1881,6 @@ cryptodev_aesni_mb_create(const char *name, > struct aesni_mb_private *internals; > enum aesni_mb_vector_mode vector_mode; > MB_MGR *mb_mgr; > -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED > - struct rte_security_ctx *security_instance; > -#endif >=20 > dev =3D rte_cryptodev_pmd_create(name, &vdev->device, init_params); > if (dev =3D=3D NULL) { > @@ -1912,13 +1909,10 @@ cryptodev_aesni_mb_create(const char *name, > RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING | > RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT | > RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO | > - RTE_CRYPTODEV_FF_SYM_SESSIONLESS > -#ifdef AESNI_MB_DOCSIS_SEC_ENABLED > - | RTE_CRYPTODEV_FF_SECURITY > -#endif > - ; > + RTE_CRYPTODEV_FF_SYM_SESSIONLESS; >=20 > #ifdef AESNI_MB_DOCSIS_SEC_ENABLED > + struct rte_security_ctx *security_instance; > security_instance =3D rte_malloc("aesni_mb_sec", > sizeof(struct rte_security_ctx), > RTE_CACHE_LINE_SIZE); I see that there could be a potential memory leak here. Assuming this malloc works, if alloc_init_mb_mgr() fails, this memory will = not be freed. So I suggest two options: 1 - Free security_instance if alloc_init_mb_mgr() fails 2 - Move this piece of code after alloc_init_mb_mgr and free mb_mgr if this= malloc fails. Thanks, Pablo